vcd: port to 1.0

Submitted by Onkar Shinde

Assigned to Reynaldo H. Verdejo Pinochet

Link to original bug (#547661)

Description

I should have logged this bug long time ago. But I didn't keep an eye on release schedule.

Now the VCD plugin works properly and plays any track with command 'gst-launch-0.10 playbin uri=vcd://n', it will be nice if seek support is added so that VCD can be played from totem with seek, track changes etc.

Walter Cheuk said:

VCDs just play the first track and stop. Please help to fix it.

Tim Müller @tpm said:

Let's re-purpose this bug as a port-to-1.0 enhancement bug, and hopefully whoever ports it can also take care of the seeking then.

Other vcd issues: bug 325441 (vcdsrc doesn't handle CUE/BIN images) and bug 733794 (Error trying to play a VCD from a CDR).

Tim Müller @tpm closed a related bug:

*** Bug 733794 has been marked as a duplicate of this bug. ***

Tim Müller @tpm closed a related bug:

*** Bug 325441 has been marked as a duplicate of this bug. ***

Reynaldo H. Verdejo Pinochet said:

I will take care of this one.

Reynaldo H. Verdejo Pinochet submitted a patch:

API only port to 1. Untested

Patch 291951, "vcdsrc: port to 1.":
0001-vcdsrc-port-to-1.patch

Sebastian Dröge @slomo reviewed patch 291951:

Looks almost ready, good work :)

::: sys/vcd/vcdsrc.c  
@@ +356,3 @@  
+error_mapped:  
+  gst_buffer_unmap (outbuf, &map_info);  
+error_unmapped:  

You should also unref outbuf here

@@ +476,1 @@  
 gst_vcdsrc_uri_get_uri (GstURIHandler * handler)  

This change probably means that you need to g_strdup() the URI you return

Reynaldo H. Verdejo Pinochet said:

Thanks for taking a look Sebastian

(In reply to comment 7)

Review of attachment 291951 [details]:
[...]
::: sys/vcd/vcdsrc.c
@@ +356,3 @@
+error_mapped:

• gst_buffer_unmap (outbuf, &map_info);
  +error_unmapped:

You should also unref outbuf here

Done

@@ +476,1 @@
gst_vcdsrc_uri_get_uri (GstURIHandler * handler)

This change probably means that you need to g_strdup() the URI you return

Not sure I understand. I'm already duping that return

Reynaldo H. Verdejo Pinochet submitted a patch:

unref buffer at failure

Patch 292137, "vcdsrc: port to 1.":
0001-vcdsrc-port-to-1.patch

Sebastian Dröge @slomo said:

(In reply to comment 8)

@@ +476,1 @@
gst_vcdsrc_uri_get_uri (GstURIHandler * handler)

This change probably means that you need to g_strdup() the URI you return

Not sure I understand. I'm already duping that return

I see, then this code was leaking in 0.10 ;)

Reynaldo H. Verdejo Pinochet commented on patch 292137:

Not closing the bug yet as there are related and
pending enhancements requested but pushed the
port to 1.0 to get this started. Thanks again for the review.

commit 89eb1e9a
Author: Reynaldo H. Verdejo Pinochet reynaldo@osg.samsung.com
Date: Mon Dec 1 16:40:24 2014 -0300

vcdsrc: port to 1.

After four years, I don't think there's much point in keeping this open.

In fact, I'm wondering if anyone is actually using this plugin or if it should just be removed.

closed

mentioned in issue #876 (closed)

See also !203 (merged), this port was always incomplete.

mentioned in issue #914

mentioned in issue #925

mentioned in issue #1269 (closed)

mentioned in merge request !1928 (merged)

mentioned in issue #1519 (closed)