Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-bad
gst-plugins-bad
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,011
    • Issues 1,011
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 199
    • Merge Requests 199
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-badgst-plugins-bad
  • Issues
  • #557

Closed
Open
Opened May 18, 2017 by Bugzilla Migration User@bugzilla-migration

h264parse: Alignment of input caps no longer set to a default value

Submitted by Will

Link to original bug (#782778)

Description

In the following change the 'handling of input caps corner cases for the h264parse element" was tidied up.

https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/gst/videoparsers/gsth264parse.c?h=1.4&id=ea7d5027a079fad397b0ad97a0be48c69121e30e

Although not sure, I believe that there may have been an unintended behavioural change with the above submission.

Prior to the submission, when the stream format was not specified in the input caps the local 'format' variable was assigned a default value of GST_H264_PARSE_FORMAT_BYTE and the local 'alignment' variable was assigned a default value of GST_H264_PARSE_ALIGN_AU.

After the submission when the stream format was not specified in the input caps the local 'format' variable was assigned a default value of GST_H264_PARSE_FORMAT_BYTE and the local 'alignment' variable was left unchanged.

When 'format' is given a default value, should alignement be given a value that is appropriate for the chosen default stream format? Not doing so, can result in unexpected behaviour of the gst_h264_parse_negotiate() method that gst_h264_parse_set_caps() calls

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gstreamer/gst-plugins-bad#557