Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-plugins-bad gst-plugins-bad
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 973
    • Issues 973
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 105
    • Merge requests 105
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gst-plugins-badgst-plugins-bad
  • Issues
  • #1545
Closed
Open
Issue created Mar 08, 2021 by Sebastian Dröge@slomo🍵Owner0 of 3 checklist items completed0/3 checklist items

avtp: Various memory and socket handling issues

The following discussions from !361 (merged) should be addressed:

  • @slomo started a discussion:

    This is suboptimal as it blocks until a packet is received, which makes pipeline shutdown a bit exciting :) This should probably make use of GstPoll or directly use the gio GSocket API. Unblocking this function here should happen as part of GstBaseSrc::unlock.

  • @slomo started a discussion:

    Casting raw data like this is inviting SIGBUS and endianess issues and all kinds of undefined behaviour. It would be better to use a GstByteReader or similar here.

    The same probably applies to other code too, but this one caught my eye.

  • @slomo started a discussion:

    Raw audio data needs to be properly aligned according to the basic sample type (e.g. 2-byte aligned for S16). This is not ensuring that the alignment is correct.

That's what I found while looking for 5 minutes. The whole plugin should probably get another review.

Assignee
Assign to
Time tracking