avtp: Various memory and socket handling issues
The following discussions from !361 (merged) should be addressed:
This is suboptimal as it blocks until a packet is received, which makes pipeline shutdown a bit exciting :) This should probably make use of
GstPollor directly use the gio
GSocketAPI. Unblocking this function here should happen as part of
Casting raw data like this is inviting
SIGBUSand endianess issues and all kinds of undefined behaviour. It would be better to use a
GstByteReaderor similar here.
The same probably applies to other code too, but this one caught my eye.
Raw audio data needs to be properly aligned according to the basic sample type (e.g. 2-byte aligned for S16). This is not ensuring that the alignment is correct.
That's what I found while looking for 5 minutes. The whole plugin should probably get another review.