GitLab

Jakub Adam authored Jan 27, 2022 and Tim-Philipp Müller committed Jan 28, 2022

Failing to do so makes GstWebRTCBin invisible to the leaks tracer.

Part-of: <!2570>

Dave Piché authored Jan 11, 2022 and Tim-Philipp Müller committed Jan 18, 2022

Part-of: <!2569>

If the VANC track does contain packets, but we skip over all packets, just
treat it the same as if there hadn't been any packets at all and send a
GAP event instead of erroring out with "Failed to handle essence element".

We would error out because when we reach the end of the loop without having
found a closed caption packet the flow return variable is still FLOW_ERROR
which is what it has been initialised to.

Part-of: <!2568>

Mengkejiergeli Ba authored Jan 10, 2022 and Tim-Philipp Müller committed Jan 18, 2022

Fix cb_offset and cr_offset data type from guint8 to guint16. According
to spec, cb_offset and cr_offset are 9 bit long, while guint8 can cause
interger overflow, and thus change to guint16.

Part-of: <!2567>

Rafał Dzięgiel authored Dec 29, 2021 and Tim-Philipp Müller committed Jan 17, 2022

Old "application/*" are now as per RFC8081 deprecated in favor of
new "font/*" mime types. Some new encoders are already using the
updated mime types. We need to also add them to the support list
in order for assrender to correctly identify them as fonts.

Part-of: <!2566>

Rafał Dzięgiel authored Jan 20, 2021 and Tim-Philipp Müller committed Jan 17, 2022

The "application/vnd.ms-opentype" mimetype is commonly used in many fonts attached in the matroska videos.
Assrender should treat it as compatible without the need of parsing the file extension.

Part-of: <!2566>

Rafał Dzięgiel authored Dec 29, 2021 and Tim-Philipp Müller committed Jan 17, 2022

TTC stands for "TrueType Collection" file. We can pass it
into libass as any other attachment. Add it to the supported
extensions list, so the fonts it contains will be used.

Part-of: <!2566>

Thibault Saunier authored Dec 11, 2021 and Tim-Philipp Müller committed Jan 17, 2022

There are cases where it might negotiate 'non-interleaved' while it
is wrong.

```
gst-launch-1.0 audiotestsrc !  "audio/x-raw, format=(string)F32LE, layout=(string)non-interleaved" ! audioconvert ! audioresample ! pitch tempo=1.2 ! audioconvert ! "audio/x-raw,format=S16LE" ! fakesink

Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
(gst-launch-1.0:3029628): GStreamer-Audio-CRITICAL **: 11:42:22.477: gst_audio_buffer_map: assertion '(!meta && info->layout == GST_AUDIO_LAYOUT_INTERLEAVED) || (meta && info->layout == meta->info.layout)' failed
ERROR: from element /GstPipeline:pipeline0/GstAudioConvert:audioconvert1: The stream is in the wrong format.
Additional debug info:
../subprojects/gst-plugins-base/gst/audioconvert/gstaudioconvert.c(876): gst_audio_convert_transform (): /GstPipeline:pipeline0/GstAudioConvert:audioconvert1:
failed to map input buffer
ERROR: pipeline doesn't want to preroll.
ERROR: from element /GstPipeline:pipeline0/GstAudioTe...

Antonio Ospite authored Nov 05, 2021 and Tim-Philipp Müller committed Nov 05, 2021

Part-of: <!2561>

Seungha Yang authored Oct 30, 2021 and GStreamer Marge Bot committed Oct 31, 2021

As documented, slice header parsed via gst_h265_parser_parse_slice_hdr()
should be cleared, otherwise it would result in memory leak.

Part-of: <!2559>

With mpeg4videoparse drop=false config-interval=N|-1 we might be
trying to insert a config before we have actually received one,
in which case we'll try to map a NULL buffer which will generate
lots of criticals.

Fixes #855

Part-of: <!2558>

Sebastian Dröge authored Sep 23, 2021 and Tim-Philipp Müller committed Oct 31, 2021

webrtcbin can act as a sink/source depending on the SDP later. Without
setting this here already, surrounding bins might not notice this and
the pipeline configuration might become inconsistent, e.g. with regards
to latency.

See gstreamer#737

Part-of: <!2556>

Vivia Nikolaidou authored Aug 16, 2021 and GStreamer Marge Bot committed Oct 29, 2021

Theoretically the version number is incremented every time there's a new
section, but in a world of streaming we can't easily make that
assumption.

An example of a broken use case is when we're cat-ing two mpeg-ts files
together, which is equivalent of capturing a DVB stream while switching
channels. A set-top box would know that we switched the channels and
reset the demuxer, but in practice this might not happen.

Part-of: <!2555>

Stéphane Cerveau authored Feb 25, 2021 and Tim-Philipp Müller committed Oct 29, 2021

Support new API in 1.1.1
Update the supported input video format.
Update tests to use parse_launch

Part-of: <!2554>

Trying to reset before the pads have been deactivated races with the
streaming thread. There was also a buggy buffer clear leaving a dangling
`stored_frame` pointer around. Use `gst_interlace_reset` so this happens
properly.

Part-of: <!2553>

Mathieu Duponchelle authored Sep 08, 2021 and Tim-Philipp Müller committed Sep 08, 2021

hotdoc doesn't know about that symbol

Part-of: <!2518>

Thibault Saunier authored Mar 31, 2021 and Tim-Philipp Müller committed Sep 06, 2021

We can reset the URI to NULL and this fix a deadlock in that case or
when the URI was invalid.

Part-of: <!2512>

Edward Hervey authored Jun 03, 2021 and Tim-Philipp Müller committed Sep 06, 2021

This avoids sending out partial invalid data downstream which could cause
decoders (ex: `dvdlpmdec`) to error out.

Part-of: <!2511>

Jan Schmidt authored Aug 30, 2021 and Tim-Philipp Müller committed Sep 06, 2021

Having an unlimited input queue is very bad if the
encoder can't run at real-time. Eventually it will
consume all RAM. I don't really see any reason to
have more than 1 outstanding encoded frame, so
remove the queue and limit things to 1 pending frame.

Part-of: <!2510>

Seungha Yang authored Sep 02, 2021 and Tim-Philipp Müller committed Sep 02, 2021

The minimum possible size of valid CEA708 data is 3 bytes, not 7 bytes

Part-of: <!2507>

Mathieu Duponchelle authored Aug 05, 2021 and Tim-Philipp Müller committed Aug 30, 2021

Previously, the code was always assuming progressive input,
fix this by looking at the caps.

Part-of: <!2500>

This encoder advertises alignment=au as output format, which means
each output frame should contain a full decodable access unit.

The video encoder base class is not aware of our output alignment
and will output spurious buffers with just the SPS/PPS inside when
we call gst_video_encoder_set_headers(), which is broken because
each buffer is supposed to contain a full decodable access unit
in our case.

Just don't tell the base class about our headers, they will be
sent at the beginning of each IDR frame anyway.

Part-of: <!2478>

Part-of: <!2478>

This was putting a truncated SPS into the initial header instead
of the PPS because it was always reading from the beginning of the
bitstream buffer (pBsBuf) and not from the offset where the current
NAL is at in the bitstream buffer (psBsBuf + nal_offset).

This was broken in commit 17113695.

Fixes #1576

Part-of: <!2478>

Edward Hervey authored Aug 20, 2021 and Edward Hervey committed Aug 23, 2021

Part-of: <!2479>

Seungha Yang authored Aug 19, 2021 and Tim-Philipp Müller committed Aug 20, 2021

Negative stride value can be used in MediaFoundation to inform
whether memory layout is top-down or bottom-up manner. Note that
negative stride is allowed only for RGB, system memory.

See also
https://docs.microsoft.com/en-us/windows/win32/medfound/image-stride

Fixes: #1646
Part-of: <!2477>

Nicolas Dufresne authored Aug 18, 2021 and Tim-Philipp Müller committed Aug 18, 2021

The emulation bytes need to be removed as bytes, not bit. This fixes
decoding issues with files that have emulation bytes with the Cedrus
driver.

Part-of: <!2472>

He Junyan authored Aug 04, 2021 and Tim-Philipp Müller committed Aug 09, 2021

The GST_ELEMENT_ERROR will call the gst_object_get_path_string and
use gst_object_get_parent to get the full object path name, which
needs to lock the object. But we are already in a locked context and
so this will cause a deadlock, the pipeline can not exit normally.

Part-of: <!2460>

pipewiresrc outputs audio buffers without a valid duration, so we need
to calculate it manually in that case.

Upstream issue: pipewire/pipewire#1438

Part-of: <!2444>

Matthew Waters authored Jul 13, 2021 and Tim-Philipp Müller committed Jul 16, 2021

https://gitlab.gnome.org/GNOME/glib/-/issues/803

Basically, if destruction of a GSource and its associated GMainContext are
not synchronised, Then the GSource destruction can access freed
GMainContext resources and cause a crash.  This is not super common but
can happen.

Part-of: <!2416>

Follow-up from:
!2392

Part-of: <!2395>

Philippe Normand authored Jul 08, 2021 and GStreamer Marge Bot committed Jul 08, 2021

GstDashDemuxStream is not a GstObject, so use its pad as associated object when
emitting log messages.

Part-of: <!2392>

Seungha Yang authored Jul 08, 2021 and Tim-Philipp Müller committed Jul 08, 2021

Given caps does not need to be strictly subset of device caps.
Allow accept it if device caps and requested caps can intersect

Fixes: #1619
Part-of: <!2391>

Matthew Waters authored Jul 02, 2021 and GStreamer Marge Bot committed Jul 08, 2021

We can only convert from non-cdp to cdp within the confines of valid cdp
framerates.  The existing caps negotiation code was allowing any
framerate to convert to a cdp output which is incorrect and would hit an
assertion later.

Part-of: <!2388>

Edward Hervey authored Jun 21, 2021 and GStreamer Marge Bot committed Jul 08, 2021

Not having any *actual* ANC is totally fine and common usage with several MXF
variants.

In order to properly advance the streams, the essence handler returns an empty
GAP buffer which gets converted to a GST_EVENT_GAP.

Part-of: <!2387>

Youngsoo Lee authored Jun 30, 2021 and Tim-Philipp Müller committed Jul 08, 2021

The build fails on macos with the following error:
/usr/local/Cellar/opencv/4.5.0_5/include/opencv4/opencv2/core/mat.hpp:2226:15: error: no template named 'initializer_list' in namespace 'std'
      Mat_(std::initializer_list<_Tp> values);
fatal error: too many errors emitted, stopping now [-ferror-limit=]
 35 warnings and 20 errors generated.

Part-of: <!2386>