Commit 7391ff71 authored by Sebastian Dröge's avatar Sebastian Dröge 🍵 Committed by Tim-Philipp Müller
Browse files

webrtcbin: Always set SINK/SRC flags

webrtcbin can act as a sink/source depending on the SDP later. Without
setting this here already, surrounding bins might not notice this and
the pipeline configuration might become inconsistent, e.g. with regards
to latency.

See gstreamer#737

Part-of: <!2556>
parent 5c000cb0
Pipeline #436373 waiting for manual action with stages
in 1 minute and 35 seconds
...@@ -6568,6 +6568,16 @@ _transport_free (GObject * object) ...@@ -6568,6 +6568,16 @@ _transport_free (GObject * object)
static void static void
gst_webrtc_bin_init (GstWebRTCBin * webrtc) gst_webrtc_bin_init (GstWebRTCBin * webrtc)
{ {
/* Set SINK/SRC flags as webrtcbin can act as one depending on the
* SDP later. Without setting this here already, surrounding bins might not
* notice this and the pipeline configuration might become inconsistent,
* e.g. with regards to latency.
* See: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/737
*/
gst_bin_set_suppressed_flags (GST_BIN_CAST (webrtc),
GST_ELEMENT_FLAG_SINK | GST_ELEMENT_FLAG_SOURCE);
GST_OBJECT_FLAG_SET (webrtc, GST_ELEMENT_FLAG_SINK | GST_ELEMENT_FLAG_SOURCE);
webrtc->priv = gst_webrtc_bin_get_instance_private (webrtc); webrtc->priv = gst_webrtc_bin_get_instance_private (webrtc);
g_mutex_init (PC_GET_LOCK (webrtc)); g_mutex_init (PC_GET_LOCK (webrtc));
g_cond_init (PC_GET_COND (webrtc)); g_cond_init (PC_GET_COND (webrtc));
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment