From 10e060649109ffb790a2b5bbfa978fd5d5c6ddd5 Mon Sep 17 00:00:00 2001
From: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date: Fri, 6 Jun 2014 12:40:57 +0100
Subject: [PATCH] avaudenc: add a comment about using -1 in _finish_frame

See https://bugzilla.gnome.org/show_bug.cgi?id=729268
---
 ext/libav/gstavaudenc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ext/libav/gstavaudenc.c b/ext/libav/gstavaudenc.c
index a9aa88a..0408104 100644
--- a/ext/libav/gstavaudenc.c
+++ b/ext/libav/gstavaudenc.c
@@ -554,6 +554,9 @@ gst_ffmpegaudenc_encode_audio (GstFFMpegAudEnc * ffmpegaudenc,
 
     codec = ffmpegaudenc->context->codec;
     if ((codec->capabilities & CODEC_CAP_VARIABLE_FRAME_SIZE) || !audio_in) {
+      /* FIXME: Not really correct, as -1 means "all the samples we got
+         given so far", which may not be true depending on the codec,
+         but we have no way to know AFAICT */
       ret = gst_audio_encoder_finish_frame (enc, outbuf, -1);
     } else {
       ret = gst_audio_encoder_finish_frame (enc, outbuf, frame.nb_samples);
-- 
GitLab