ChangeLog 46.3 KB
Newer Older
1 2 3 4 5 6 7
2005-06-25  Luca Ognibene  <luogni@tin.it>

	* ext/libpostproc/gstpostproc.c: (gst_ffmpeg_log_callback),
	(plugin_init):
	* ext/libpostproc/gstpostproc.h:
	fix debug output

8 9 10 11 12 13 14 15
2005-06-25  Sebastien Cote <sc5@hermes.usherb.ca>

	Reviewed by: Luca Ognibene <luogni@tin.it>
	
	* ext/ffmpeg/gstffmpegenc.c (gst_ffmpegenc_chain_video): 
	set the GST_BUFFER_DELTA_UNIT while encoding
	fix #308804

16 17 18 19 20
2005-06-20  Edward Hervey  <edward@fluendo.com>

	* ext/libpostproc/gstpostproc.c: (gst_postproc_register):
	It works better when filing the hash_table BEFORE registering the element.
	
21 22 23 24 25 26 27 28 29 30 31 32
2005-06-20  Edward Hervey  <edward@fluendo.com>

	* ext/Makefile.am: (SUBDIRS):
	* ext/libpostproc:
	* ext/libpostproc/Makefile.am:
	* ext/libpostproc/gstpostproc.c:
	* ext/libpostproc/gstpostproc.h:
	ffmpeg's libpostproc wrapper plugins

	* configure.ac: 
	added --enable-pp to ffmpeg configure arguments

Ronald S. Bultje's avatar
Ronald S. Bultje committed
33 34 35 36 37 38 39
2005-06-11  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* configure.ac:
	  Dev mode.

=== release 0.8.5 ===

40 41 42 43 44 45 46 47 48 49
2005-06-11  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* NEWS:
	* RELEASE:
	* TODO:
	* configure.ac:
	  Release 0.8.5 "For the better of the world".
	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_caps_with_codecid):
	  Stay backwards compatible a short while longer (SVQ3).

50 51 52 53 54 55
2005-06-09  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_frame):
	  Only do timestamp interpolation for delayed streams (containing
	  B-frames). Fixes stuttering playback of ASF files (#306770).

56 57 58 59 60 61 62
2005-06-09  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_with_codecid):
	  Remove weird flags from SVQ3 flags and just give full atom,
	  like other files; fixes frame order problems (#306530).

63 64 65 66 67 68
2005-06-08  Luca Ognibene  <luogni@tin.it>

	* ext/ffmpeg/gstffmpegdec.c (gst_ffmpegdec_change_state): 
	  First close the ffmpeg context than try to free last_buffer.
	  fix #306893

69 70 71 72 73 74
2005-06-03  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_open),
	(gst_ffmpegdec_handle_event), (gst_ffmpegdec_register):
	  Disable parsing on h264 for now, seems to break avc decoding.

75 76 77 78 79 80 81
2005-06-03  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* configure.ac:
	  scale requires -libs (video.h).
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_getcaps):
	  Don't crash if open failed.

82 83 84 85 86
2005-05-24  Luca Ognibene  <luogni@tin.it>

	* ext/ffmpeg/gstffmpegdeinterlace.c (gst_ffmpegdeinterlace_chain): 
	  Always stamp your buffers ! (ooops)

87 88 89 90 91
2005-05-24  Edward Hervey  <bilboed@bilboed.com>

	* ext/ffmpeg/gstffmpegscale.c: (gst_ffmpegscale_chain):
	Always stamp your buffers !

92 93 94 95 96
2005-05-17  Luca Ognibene  <luogni@tin.it>

	* ext/ffmpeg/gstffmpegcodecmap.c (gst_ffmpeg_pixfmt_to_caps): 
	  Add YUV444P format as Y444

97 98 99 100 101 102 103 104 105
2005-05-15  Luca Ognibene  <luogni@tin.it>

	* ext/ffmpeg/Makefile.am: 
	* ext/ffmpeg/gstffmpegdeinterlace.c: 
	* ext/ffmpeg/gstffmpeg.c (plugin_init): 
	  Add ffdeinterlace element
	* TODO: 
	  yo, another thing removed from the TODO

106 107 108 109 110
2005-05-14  Luca Ognibene  <luogni@tin.it>

	* ext/ffmpeg/gstffmpegscale.c (gst_ffmpegscale_change_state): 
	  Don't segfault if using passthrough

111 112
2005-05-13  Luca Ognibene  <luogni@tin.it>

113 114 115 116 117 118 119 120
	* ext/ffmpeg/gstffmpeg.c (plugin_init): 
	* ext/ffmpeg/Makefile.am: 
	* ext/ffmpeg/gstffmpegscale.c: 
	  Add ffvideoscale element (#303727)

	* TODO: 
	  update TODO	

121 122 123
	* ext/ffmpeg/gstffmpegcodecmap.c (gst_ffmpeg_pixfmt_to_caps): 
	  Add support for GRAY8 colorspace

124
2005-05-11  Luca Ognibene  <luogni@tin.it>
125 126 127 128 129 130 131 132 133 134

	* ext/ffmpeg/gstffmpegenc.c (gst_ffmpegenc_chain_video): 
	* ext/ffmpeg/gstffmpegdec.c (gst_ffmpegdec_chain): 
	  Makes ffmpegdec and ffmpegenc use these functions
	  and remove a comment from a previuos patch

	* ext/ffmpeg/gstffmpegcodecmap.h: 
	  Add two utility functions to convert the pts from/to
	  the ffmpeg format

135 136 137 138 139 140 141 142 143 144 145
2005-05-06  Luca Ognibene  <luogni@tin.it>

	Reviewed by:  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_init),
	(gst_ffmpegdec_open), (gst_ffmpegdec_connect),
	(gst_ffmpegdec_get_buffer), (gst_ffmpegdec_release_buffer),
	(gst_ffmpegdec_frame), (gst_ffmpegdec_change_state):
	  Re-re-enable get_/release_buffer functions, removes a few more
	  percent of our CPU usage (#301783).

146 147 148 149 150 151 152
2005-05-02  Luca Ognibene  <luogni@tin.it>

	Reviewed by:  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_pixfmt_to_caps):
	  Add JPEG-formatted YUV enums.

153 154 155 156 157 158 159
2005-05-01  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegmux.c: (gst_ffmpegmux_class_init),
	(gst_ffmpegmux_finalize), (gst_ffmpegmux_loop),
	(gst_ffmpegmux_change_state):
	  Fix possible segfaults (#302017).

160 161 162 163 164
2005-04-25  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_handle_event):
	  Use CODEC_CAP_DELAY and remove max-10-delayed-frames hack.

165 166 167 168 169 170 171
2005-04-23  Luca Ognibene  <luogni@tin.it>

	Reviewed by:  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_getcaps):
	  Don't crash if avcodec_open failed (#301717).

172 173 174 175 176
2005-04-21  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_register):
	  Re-disable mov typefinding which breaks mov playback.

177 178 179 180 181 182 183 184 185 186 187 188
2005-04-21  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_with_codecid), (gst_ffmpeg_caps_to_codecid),
	(gst_ffmpeg_get_codecid_longname):
	  Add ALAC, shorten and some more in new FFMPEG snapshot of
	  21/4, somewhere this afternoon.
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_register):
	  Add warnings to decoder registration to easier add new ones
	  during snapshot updates.

189 190 191 192 193 194
2005-04-21  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c:
	(gst_ffmpeg_formatid_get_codecids):
	  Enable MPEG muxer.

195 196 197 198 199 200 201
2005-04-18  Luca Ognibene  <luogni@tin.it>

	Reviewed by:  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_frame):
	  Next try at using pad_alloc_buffer (#300923).

202 203 204 205 206 207
2005-04-16  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_frame):
	  Revert previous, we cannot call pad_alloc_buffer() before being
	  negotiated.

208 209 210 211 212
2005-04-16  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_frame):
	  Use gst_pad_alloc_buffer().

213 214 215 216 217 218
2005-04-14  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_handle_event):
	  Safety bet to not completely crush the system on EOS. Fixes the
	  bad behaviour of #300200 (doesn't fix the actual issue).

219 220 221 222 223 224 225 226 227
2005-04-02  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_open),
	(gst_ffmpegdec_handle_event):
	  Fix breakage of testsuite by adding keyframe syncing; changed
	  to sync only for some streamtypes (MPEG-2/-4, for now).
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_add):
	  Add tags.

228 229 230 231 232 233 234
2005-04-01  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_init),
	(gst_ffmpegdec_open), (gst_ffmpegdec_frame),
	(gst_ffmpegdec_handle_event):
	  Implement keyframe syncing.

235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255
2005-03-14  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpeg.c: (plugin_init):
	  Enable muxers (only mp4 muxer for now).
	* ext/ffmpeg/gstffmpegcodecmap.c:
	(gst_ffmpeg_formatid_get_codecids), (gst_ffmpeg_caps_to_codecid):
	* ext/ffmpeg/gstffmpegcodecmap.h:
	  Fix a bunch of typos in codec-id lookup (false/true return value
	  mixup), add a codec-id list retrieval function (because ffmpeg
	  does not provide one). With that, we can make valid pad templates.
	* ext/ffmpeg/gstffmpegmux.c: (gst_ffmpegmux_init),
	(gst_ffmpegmux_connect), (gst_ffmpegmux_loop),
	(gst_ffmpegmux_change_state), (gst_ffmpegmux_get_id_caps),
	(gst_ffmpegmux_register):
	  Fix for whatever changed since I last tried this. Works for MP4
	  muxing.
	* ext/ffmpeg/gstffmpegprotocol.c: (gst_ffmpegdata_open),
	(gst_ffmpegdata_peek), (gst_ffmpegdata_write),
	(gst_ffmpegdata_seek), (gst_ffmpegdata_close):
	  Update obviously-untested write code...

256 257 258 259 260
2005-03-13  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_chain_video):
	  Fix crash on randomly sized input (#169082).

Ronald S. Bultje's avatar
Ronald S. Bultje committed
261 262 263 264 265 266 267
2005-03-11  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* configure.ac:
	  Dev.

=== release 0.8.4 ===

268 269 270 271 272 273 274
2005-03-11  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* NEWS:
	* RELEASE:
	* configure.ac:
	  Release 0.8.4 "Mellow on my fingers".

275 276 277 278 279
2005-03-06  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps):
	  Add MPEG-4 audio for debugging.

280 281 282 283 284
2005-02-05  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_link):
	  Only free context if it was created (otherwise it crashes).

285 286 287 288 289 290 291 292 293
2005-02-04  Jan Schmidt  <thaytan@mad.scientist.com>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_frame),
	(gst_ffmpegdec_chain), (gst_ffmpegdec_register):
	  Reduce the rank of the mpeg2 decoder back below mpeg2dec
	  Use the parser to reorder pts times. Fixes mpeg playback
	  without changing any other files I tested.
	  Use the repeat_pict flag to correctly set durations

294 295 296 297 298 299 300 301
2005-02-02  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_to_codecid):
	  Change caps of MJPEGB to not interfere with MJPEG/JPEG.
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
	  Remove rank for SP5X, no clue what that is...

302 303 304 305 306
2005-02-01  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_frame):
	  Don´t SIGFPE right away.

307 308 309 310 311 312 313 314 315 316
2005-01-31  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_lowres_get_type),
	(gst_ffmpegdec_skipframe_get_type), (gst_ffmpegdec_class_init),
	(gst_ffmpegdec_init), (gst_ffmpegdec_connect),
	(gst_ffmpegdec_frame), (gst_ffmpegdec_set_property),
	(gst_ffmpegdec_get_property):
	  Implement B-frame skipping and low-resolution decoding (useful
	  for very slow CPUs).

317 318 319 320 321 322
2005-01-28  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_register):
	  Oops, unbreak audio.

323 324 325 326 327 328 329 330 331 332 333 334 335
2005-01-28  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_to_codecid):
	  Add AMR mimetypes (since those are recognized in ffmpeg).
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_frame),
	(gst_ffmpegdec_register):
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_register):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_register):
	  Register law codecs too, add time debug. Use ANY for template caps
	  since we don't necessarily have available decoders for recognized
	  formats.

336 337 338 339 340
2005-01-27  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpeg.c: (plugin_init):
	  Fix compile with debug disabled (#165250).

341 342 343 344 345
2005-01-25  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegprotocol.c: (gst_ffmpegdata_peek):
	  Yet Another Logic Error.

346 347 348 349 350
2005-01-25  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_negotiate):
	  <insert rant about why gcc should support parsing errors>.

351 352 353 354 355 356 357 358 359
2005-01-25  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_pixfmt_to_caps), (gst_ffmpeg_caps_to_pixfmt):
	  Add extradata to huffyuv, sync RGBA32 up with gst-plugins.
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_query),
	(gst_ffmpegdec_event):
	  Make somewhat clearer.

360 361 362 363 364 365 366 367 368
2005-01-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* TODO:
	  Update since some tasks are done.
	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_formatid_to_caps):
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_type_find):
	  Add correct mimetype for FLI video, restore correct typefind
	  priority.

369 370 371 372 373 374 375
2005-01-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_connect),
	(gst_ffmpegdec_frame), (gst_ffmpegdec_handle_event),
	(gst_ffmpegdec_chain):
	  More debug, re-fix MPEG-2 (yes, I broke it already!).

376 377 378 379 380 381
2005-01-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_handle_event),
	(gst_ffmpegdec_chain):
	  Another fix for MPEG-4 movies...

382 383 384 385 386 387 388
2005-01-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_open),
	(gst_ffmpegdec_connect), (gst_ffmpegdec_negotiate),
	(gst_ffmpegdec_frame), (gst_ffmpegdec_handle_event):
	  Add some more debug, fix for B-frame containing XviD movies.

389 390 391 392 393
2005-01-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_handle_event):
	  Only flush when the codec is opened.

394 395 396 397 398 399 400 401 402
2005-01-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_to_codecid), (gst_ffmpeg_get_codecid_longname):
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
	  Re-add H263I as intel-h263 (which is not h263-compliant...).
	  Increase rank of mpeg2video since it plays more videos than
	  its gst-plugins counterpart, with no regressions.

403 404 405 406 407
2005-01-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_frame):
	  Don't unref NULL data...

408 409 410 411 412 413 414
2005-01-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_init),
	(gst_ffmpegdec_open), (gst_ffmpegdec_frame),
	(gst_ffmpegdec_handle_event), (gst_ffmpegdec_chain):
	  Add B-frame timestamp smoothing.

415 416 417 418 419 420 421 422 423
2005-01-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_frame),
	(gst_ffmpegdec_chain):
	  Separate buffer handling from actual decoding, handle pending
	  frames (for B-frames and so on) so we catch the last frames
	  before EOS, prepare for some timestamp changes to make playback
	  of movies with B-frames smoother (not done yet).

424 425
2005-01-18  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

426

427 428 429 430 431 432 433
	(gst_ffmpegdec_negotiate), (gst_ffmpegdec_chain):
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_init),
	(gst_ffmpegdemux_close), (gst_ffmpegdemux_src_query),
	(gst_ffmpegdemux_loop):
	  Add simple query functions. Seeking is only cosmetic, it's not
	  actually filled in yet (in ffmpegdec).

434 435 436 437 438 439 440
2005-01-17  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_init),
	(gst_ffmpegenc_link), (gst_ffmpegenc_chain_video):
	  Remove EMU_EDGE, since that really fixes #162905. Revert
	  previous hacks.

441 442 443 444 445
2005-01-16  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_chain_video):
	  Unref after encode (#162905).

446 447 448 449 450 451 452 453
2005-01-16  Luca Ognibene  <luogni@tin.it>

	Reviewed by:  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_link),
	(gst_ffmpegenc_chain_video):
	  Workaround memory issues (#162905).

454 455 456 457 458
2005-01-10  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_type_find):
	  Decrease certainty a bit so we use flxdec for .flx videos.

459 460 461 462 463
2005-01-09  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_dispose):
	  Call parent.

464 465 466 467 468 469 470 471
2005-01-09  Luca Ognibene  <luogni@tin.it>

	Reviewed by:  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  Disable parsing for MJPEG input since that's already cut at
	  frame-boundaries. Fixes #163340.

472 473 474 475 476 477 478 479
2005-01-06  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_to_codecid):
	  Set property incompatible with DV demuxer so that it won't
	  infinitely plug demuxers to each other. Fixes playback of .dv
	  streams in Totem.

Ronald S. Bultje's avatar
Ronald S. Bultje committed
480 481 482 483 484
2004-12-27  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* configure.ac:
	  Dev.

Ronald S. Bultje's avatar
Ronald S. Bultje committed
485 486 487 488 489 490 491 492 493
=== release 0.8.3 === 

2004-12-27  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* NEWS:
	* RELEASE:
	* configure.ac:
	  Release 0.8.3 "Tiny Piece of Plastic".

494 495 496 497 498 499 500
2004-12-25  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_register):
	  Don't cripple rank as a hack to not register typefind functions.
	  Instead, just use a boolean for that. This makes ID3-tagged MP3
	  files play even if mad is not installed.

501 502 503 504 505 506
2004-12-20  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
	  Remove rank from ffdec_h263i until I know how it's different
	  from ffdec_h263. Fixes #155163.

507 508 509 510 511 512
2004-12-18  David Schleef  <ds@schleef.org>

	* autogen.sh: execute ffmpeg's autogen.sh directly
	* gst-libs/ext/ffmpeg/autogen.sh: Add a #! line.  Specify bash,
	since there are bashisms ('local').

513 514 515 516 517 518 519 520
2004-12-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegprotocol.c: (gst_ffmpegdata_open),
	(gst_ffmpegdata_peek), (gst_ffmpegdata_read),
	(gst_ffmpegdata_write), (gst_ffmpegdata_seek),
	(gst_ffmpegdata_close):
	  Add debug. Don't EOS unless all data was read.

521 522 523 524 525 526 527 528 529
2004-12-19  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegprotocol.c: (gst_ffmpegdata_peek),
	(gst_ffmpegdata_read), (gst_ffmpegdata_seek):
	  Some "seeking" hacks, and separate peek from read (read = peek +
	  flush) so seek can use peek as well to workaround typefind. With
	  this, I'm able to play several of the gaming format movies in
	  Totem.

Ronald S. Bultje's avatar
Ronald S. Bultje committed
530 531 532 533 534 535
2004-12-18  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/Makefile.am:
	* ext/ffmpeg/gstffmpeg.h:
	  Add header.

536 537 538 539 540 541 542 543 544 545 546 547 548 549 550
2004-12-18  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpeg.c:
	* ext/ffmpeg/gstffmpegcodecmap.c:
	* ext/ffmpeg/gstffmpegcodecmap.h:
	* ext/ffmpeg/gstffmpegcolorspace.c:
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	* ext/ffmpeg/gstffmpegdemux.c:
	* ext/ffmpeg/gstffmpegenc.c:
	* ext/ffmpeg/gstffmpegmux.c:
	* ext/ffmpeg/gstffmpegprotocol.c:
	  Add debugging category everywhere (correctly this time). Don't
	  parse mp3 data (the parser is a piece of crap). Fixes #155274
	  mostly. Seeking pending.

551 552 553 554 555 556 557
2004-12-18  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_formatid_to_caps):
	  Add ID3 mime. Should partially fix #155274 (although raw mp3
	  sounds awful, it doesn't parse correctly in the decoder-only
	  case).

558 559 560 561 562 563
2004-12-17  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c:
	(gst_ffmpeg_get_codecid_longname):
	  Fix typo.

564 565 566 567 568
2004-12-17  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  Small parsing fix in comb. with ffdemux_mpeg.

569 570 571 572 573 574 575 576
2004-12-17  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_init),
	(gst_ffmpegdec_close), (gst_ffmpegdec_open), (gst_ffmpegdec_chain):
	  Include optional parser if supported (currently only MPEG-1/-2
	  video). This fixes playback of MPEG-1/-2 videos using
	  ffdec_mpeg2video.

577 578 579 580 581 582 583 584
2004-12-17  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_base_init),
	(gst_ffmpegenc_init), (gst_ffmpegenc_getcaps),
	(gst_ffmpegenc_link):
	  Move setup of sink caps (accepted formats) to a separate function
	  rather than doing it on initialization.

585 586 587 588 589 590 591 592 593 594 595 596 597 598 599
2004-12-16  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_to_codecid), (gst_ffmpeg_get_codecid_longname),
	(gst_ffmpeg_avpicture_fill):
	  Add new codecIDs from new snapshot (Thu Dec 16 11:27:18 2004).
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_src_event),
	(gst_ffmpegdemux_type_find), (gst_ffmpegdemux_loop):
	* ext/ffmpeg/gstffmpegmux.c: (gst_ffmpegmux_loop):
	  API updates.
	* ext/ffmpeg/gstffmpegprotocol.c: (gst_ffmpegdata_read),
	(gst_ffmpegdata_seek):
	  A slightly smarter approach, but it still needs lost of work to
	  be reliable in any way...

600 601 602 603 604 605 606 607 608
2004-12-16  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_init),
	(gst_ffmpegdec_close), (gst_ffmpegdec_connect),
	(gst_ffmpegdec_negotiate), (gst_ffmpegdec_chain):
	  Move negotiation outside the _chain function, and use the
	  codec PAR if available and prefer it over demuxer PAR (since
	  this is usually the right thing to do). Fixes #159755.

609 610 611 612 613 614 615
2004-12-16  Sebastien Cote  <sc5@hermes.usherb.ca>

	Reviewed by:  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_pad_link):
	  Fix memleak (#154815).

616 617 618 619 620 621 622
2004-12-16  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_pad_link),
	(gst_ffmpegcsp_init), (gst_ffmpegcsp_chain),
	(gst_ffmpegcsp_change_state):
	  Some sync with ffmpegcolorspace (flatten AVFrame).

623 624 625 626 627 628 629 630 631
2004-11-05  Wim Taymans  <wim@fluendo.com>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_avpicture_get_size),
	(gst_ffmpeg_avpicture_fill), (gst_ffmpeg_img_convert):
	* ext/ffmpeg/gstffmpegcodecmap.h:
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	Fix strides and plane sizes when dealing with odd sized
	movies.

632 633 634 635 636 637 638
2004-10-29  Sebastien Cote  <sc5@hermes.usherb.ca>

	Reviewed by:  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  Prevent division by zero (#155212).

639 640 641 642 643 644 645 646 647 648 649 650
2004-10-29  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_avpicture_fill):
	* ext/ffmpeg/gstffmpegcodecmap.h:
	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_chain):
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_get_buffer),
	(gst_ffmpegdec_chain):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_chain_video):
	  Sync with gst-plugins ffmpegcolorspace, align-by-4. Ready to
	  re-sync gst-plugins ffmpegcolorspace with ours and deprecate
	  this one.

651 652 653 654 655 656 657
2004-10-25  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_pad_link):
	  Backport changes from ffmpegcolorspace (gst-plugins) so we can
	  then move the whole of this plugin back and deprecate this (no,
	  I'm not insane).

658 659 660 661 662 663 664 665
2004-10-25  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_codectype_to_caps), (gst_ffmpeg_caps_with_codecid):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_base_init),
	(gst_ffmpegenc_connect), (gst_ffmpegenc_register):
	  Fix encoders. Fix if encoder supports >1 caps.

666 667 668 669 670 671 672 673 674 675 676
2004-10-25  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c:
	(gst_ffmpeg_get_codecid_longname):
	* ext/ffmpeg/gstffmpegcodecmap.h:
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_base_init),
	(gst_ffmpegdec_register):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_base_init),
	(gst_ffmpegenc_register):
	  Hmm, fancy names...

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
677 678 679 680
2004-10-20  Thomas Vander Stichele  <thomas at apestaart dot org>

	* configure.ac: up req of GStreamer since we use fractions

681 682 683 684 685
2004-10-11  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* gst-ffmpeg.spec.in:
	  Remove unused 'versioning' variable.

686 687 688 689 690 691 692 693
2004-10-11  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_init),
	(gst_ffmpegenc_chain_video):
	  Set chain function before adding pad, fix memleak on error, error
	  out on encode errors because none of subsequent frames will work
	  any better (this is not input dependent).

Ronald S. Bultje's avatar
Ronald S. Bultje committed
694 695 696 697 698
2004-10-09  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* configure.ac:
	  CVS.

699 700 701 702 703 704 705 706 707
=== release 0.8.2 ===

2004-10-09  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* NEWS:
	* RELEASE:
	* configure.ac:
	  Release 0.8.2.

708 709 710 711 712
2004-10-09  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  Unref when not usable.

713 714 715 716 717 718
2004-10-04  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_with_codecid):
	  Negotiation fixes for real video codecs.

719 720 721 722 723
2004-10-02  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_loop):
	  Fix timestamps. Quite some of the gaming formats work now. :).

724 725 726 727 728 729 730 731 732 733 734
2004-10-02  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_with_codecid), (gst_ffmpeg_caps_to_codecid):
	  Generalized palette functions, add actual mimetypes for wing
	  commander formats.
	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_chain):
	  Ffmpeg has internal palette functions, so I noticed.
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  Actually remove all palette code.

735 736 737 738 739 740 741 742
2004-10-02  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_loop):
	  Signal no_more_pads.
	* ext/ffmpeg/gstffmpegprotocol.c: (gst_ffmpegdata_read),
	(gst_ffmpegdata_seek):
	  Handle events.

743 744 745 746 747 748 749 750 751 752 753
2004-10-02  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_pixfmt_to_caps),
	(gst_ffmpeg_caps_to_pixfmt):
	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_pad_link),
	(gst_ffmpegcsp_init), (gst_ffmpegcsp_chain),
	(gst_ffmpegcsp_change_state), (gst_ffmpegcsp_register):
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  Move palette handling over from the decoder to the colorspace
	  conversion plugin (where you would expect it).

754 755 756 757 758 759
2004-10-01  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_with_codecid), (gst_ffmpeg_caps_to_codecid):
	  Simplify codec_data handling.

760 761 762 763 764 765 766
2004-09-23  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  Update timestamp for every new buffer that we output. Improves
	  audio playback for several files that have multiple audio chunks
	  per buffer.

767 768 769 770 771 772
2004-09-22  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
	  msmpeg4v3 should be priority as well, else it will choose divxdec
	  first (which we don't want).

773 774 775 776 777 778 779 780 781 782 783 784 785 786 787
2004-09-20  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_with_codecid):
	  WMV extradata (make #152798 work). J-frames are only available
	  in the bitstream if the J-frame bit has been set in the extradata.
	  If not (or if extradata is not provided), the movie won't play.
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_close),
	(gst_ffmpegdec_connect), (gst_ffmpegdec_chain):
	  Only close ffmpeg if privdata was allocated (else it segfaults).
	  Autodetect encoding bugs and workaround it. Don't copy data if
	  decoding failed.
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_loop):
	  Use read_frame() instead of read_packet() which is obsolete.

Iain Holmes's avatar
Iain Holmes committed
788 789 790 791 792
2004-09-16 Iain <iaingnome@gmail.com>

	* ext/ffmpeg/gstffmpegmux.c (gst_ffmpegmux_register): Free name fix 
	leak.

793 794 795 796 797 798 799
2004-07-21  Thomas Vander Stichele  <thomas at apestaart dot org>

	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_chain):
	  no point in doing any chaining if the pad we want to push from
	  isn't usable.


Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
800 801 802 803
2004-07-21  Thomas Vander Stichele  <thomas at apestaart dot org>

	* configure.ac: bump nano

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
804 805 806 807 808 809
=== gst-ffmpeg 0.8.1 ===

2004-07-16  Thomas Vander Stichele  <thomas at apestaart dot org>

	* configure.ac: release 0.8.1, "Just Another Victim"

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
810 811 812 813 814 815
2004-07-08  Thomas Vander Stichele  <thomas at apestaart dot org>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_base_init):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_base_init):
	  d'oh, put them back

816 817 818 819 820
2004-07-07  Thomas Vander Stichele  <thomas (at) apestaart (dot) org>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  drop incoming buffers that generate decoding errors

821 822 823 824 825 826 827 828
2004-07-07  Thomas Vander Stichele  <thomas (at) apestaart (dot) org>

	* ext/ffmpeg/gstffmpeg.c: (gst_ffmpeg_log_callback), (plugin_init):
	* ext/ffmpeg/gstffmpegcodecmap.h:
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  hook up our debug handler to FFmpeg's.
	  warn about getting negative have_data

829 830 831 832
2004-07-04  Thomas Vander Stichele  <thomas at apestaart dot org>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_base_init):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_base_init):
833
	  bring category order in line with others
834

835 836 837 838 839 840 841 842 843
2004-06-13  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_to_codecid):
	* ext/ffmpeg/gstffmpegprotocol.c: (gst_ffmpegdata_read):
	  Do some more random property setting. Fix for if there's less than
	  ffmpeg-default-buffersize (32kB) data in a file _and_ there's an
	  event pending. Partially fixes #142320.

844 845 846 847 848 849 850 851 852 853 854
2004-06-06  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpeg.c: (plugin_init):
	  Remove redundant calls which are called internally already.
	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_caps_with_codecid):
	  Indenting...
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_loop),
	(gst_ffmpegdemux_register):
	  Remove typefind functions and rank for demuxers for any demuxer
	  that we already have in GStreamer.

855 856 857 858 859
2004-05-18  Benjamin Otte  <in7y118@public.uni-hamburg.de>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_caps_with_codecid):
	  don't operate on undefined variables (fixes #135145)

860 861 862 863
2004-05-16  Benjamin Otte  <otte@gnome.org>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  Hi, I'm a memleak
864

865 866 867 868 869 870 871 872 873 874 875 876 877 878 879
2004-05-14  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_src_event),
	(gst_ffmpegdemux_src_query), (gst_ffmpegdemux_src_convert),
	(gst_ffmpegdemux_open), (gst_ffmpegdemux_loop):
	* ext/ffmpeg/gstffmpegprotocol.c: (gst_ffmpegdata_open),
	(gst_ffmpegdata_read), (gst_ffmpegdata_write),
	(gst_ffmpegdata_seek):
	  Fix up demuxer. Works now for all my files that I tried, even
	  quicktime. I basically hack around the super-oversimplistic file
	  I/O handling in ffmpeg in several ways together, and I also hack
	  around the fairly annoying EOS-will-pause-the-source-element in
	  GStreamer itself.
	  This code is not pretty.

880 881 882 883 884 885 886
2004-05-11  Jeremy Simon  <jesimon@libertysurf.fr>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_with_codecid):
	 block_align and bitrate caps property were lost for wma
	 use codec_data instead of flag1 and flag2

887 888 889 890 891
2004-05-11  Benjamin Otte  <in7y118@public.uni-hamburg.de>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_formatid_to_caps):
	  it's audio/x-wav, not video/x-wav

892 893 894 895 896 897 898 899
2004-05-10  Stephane Loeuillet <stephane.loeuillet@tiscali.fr>

	* ext/ffmpeg/gstffmpegdec.c
	* ext/ffmpeg/gstffmpegenc.c
		change plugins category to meet our new standard :
			Codec/Encoder|Decoder/Audio|Video
		suggested by bilboed, approved by Company

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
900 901 902 903 904 905 906
2004-05-04  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/autogen.sh:
	* gst-libs/ext/ffmpeg/patches/autotools.patch:
          require am17 since AM_CONDITIONAL's are being done using variables
          which doesn't work with am16

907 908 909 910 911
2004-04-30  Thomas Vander Stichele  <thomas at apestaart dot org>

	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_getcaps):
          revert previous patch

912 913 914 915 916
2004-04-29  Thomas Vander Stichele  <thomas at apestaart dot org>

	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_getcaps):
          use GST_PAD_CAPS if they exist so we don't renegotiate needlessly

917 918 919 920 921 922
2004-04-22  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_caps_with_codecid), (gst_ffmpeg_caps_to_codecid):
	  WAV/IMA-ADPCM -> DVI ADPCM.

923 924 925 926 927 928
2004-04-22  Benjamin Otte  <otte@gnome.org>

	* ext/ffmpeg/gstffmpegcolorspace.c:
	(gst_ffmpegcsp_caps_remove_format_info):
	  use gst_caps_do_simplify

929 930 931 932 933 934
2004-04-19  Benjamin Otte  <otte@gnome.org>

	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_type_find):
	  reduce maximum probability in typefinding to POSSIBLE. prevents
	  misidentification of my mp3s as video/mpeg

935 936 937 938 939
2004-04-15  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_chain):
	  NULL -> (NULL) inside GST_ELEMENT_ERROR().

940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964
2004-04-15  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_get_palette),
	(gst_ffmpeg_set_palette), (gst_ffmpeg_codecid_to_caps),
	(gst_ffmpeg_pixfmt_to_caps), (gst_ffmpeg_caps_to_smpfmt),
	(gst_ffmpeg_caps_to_pixfmt), (gst_ffmpeg_caps_with_codectype),
	(gst_ffmpeg_caps_with_codecid), (gst_ffmpeg_caps_to_codecid):
	* ext/ffmpeg/gstffmpegcodecmap.h:
	  Change some function names to reflect that they don't really
	  _return_ something, but rather _use_ something to fill a
	  AVCodecContext. s/to/with/. Restructure the extradata handling,
	  it's now not picking up the type from the caps but rather
	  using the type as provided in the function. This is a lot
	  cleaner. Implement MS RLE palette pickup.
	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_pad_link):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_connect):
	  Sync with the above function name changes.
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_close),
	(gst_ffmpegdec_open), (gst_ffmpegdec_connect),
	(gst_ffmpegdec_chain), (gst_ffmpegdec_change_state):
	  Add some hacks to convert palette-based raw image formats to
	  RGBA32. Ugly, but I don't know how else to handle palette-based
	  RGB, since img_convert() (and thus ffcolorspace) doesn't accept
	  a palette as argument.

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
965 966 967
2004-04-14  Thomas Vander Stichele  <thomas at apestaart dot org>

	* everything: updated upstream source to 2004-04-11 23:00 GMT
Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
968
	  and fixed up patches
Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
969

970 971 972 973 974
2004-04-11  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps):
	  Add MS Video v1 (video/x-msvideocodec, CODEC_ID_MSVIDEO1).

975 976 977 978 979
2004-04-08  David Schleef  <ds@schleef.org>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps):
	Change variadic macro to ISO form.  (bug #139460)

Benjamin Otte's avatar
Benjamin Otte committed
980 981 982 983 984 985
2004-04-06  Benjamin Otte  <otte@gnome.org>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_register):
	  fix memleaks

986 987 988 989 990
2004-04-05  Benjamin Otte  <otte@gnome.org>

	* configure.ac:
	  fix --export-symblos-regex to a working regex.

991 992 993 994 995 996 997
2004-04-03  Tim-Philipp Müller <t.i.m@zen.co.uk>

	reviewed by: David Schleef  <ds@schleef.org>

	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_register):  Fix
	memleaks (bug #138985)

Thomas Vander Stichele's avatar
indent  
Thomas Vander Stichele committed
998 999 1000 1001
2004-03-29  Thomas Vander Stichele  <thomas at apestaart dot org>

	* ext/ffmpeg/*.c: indent

Ronald S. Bultje's avatar
Ronald S. Bultje committed
1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013
2004-03-25  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_base_init):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_base_init):
	  Fix category.
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_class_init),
	(gst_ffmpegdemux_init), (gst_ffmpegdemux_close):
	  Slightly rewrite the init function, old one was ugly. Also remove
	  dispose function since it's obsolete, the change_state function
	  cleans up already. Also fixes segfault in test-app
	  gstreamer/tests/instantiate/create

1014 1015 1016 1017 1018 1019 1020 1021
2004-03-24  Benjamin Otte  <otte@gnome.org>

	* configure.ac:
	  only export gst* symbols
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	  change g_warning to debugging message, that wasn't a programming
	  error

1022 1023 1024
2004-03-18  Thomas Vander Stichele  <thomas at apestaart dot org>

	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_chain):
Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1025
	  don't critical, throw error (#137588)
1026

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1027 1028 1029 1030
2004-03-16  Thomas Vander Stichele  <thomas at apestaart dot org>

	* configure.ac: bump nano to 1

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1031 1032 1033 1034 1035 1036
=== gst-ffmpeg 0.8.0 ===

2004-03-16  Thomas Vander Stichele  <thomas at apestaart dot org>

	* configure.ac: release 0.8.0, "In Buildings"

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1037 1038 1039 1040 1041 1042 1043 1044 1045
2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/.pc/cvsignore/doc/.cvsignore:
	* gst-libs/ext/ffmpeg/.pc/cvsignore/libavcodec/i386/.cvsignore:
	* gst-libs/ext/ffmpeg/configure:
	* gst-libs/ext/ffmpeg/libavformat/matroska.c: (ebml_read_float):
	* gst-libs/ext/ffmpeg/patches/matroska.patch:
          patch from Ronald to work on ppc

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1046 1047 1048 1049 1050
2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* ext/ffmpeg/gstffmpegcolorspace.c: (gst_ffmpegcsp_get_type):
          fix name of static to be in line with code

1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065
2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* configure.ac:
          don't set ACLOCAL_FLAGS !
	* gst-libs/ext/ffmpeg/.cvsignore:
	* gst-libs/ext/ffmpeg/patches/cvsignore.patch:
          trying to add configure to be ignored

2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	reviewed by: <delete if not using a buddy>

	* gst-libs/ext/ffmpeg/.cvsignore:
	* gst-libs/ext/ffmpeg/patches/cvsignore.patch:

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1066 1067 1068 1069 1070 1071
2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/m4/vorbis.m4:
	* gst-libs/ext/ffmpeg/patches/autotools.patch:
          adding vorbis.m4

1072 1073 1074 1075 1076 1077 1078
2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/m4/ogg.m4:
	* gst-libs/ext/ffmpeg/patches/autotools.patch:
	* gst-libs/ext/ffmpeg/patches/no-imlib.patch:
          adding ogg.m4

1079 1080 1081 1082 1083 1084 1085 1086 1087
2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/patches/autotools.patch:
	* gst-libs/ext/ffmpeg/.pc/no-imlib/configure.ac:
	* gst-libs/ext/ffmpeg/autogen.sh:
          fix aclocal invocation to include m4 dir
	* gst-libs/ext/ffmpeg/configure.ac:
          add line to fix maintainer mode with aclocal 

1088 1089 1090 1091 1092 1093 1094 1095
2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/m4/imlib.m4:
	* gst-libs/ext/ffmpeg/m4/sdl.m4:
	* gst-libs/ext/ffmpeg/m4/freetype2.m4:
	* gst-libs/ext/ffmpeg/patches/autotools.patch:
          fix underquotedness, add freetype2.m4

1096 1097 1098 1099 1100
2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/patches/autotools.patch:
          put in sdl.m4 and imlib.m4

1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115
2004-03-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/.pc/autotools/.pc:
	* gst-libs/ext/ffmpeg/.pc/no-imlib/configure.ac:
	* gst-libs/ext/ffmpeg/.pc/noinst-programs/Makefile.am:
	* gst-libs/ext/ffmpeg/autogen.sh:
	* gst-libs/ext/ffmpeg/configure:
	* gst-libs/ext/ffmpeg/configure.ac:
	* gst-libs/ext/ffmpeg/doc/.cvsignore:
	* gst-libs/ext/ffmpeg/libavcodec/i386/.cvsignore:
	* gst-libs/ext/ffmpeg/patches/autotools.patch:
	* gst-libs/ext/ffmpeg/patches/no-imlib.patch:
          fixing Makefile.am omission in autotools patch
          fix noinst-programs.patch

1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130
2004-03-14  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps):
	* ext/ffmpeg/gstffmpegcodecmap.h:
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain),
	(gst_ffmpegdec_register):
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_add),
	(gst_ffmpegdemux_register):
	* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_connect),
	(gst_ffmpegenc_register):
	* ext/ffmpeg/gstffmpegmux.c: (gst_ffmpegmux_register):
	  Add encode property to codec mapper, so we can get better-fitting
	  caps. Also use this everywhere. ;). Lastly, add some new codecIDs
	  to our list of recognized ones.

1131 1132 1133 1134 1135 1136 1137 1138 1139
2004-03-12  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/.pc/applied-patches:
	* gst-libs/ext/ffmpeg/.pc/noinst-programs/.pc:
	* gst-libs/ext/ffmpeg/.pc/noinst-programs/Makefile.am:
	* gst-libs/ext/ffmpeg/Makefile.am:
	* gst-libs/ext/ffmpeg/patches/series:
	  add patch to not install programs

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1140 1141 1142 1143 1144 1145 1146 1147
2004-03-12  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/.pc/no-imlib/configure.ac:
	* gst-libs/ext/ffmpeg/.pc/autotools/.pc:
	* gst-libs/ext/ffmpeg/autogen.sh:
	* gst-libs/ext/ffmpeg/configure.ac:
          added m4 dir to autotools patch to fix imlib and sdl warnings

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1148 1149 1150 1151 1152 1153 1154
2004-03-12  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-libs/ext/ffmpeg/.pc/no-imlib/configure.ac:
	* gst-libs/ext/ffmpeg/configure.ac:
	* gst-libs/ext/ffmpeg/patches/series:
          add patch to remove imlib completely

1155 1156
2004-03-11  Thomas Vander Stichele  <thomas at apestaart dot org>

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1157
	* configure.ac: use new setup with mirrored cvs tree
1158

1159 1160 1161 1162 1163
2004-03-10  David Schleef  <ds@schleef.org>

	* gst-libs/ext/ffmpeg/patch/asm.diff:  Add a patch that
	decreases register usage.  (bug #136658)

1164 1165 1166 1167
2004-03-10  David Schleef  <ds@schleef.org>

	* configure.ac: bump gstreamer API number to 0.8

1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185
2004-03-09  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/Makefile.am:
	  Prevent more symbol conflicts...
	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
	  Up priority/rank for MPEG-4 decoder. Reason is simple: it's well-
	  tested and by far outperforms xviddec/divxdec. They'll get some
	  other, slightly lower, rank.
	* gst-libs/ext/ffmpeg/patch/autotools.diff:
	  Tweaking...
	* gst-libs/ext/ffmpeg/patch/disableinstalllibs.diff:
	  Prevent more symbol conflicts. I changed this (to pass 'make
	  distcheck') in the one patch, so need to change it here too.
	* gst-libs/ext/ffmpeg/patch/disablemmx.diff:
	  Re-enable MMX. :).
	* gst-libs/ext/ffmpeg/patch/functions.diff:
	  Bla.

1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204
2004-03-09  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* configure.ac:
	  Patch properly. Update version.
	* gst-libs/ext/ffmpeg/Makefile.am:
	  Comment out patching - all handled by configure.
	* gst-libs/ext/ffmpeg/Tag:
	  Update version.
	* gst-libs/ext/ffmpeg/patch/autotools.diff:
	  Some small updates to improve compiling.
	* gst-libs/ext/ffmpeg/patch/functions.diff:
	  Update date.
	* gst-libs/ext/ffmpeg/patch/matroska.diff:
	  Newer patch - see ffmpeg-devel mailinglists.
	* gst-libs/ext/ffmpeg/patch/function.patch:
	  Remove old cruft.
	* gst-libs/ext/ffmpeg/patch/disabletools.diff:
	  Now handled by --disable-... in configure.

1205 1206 1207 1208 1209
2004-03-07  David Schleef  <ds@schleef.org>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps):
	Add cinepak format.  (bug #136470)

1210 1211 1212 1213 1214
2004-03-05  David Schleef  <ds@schleef.org>

	* configure.ac:  Call ffmpeg's configure with --disable-v4l,
	--disable-oss-audio, --disable-dv1394 (bug #127873)

1215 1216 1217 1218 1219 1220 1221
2004-03-04  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_formatid_to_caps):
	  Fix quicktime type recognition in ffmpeg. We returned a bogus
	  caps, which caused ffdemux_quicktime to be chosen over qtdemux.
	  This fixes that.

1222 1223 1224 1225 1226 1227 1228
2004-03-04  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* configure.ac:
	  Brackets cause autoconf errors. So remove them.
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_add):
	  Actually use the event/convert/query functions. D'oh.

1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242
2004-03-02  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* configure.ac:
	* gst-libs/ext/ffmpeg/Makefile.am:
	  Slightly change the way we set this up. Ugly, but now it works
	  again. This baby is looking for a proper fix.
	* gst-libs/ext/ffmpeg/Tag:
	  Apparently CVS and me disagree on the tag... Ohwell, CVS wins.
	* gst-libs/ext/ffmpeg/patch/autotools.diff:
	* gst-libs/ext/ffmpeg/patch/disableinstalllibs.diff:
	  Slight nag on a link between lavf/lavc in ffmpeg. Not really
	  important for us since the code is the same in the end, but this
	  is actually correct from a per-patch point-of-view...

1243 1244 1245 1246 1247
2004-03-02  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* gst-libs/ext/ffmpeg/Makefile.am:
	  Fix patching.

1248 1249 1250 1251 1252 1253 1254 1255
2004-03-01  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_connect):
	  Fix B-frame DivX5/XviD display by removing the truncated flag when
	  not needed.
	* gst-libs/ext/ffmpeg/patch/autotools.diff:
	  Remove link to libavcodec - it causes symbol conflicts (why?).

1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316
2004-02-29  Ronald Bultje  <rbultje@ronald.bitfreak.net>

	* HACKING:
	  Add some basic documentation on how our wrapping works.
	* TODO:
	  Add a list of things that could be worked on or that need doing.
	* configure.ac:
	  Update snapshot.
	* ext/ffmpeg/Makefile.am:
	  Changne .la links. See below (autotools patch).
	* ext/ffmpeg/gstffmpeg.c: (plugin_init):
	  Enable demuxers. See below (gstffmpegdemux.c).
	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_formatid_to_caps):
	  Realmedia caused a crash - fix that.
	* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_averror),
	(gst_ffmpegdemux_base_init), (gst_ffmpegdemux_init),
	(gst_ffmpegdemux_close), (gst_ffmpegdemux_dispose),
	(gst_ffmpegdemux_stream_from_pad),
	(gst_ffmpegdemux_src_event_mask), (gst_ffmpegdemux_src_event),
	(gst_ffmpegdemux_src_format_list),
	(gst_ffmpegdemux_src_query_list), (gst_ffmpegdemux_src_query),
	(gst_ffmpegdemux_src_convert), (gst_ffmpegdemux_add),
	(gst_ffmpegdemux_open), (gst_ffmpegdemux_loop),
	(gst_ffmpegdemux_change_state), (gst_ffmpegdemux_register):
	  Right. OK, so I fixed up the demuxing and have it basically-working,
	  and the best way to get some more people to test it is to actually
	  enable it. I'm not sure if we want this for 0.8.0, but we can at
	  least give it a try. I've tested avi, matroska and mpeg, all appear
	  to work. The cool thing is that this gives us instant support for
	  several exotic formats that we'd never care about ourselves. Again,
	  this needs more testing for it to still be enabled in 0.8.0, but I
	  want to give it a try...
	* ext/ffmpeg/gstffmpegmux.c: (gst_ffmpegmux_base_init),
	(gst_ffmpegmux_init), (gst_ffmpegmux_request_new_pad),
	(gst_ffmpegmux_connect), (gst_ffmpegmux_loop),
	(gst_ffmpegmux_register):
	  Add some fixups that I use locally. Make it work in the case of
	  MPEG encoding, but the muxer is still not in shape to be enabled.
	* ext/ffmpeg/gstffmpegprotocol.c: (gst_ffmpegdata_open),
	(gst_ffmpegdata_read), (gst_ffmpegdata_write),
	(gst_ffmpegdata_seek), (gst_ffmpegdata_close):
	  Some small fixups that crept into it while it was disabled for the
	  last few years. Basically works.
	* gst-libs/ext/ffmpeg/Makefile.am:
	  Instead of having our local-autotoolized version, I patch the ffmpeg
	  source to be fully autotoolized. That means a simple SUBDIRS here
	  is now enough.
	* gst-libs/ext/ffmpeg/Tag:
	  Version update.
	* gst-libs/ext/ffmpeg/patch/autotools.diff:
	  Autotoolize ffmpeg. Needs to be sent to ffmpeg-devel@...
	* gst-libs/ext/ffmpeg/patch/disableinstalllibs.diff:
	  Don't install their libs.
	* gst-libs/ext/ffmpeg/patch/disablemmx.diff:
	  Don't use MMX. It cannot ocmpile using PIC.
	* gst-libs/ext/ffmpeg/patch/disabletools.diff:
	  Don't compile/install their tools, we don't use them.
	* gst-libs/ext/ffmpeg/patch/functions.diff:
	  Prevent symbol conflicts.
	* gst-libs/ext/ffmpeg/patch/matroska.diff:
	  Add a matroska demuxer. Needs to be sent to ffmpeg-devel@...
Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1317 1318 1319 1320 1321

2004-02-26  Thomas Vander Stichele  <thomas at apestaart dot org>

	* configure.ac: releasing 0.7.1 "True Colors"

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333
2004-02-14  Thomas Vander Stichele  <thomas at apestaart dot org>

	* gst-ffmpeg.spec.in: fix spec file

2004-02-14 Christian Schaller <Uraeus@gnome.org>

	* gst-ffmpeg.spec.in: add spec file

2004-02-13  Thomas Vander Stichele  <thomas at apestaart dot org>

	* creation

Christian Schaller's avatar
Christian Schaller committed
1334