Commit 90b5735f authored by Sebastian Dröge's avatar Sebastian Dröge 🍵
Browse files

ges-uri-asset: GstDiscoverer can return a valid info but a non-OK result, consider this an error

The asynchronous case in ges_uri_clip_asset_request_async() already considered
it an error, do the same in ges_uri_clip_asset_request_sync().
parent 2ef72b72
...@@ -520,12 +520,24 @@ ges_uri_clip_asset_request_sync (const gchar * uri, GError ** error) ...@@ -520,12 +520,24 @@ ges_uri_clip_asset_request_sync (const gchar * uri, GError ** error)
info = gst_discoverer_discover_uri (discoverer, uri, &lerror); info = gst_discoverer_discover_uri (discoverer, uri, &lerror);
} }
/* We might get a discoverer info but it might have a non-OK result. We
* should consider that an error */
if (!lerror && info
&& gst_discoverer_info_get_result (info) != GST_DISCOVERER_OK) {
lerror =
"Stream %s discovering failed (error code: %d)", uri,
gst_discoverer_info_get_result (info));
ges_asset_cache_put (gst_object_ref (asset), NULL); ges_asset_cache_put (gst_object_ref (asset), NULL);
ges_uri_clip_asset_set_info (asset, info); ges_uri_clip_asset_set_info (asset, info);
ges_asset_cache_set_loaded (GES_TYPE_URI_CLIP, uri, lerror); ges_asset_cache_set_loaded (GES_TYPE_URI_CLIP, uri, lerror);
if (info == NULL || lerror != NULL) { if (info == NULL || lerror != NULL) {
gst_object_unref (asset); gst_object_unref (asset);
if (info)
gst_discoverer_info_unref (info);
if (lerror) if (lerror)
g_propagate_error (error, lerror); g_propagate_error (error, lerror);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment