Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-devtools gst-devtools
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 35
    • Issues 35
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gst-devtoolsgst-devtools
  • Issues
  • #50
Closed
Open
Issue created Jan 05, 2020 by Brady Garvin@brady.j.garvin

`_preformat_levels` in `utils/loggable.py` assumes that the fields in its `TerminalController` are uniformly `bytes` or uniformly `string`s

In _preformat_levels, which builds the list _FORMATTED_LEVELS, the code may need to convert up to three TerminalController fields from bytes to strs on each iteration:

  • terminal_controller.BOLD,
  • getattr(terminal_controller, COLORS[level]), and
  • terminal_controller.NORMAL.

The current implementation, however, only checks one field's type, and then assumes that the other fields have the same type:

if isinstance(terminal_controller.BOLD, bytes):
    formatter = ''.join(
        (terminal_controller.BOLD.decode(),
         getattr(terminal_controller, COLORS[level]).decode(),
         log_level_name(level),
         terminal_controller.NORMAL.decode()))
else:
    formatter = ''.join(
        (terminal_controller.BOLD,
         getattr(terminal_controller, COLORS[level]),
         log_level_name(level),
         terminal_controller.NORMAL))

In some environvents (such as my own), this leads to a crash when terminal_controller.BOLD has type bytes, but getattr(terminal_controller, COLORS[level]) has type str, as Python 3 strings have no decode method to call.

Assignee
Assign to
Time tracking