cerbero merge requestshttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests2024-03-24T00:58:49Zhttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1423ci: Add recipes_{commits,remotes} entries for gst-plugins-rs2024-03-24T00:58:49ZNirbheek Chauhannirbheek.chauhan@gmail.comci: Add recipes_{commits,remotes} entries for gst-plugins-rsThis allows gst-plugins-rs to trigger cerbero CI, which will use the deps cache and build the specified gst-plugins-rs remote and commit.This allows gst-plugins-rs to trigger cerbero CI, which will use the deps cache and build the specified gst-plugins-rs remote and commit.1.25.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1413ci: remove macos/ios jobs for x86 mac mini hosts2024-03-21T00:18:15ZTim-Philipp Müllertim@centricular.comci: remove macos/ios jobs for x86 mac mini hostsThese can probably be removed now. The arm runners work well and the x86 mac minis would probably struggle to cope anyway.
cc @ystreetThese can probably be removed now. The arm runners work well and the x86 mac minis would probably struggle to cope anyway.
cc @ystreet1.25.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1406ci: fix gitlab warning when creating artifacts archive2024-03-24T02:18:51ZTim-Philipp Müllertim@centricular.comci: fix gitlab warning when creating artifacts archive"Part of .git directory is on the list of files to archive""Part of .git directory is on the list of files to archive"1.25.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1397Back to dev 1.24.0.1 + update CI for 1.24 branch2024-03-23T11:01:51ZTim-Philipp Müllertim@centricular.comBack to dev 1.24.0.1 + update CI for 1.24 branchGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1329ci: improve pre-commit error reporting2024-01-25T13:55:14ZAndoni Morales Alastrueyci: improve pre-commit error reportingIn the CI, enable `--show-diff-on-failure`, to show the generated diff by the hooks on errors.
In pre-commit, enable `--show-fixes` in ruff's linter to summarize the applied fixes by files.
```
✗ pre-commit run --all-files --show-diff-...In the CI, enable `--show-diff-on-failure`, to show the generated diff by the hooks on errors.
In pre-commit, enable `--show-fixes` in ruff's linter to summarize the applied fixes by files.
```
✗ pre-commit run --all-files --show-diff-on-failure
ruff.....................................................................Failed
- hook id: ruff
- files were modified by this hook
Fixed 1 error:
- cerbero/main.py:
1 × F401 (unused-import)
Found 1 error (1 fixed, 0 remaining).
ruff-format..............................................................Passed
pre-commit hook(s) made changes.
If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
To run `pre-commit` as part of git workflow, use `pre-commit install`.
All changes made by hooks:
diff --git a/cerbero/main.py b/cerbero/main.py
index d72151d4..e79c1b14 100644
--- a/cerbero/main.py
+++ b/cerbero/main.py
@@ -16,7 +16,6 @@
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
# Boston, MA 02111-1307, USA.
-from cerbero import hacks # noqa: F401
import argparse
import sys�
```1.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1322ci: cache pre-commit deps in runners2024-01-14T20:00:39ZAndoni Morales Alastrueyci: cache pre-commit deps in runnersRather than creating a single docker image reused by all users that need to be manually updated in case a pre-commit dependency changes, cache pre-commit dependencies in each runner.
Fix #460
This is an alternative approach to add...Rather than creating a single docker image reused by all users that need to be manually updated in case a pre-commit dependency changes, cache pre-commit dependencies in each runner.
Fix #460
This is an alternative approach to address #460:
1. In `main` the `checks` image installs pre-commit and the pre-commit hooks' dependencies.
2. In this branch the `checks` images install pre-commit and the pre-commit hooks's dependencies are installed and cached per-runner.1.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1321ci: cache pre-commit deps in runners2024-01-12T11:26:49ZAndoni Morales Alastrueyci: cache pre-commit deps in runnersRather than creating a single docker image reused by all users that needs to be manually updated in case a pre-commit dependency changes, cache pre-commit dependencies in each runner.
Fix #460Rather than creating a single docker image reused by all users that needs to be manually updated in case a pre-commit dependency changes, cache pre-commit dependencies in each runner.
Fix #460https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1315Add Ruff as a linter and formatter with pre-commit2024-01-14T20:00:36ZAndoni Morales AlastrueyAdd Ruff as a linter and formatter with pre-commitThis MR tries to solve the issue described in https://gitlab.freedesktop.org/gstreamer/cerbero/-/issues/115. Cerbero was originally pep8 conformant, but pre-CI days it was hard to enforce format consistency and over time it has become a ...This MR tries to solve the issue described in https://gitlab.freedesktop.org/gstreamer/cerbero/-/issues/115. Cerbero was originally pep8 conformant, but pre-CI days it was hard to enforce format consistency and over time it has become a bit of a mess.
The proposal is to use [Ruff](https://docs.astral.sh/ruff/) as a linter and formatter to check and fix the format.
Ruff has been chosen because it's the fastest implementation, it's a formatter and linter, and it can apply fixes for both.
This MR also introduces the use of [pre-commit](https://pre-commit.com/) to manage the pre-commit hooks and to use it in the CI.
Installation of hooks is straightforward. A user will run `pre-commit install` to install the hooks and the CI will run `pre-commit install-hooks` when creating the docker image to cache the hooks. Checks run automatically for users when creating a new commit and the CI will run `pre-commit run --all-files` in the `check sources` stage.
Hooks are configured in the `pre-commit-config.yaml` file. New hooks can be easily added by editing this file without further action. Re-generating the CI's docker image will automatically install and cache all the required hooks' dependencies.
This MR introduces many format changes, but it's a price worth paying from my point of view.1.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1289ci: update to macos sonoma (14)2023-11-14T06:55:00ZMatthew Watersmatthew@centricular.comci: update to macos sonoma (14)1.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1275ci: Rework rules for the deps msvc jobs2023-11-01T13:15:10ZJordan Petridіsci: Rework rules for the deps msvc jobsPreviously !1250 introduced new rules to avoid running the jobs in
scheduled pipelines, but that ended up overriding the rules inherited
by the '.cerbero deps' template job.
Copy the existing rules .cerbero not-mr rules and append the s...Previously !1250 introduced new rules to avoid running the jobs in
scheduled pipelines, but that ended up overriding the rules inherited
by the '.cerbero deps' template job.
Copy the existing rules .cerbero not-mr rules and append the schedule
condition onto them.
Followup to https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1250
Close #4521.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1260ci: use fd.o registry for macos images2023-08-31T10:03:10ZMatthew Watersmatthew@centricular.comci: use fd.o registry for macos images1.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1256Backport of "[1.22] ci: Use OpenSSH client shipped by Windows 10 on MSYS" int...2023-08-23T23:27:00ZTim-Philipp Müllertim@centricular.comBackport of "[1.22] ci: Use OpenSSH client shipped by Windows 10 on MSYS" into 1.20Backport of https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1254 "[1.22] ci: Use OpenSSH client shipped by Windows 10 on MSYS".
Commits:
- 2cc41045 ci: Use OpenSSH client shipped by Windows 10 on MSYSBackport of https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1254 "[1.22] ci: Use OpenSSH client shipped by Windows 10 on MSYS".
Commits:
- 2cc41045 ci: Use OpenSSH client shipped by Windows 10 on MSYSTim-Philipp Müllertim@centricular.comTim-Philipp Müllertim@centricular.comhttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1254[1.22] ci: Use OpenSSH client shipped by Windows 10 on MSYS2023-08-23T17:59:20ZNirbheek Chauhannirbheek.chauhan@gmail.com[1.22] ci: Use OpenSSH client shipped by Windows 10 on MSYSThe mechanism is convoluted, so don't use it when we have MSYS2 ssh.The mechanism is convoluted, so don't use it when we have MSYS2 ssh.1.22.6GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1253Draft: ci: Use OpenSSH client shipped by Windows 10 on MSYS2023-08-23T06:04:30ZNirbheek Chauhannirbheek.chauhan@gmail.comDraft: ci: Use OpenSSH client shipped by Windows 10 on MSYSThe mechanism is convoluted, so don't use it when we have MSYS2 ssh.The mechanism is convoluted, so don't use it when we have MSYS2 ssh.https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1252ci: disable macos x86 host jobs2023-08-22T01:36:08ZMatthew Watersmatthew@centricular.comci: disable macos x86 host jobsThe macos arm64 runners cover 99% of this functionality and the existing
x86 runners are quite old and slow.The macos arm64 runners cover 99% of this functionality and the existing
x86 runners are quite old and slow.1.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1250ci: trigger pipeline automatically if it was created by a schedule2023-10-31T03:25:03ZTim-Philipp Müllertim@centricular.comci: trigger pipeline automatically if it was created by a schedule.. but don't regen and upload caches for scheduled pipelines on main.
Also add an x86 msi job... but don't regen and upload caches for scheduled pipelines on main.
Also add an x86 msi job.1.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1241ci: disable ios jobs on the x86 host2023-08-02T15:26:05ZMatthew Watersmatthew@centricular.comci: disable ios jobs on the x86 host1.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1237ci: mark macos arm64 as manual for now2023-07-27T09:59:58ZMatthew Watersmatthew@centricular.comci: mark macos arm64 as manual for now1.23.1Matthew Watersmatthew@centricular.comMatthew Watersmatthew@centricular.comhttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1236ci: update macos/arm64 image2023-07-31T11:36:19ZMatthew Watersmatthew@centricular.comci: update macos/arm64 imageNow includes xz.Now includes xz.1.23.1GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orghttps://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1233Backport of "cerbero: Fix picking up cmake from build-tools" into 1.222023-07-26T18:00:22ZTim-Philipp Müllertim@centricular.comBackport of "cerbero: Fix picking up cmake from build-tools" into 1.22Backport of https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1232 "cerbero: Fix picking up cmake from build-tools".
Todo:
- [x] **Needs manual intervention, cherry-picking failed!**
Commits:
- 345fd0d0 cerbero: Fix p...Backport of https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1232 "cerbero: Fix picking up cmake from build-tools".
Todo:
- [x] **Needs manual intervention, cherry-picking failed!**
Commits:
- 345fd0d0 cerbero: Fix picking up cmake from build-tools1.22.6GStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.orgGStreamer Marge Botgitlab-merge-bot@gstreamer-foundation.org