This gets rid of one of the last man pages with a BSD-4-clause license.

While using fully uppercase man page titles has been the usual
convention for a very long time, it is rather ugly and something that
some other projects are switching away from.

Closes: #12

Fabrice Fontaine authored Jun 07, 2022 and Guillem Jover committed Jun 08, 2022

Fix the following build failure with big endian SH (e.g. sh4aeb):

  ,---
  In file included from nlist.c:44:
  nlist.c: In function '__elf_is_okay__':
  local-elf.h:223:25: error: 'ELFDATA2LMSB' undeclared (first use in this function); did you mean 'ELFDATA2LSB'?
    223 | #define ELF_TARG_DATA   ELFDATA2LMSB
        |                         ^~~~~~~~~~~~
  `---

Fixes: http://autobuild.buildroot.org/results/2980fb79c208454195d77383f1ece9afbd7f981b


Closes: !19
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Guillem Jover <guillem@hadrons.org>

The other function lists use the compact mode, let's be uniform about
this.

Fix also the Hurd implementation, missed in the original fix.

Extends: commit 72a82ee2
Warned-by: gcc

WÁNG Xuěruì authored Sep 11, 2021 and Guillem Jover committed Mar 30, 2022

Closes: !13


Signed-off-by: WANG Xuerui <git@xen0n.name>
Signed-off-by: Guillem Jover <guillem@hadrons.org>

The explicit_bzero(3) and reallocarray(3) functions are also present on
musl libc, mention it in the superseded section.

guijan authored Dec 31, 2021 and Guillem Jover committed Mar 30, 2022

The arc4random() support for OpenBSD does not build. The intention was
to include any portability code so that the library could be easily
ported to such systems, but it makes little sense to build it on OpenBSD
where most of the functionality will be already present, or the software
would have been ported anyway.

[guillem@hadrons.org: Reword commit message to add rationale. ]

Closes: !15
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Duncan Overbruck authored Jan 24, 2022 and Guillem Jover committed Jan 29, 2022

Closes: !18


Signed-off-by: Guillem Jover <guillem@hadrons.org>

- Remove trailing spaces.
- Declare file-scope functions and variables static.
- Declare functions with a proper prototype.
- Do not mix declarations and code for C90 conformance.
- Do not compare size_t and ssize_t variables.

Duncan Overbruck authored Jan 25, 2022 and Guillem Jover committed Jan 29, 2022

Signed-off-by: Guillem Jover <guillem@hadrons.org>

Duncan Overbruck authored Jan 25, 2022 and Guillem Jover committed Jan 26, 2022

Streams opened with for example open_memstream(3) will have no associated
file descriptor, and fileno(3) will fail.

Signed-off-by: Guillem Jover <guillem@hadrons.org>

Duncan Overbruck authored Jan 24, 2022 and Guillem Jover committed Jan 26, 2022

This does not work with libcs that do not declare the structure
in a header file, like musl. And gets in the way of supporting
non-fd based streams.

Signed-off-by: Guillem Jover <guillem@hadrons.org>

This reverts commit beafad26

.

This test was already handled later on as part of the BUILD_LIBBSD_CTOR
conditional. Adding it to the unconditional set made the build fail when
the system does not have GNU .init_array section support.

Closes: #9
Analysis-by: Duncan Overbruck <mail@duncano.de>

Closes: #8

We should not assume that something will implicitly check for this tool,
as we need it ourselves, and this is an internal implementation detail
of right now libtool.

Fixes: commit f11ab672

Sam James authored Jan 23, 2022 and Guillem Jover committed Jan 23, 2022

We already search for it in `./configure` so let's respect
the result of that search.

This helps with cross-compilation and any other cases
where one might want to choose a different toolchain.

Closes: !16
Bug: https://bugs.gentoo.org/831863


Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Reported-by: Thorsten Glaser <tg@mirbsd.de>

This man page has a BSD-3-clause-author license instead of the old
BSD-4-clause license.

Mention the involved function instead of stating an implicit "this
function". Mention libbsd when proposing using an alternative libmd
to make the context clear.

When using the recent dlsym() based wrapper, we are not requiring any
symbol from libmd, as we resolve those dynamically at run-time. We were
ending up linking against libmd because in another part of the code we
require (depending on the architecture) the SHA512 functions for the
getentropy() local implementation. But that function might be provided
by the system libc on some systems, which means we end up not linking
against libmd at all.

To solve this we go back to the previous simpler solution of linking
directly, which had the main drawback of then making programs fail to
link when not specifying -lmd (on platforms that need it). And then
switch the .so link point from a symlink to a linker script, so that we
can inject the -lmd library as-needed. This is similar to what glibc is
doing.

Fixes: commit 31f034e3

To be able to rework the md5 deprecation logic, we need to detangle when
we depend on libmd due to requiring MD5 functions, which might be
otherwise provided by libc, or when we require SHA functions for the
internal getentropy() implementation.

We will use it for the reworked md5 deprecation logic.

Warned-by: gcc

Warned-by: gcc

The nlist() function is limited to handle ELF binaries of the same class
as size as the size_t of the architecture built.

In addition the SIZE_T_MAX macro is BSD specific, and was falling back
to the wrong constant on most 64-bit non-BSD systems.

Warned-by: gcc

Be consistent with other usages in the code base.

viccie30 authored Nov 26, 2021 and Guillem Jover committed Nov 27, 2021

Because some of the symbols are not otherwise referenced, GCC would like
to remove them.

Closes: !14
Signed-off-by: Guillem Jover <guillem@hadrons.org>

viccie30 authored Nov 26, 2021 and Guillem Jover committed Nov 27, 2021

Because these symbols are not otherwise referenced, GCC would like
to remove them.

Signed-off-by: Guillem Jover <guillem@hadrons.org>

Its arguments are used as version numbers, so we need continue the
content on the next line.

Alexander Miller authored Sep 30, 2021 and Guillem Jover committed Nov 27, 2021

Global asm statements (like .symver directives) do not work reliably
in gcc with link time optimization. Use the symver attribute introduced
with gcc-10 to set symbol versions instead, if available.

[guillem@hadrons.org:
 - Simplify by using __has_attribute fallback from <sys/cdefs.h>.
 - Coding style changes. ]

Signed-off-by: Guillem Jover <guillem@hadrons.org>

Warned-by: gcc -W