Skip to content

collision between fail test due to different causes

A problem has been detected with the expectations update during the work to refactor the ci-uprev to walk in the direction to support more uprev pairs than mesa in virglrenderer.

The updated expectations broke many of the jobs in the pipeline of the amended commit.

To reproduce the problem, the command with the same uprev with the code in the main branch has been launched: python ci-uprev.py --revision 1250aad805ae99340d79293ea746328ed608f6c5.

The process had started with an uprev of mesa to revision 1250aad8 from virglrenderer's commit 228ae86d.

The uprev commit in the fork is 41ef810e and the pipeline to see how the uprev could work is 751512. Because I know the venus-lavapipe job produces a huge expectations update, I've canceled it, also because it wasn't the interest of this test.

As planned, it updated the expectations:

Failed test detected in piglit-gles-virt test_name='spec@egl_ext_device_base@conformance' with results Crash

Patched file .gitlab-ci/expectations/virt/virgl-gles-fails.txt

Patched file .gitlab-ci/expectations/virt/virgl-gles-fails.txt

Failed test detected in piglit-gl-virt test_name='spec@egl_ext_device_base@conformance' with results Crash

Patched file .gitlab-ci/expectations/virt/virgl-gl-fails.txt

Patched file .gitlab-ci/expectations/virt/virgl-gl-fails.txt and amend the commit.

The next step is to create a merge request, and it did. But when launching the merge request pipeline. The virt jobs failed (the venus-lavapipe was canceled due to the previous reason).

The cause of these virt jobs to fail: "deqp-gl-virt" and "piglit-gl-virt */3":

Error: Found duplicate result for spec@egl_ext_device_base@conformance,Crash at line 676 "deqp-gles-virt" and "piglit-gles-virt */3":

Error: Found duplicate result for spec@egl_ext_device_base@conformance,Crash at line 3225

Looking at the expectations file virgl-gl-fails.txt, the test "spec@egl_ext_device_base@conformance" is there twice:

  • In line 319 as "spec@egl_ext_device_base@conformance,Fail", and
  • In line 677 as "spec@egl_ext_device_base@conformance,Crash"

Looking at the expectations file virgl-gles-fails.txt, the test "spec@egl_ext_device_base@conformance" is there twice.

  • In line 446 as "spec@egl_ext_device_base@conformance,Fail", and
  • in line 3226 as "spec@egl_ext_device_base@conformance,Crash"

Note: The lining in error has a shift of one, perhaps because it starts counting at 0.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information