Commit cebba270 authored by Lucas Stach's avatar Lucas Stach Committed by Emil Velikov

etnaviv: stop oversizing buffer resources

PIPE_BUFFER is a target enum, not a binding. This caused the driver to
up-align the height of buffer resources, leading to largely oversizing
those resources. This is especially bad, as the buffer resources used
by the upload manager are already 1MB in size. Height alignment meant
that those would result in 4 to 8MB big BOs.

Fixes: c9e8b49b ("etnaviv: gallium driver for Vivante GPUs")
Signed-off-by: Lucas Stach's avatarLucas Stach <>
Reviewed-By: Wladimir J. van der Laan's avatarWladimir J. van der Laan <>
Reviewed-by: Christian Gmeiner's avatarChristian Gmeiner <>
(cherry picked from commit 8173d7d9)
parent cb8a159e
......@@ -179,7 +179,7 @@ etna_resource_alloc(struct pipe_screen *pscreen, unsigned layout,
&paddingY, &halign);
assert(paddingX && paddingY);
if (templat->bind != PIPE_BUFFER) {
if (templat->target != PIPE_BUFFER) {
unsigned min_paddingY = 4 * screen->specs.pixel_pipes;
if (paddingY < min_paddingY)
paddingY = min_paddingY;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment