Skip to content
  • Kenneth Graunke's avatar
    i965: Drop support for the legacy SNORM -> Float equation. · 74e1d6e2
    Kenneth Graunke authored
    Older OpenGL defines two equations for converting from signed-normalized
    to floating point data.  These are:
    
        f = (2c + 1)/(2^b - 1)                (equation 2.2)
        f = max{c/2^(b-1) - 1), -1.0}         (equation 2.3)
    
    Both OpenGL 4.2+ and OpenGL ES 3.0+ mandate that equation 2.3 is to be
    used in all scenarios, and remove equation 2.2.  DirectX uses equation
    2.3 as well.  Intel hardware only supports equation 2.3, so Gen7.5+
    systems that use the vertex fetcher hardware to do the conversions
    always get formula 2.3.
    
    This can make a big difference for 10-10-10-2 formats - the 2-bit value
    can represent 0 with equation 2.3, and cannot with equation 2.2.
    
    Ivybridge and older were using equation 2.2 for OpenGL, and 2.3 for ES.
    Now that Ivybridge supports OpenGL 4.2, this is wrong - we need to use
    the new rules, at least in core profile.  That would leave Gen4-6 doing
    something different than all other hardware, which seems...lame.
    
    With context version promotion, applications that requested a pre-4.2
    context may get promoted to 4.2, and thus get the new rules.  Zero cases
    have been reported of this being a problem.  However, we've received a
    report that following the old rules breaks expectations.  SuperTuxKart
    apparently renders the cars red when following equation 2.2, and works
    correctly when following equation 2.3:
    
    https://github.com/supertuxkart/stk-code/issues/2885#issuecomment-353858405
    
    So, this patch deletes the legacy equation 2.2 support entirely, making
    all hardware and APIs consistently use the new equation 2.3 rules.
    
    If we ever find an application that truly requires the old formula, then
    we'd likely want that application to work on modern hardware, too.  We'd
    likely restore this support as a driconf option.  Until then, drop it.
    
    This commit will regress Piglit's draw-vertices-2101010 test on
    pre-Haswell without the corresponding Piglit patch to accept either
    formula (commit 35daaa16
    
    ):
    
        draw-vertices-2101010: Accept either SNORM conversion formula.
    
    Reviewed-by: default avatarJason Ekstrand <jason@jlekstrand.net>
    Reviewed-by: default avatarIan Romanick <ian.d.romanick@intel.com>
    Reviewed-by: default avatarChris Forbes <chrisforbes@google.com>
    74e1d6e2