1. 18 Sep, 2015 3 commits
  2. 17 Sep, 2015 5 commits
  3. 16 Sep, 2015 3 commits
    • Zeeshan Ali's avatar
      nmea-source: Drop service on failure to read from it · ce11e28e
      Zeeshan Ali authored
      Since we longer read NMEA data from service if we fail to read from it
      and it's most likely indication that service has closed the socket
      without (first) advertising it going down, let's just drop the service
      from the list and refresh available accuracy level.
      ce11e28e
    • Zeeshan Ali's avatar
      nmea-source: Correct order of arguments · 54a4ec7b
      Zeeshan Ali authored
      'self' should always be the first argument.
      54a4ec7b
    • Bastien Nocera's avatar
      nmea-source: Don't access error if NULL · 064b19e5
      Bastien Nocera authored
      The g_data_input_stream_read_line_finish() documentation says:
      
      If there's no content to read, it will still return NULL, but error
      won't be set.
      
      So we can end up with a crash when turning off the NMEA server:
       #0  0x0000000000420273 in on_read_gga_sentence (object=0x6b0870 [GDataInputStream], result=0x661510, user_data=0x6769b0) at gclue-nmea-source.c:449
       #1  0x00007ffff6d110c3 in g_task_return_now (task=0x661510 [GTask]) at gtask.c:1088
       #2  0x00007ffff6d1175e in g_task_return (task=0x661510 [GTask], type=<optimized out>) at gtask.c:1146
       #3  0x00007ffff6cc98d7 in g_data_input_stream_read_complete (task=0x661510 [GTask], read_length=0, skip_length=0) at gdatainputstream.c:982
      
      Co-author: Ankit <ankitstarski@gmail.com>.
      
      https://bugs.freedesktop.org/show_bug.cgi?id=91940
      064b19e5
  4. 10 Sep, 2015 7 commits
  5. 09 Sep, 2015 2 commits
  6. 07 Sep, 2015 2 commits
    • Zeeshan Ali's avatar
      nmea-source: Ensure 1st service remains 1st in list · 5a9632a1
      Zeeshan Ali authored
      Currently if a second service is discovered that has the same accuracy
      as the first one in the list, g_list_insert_sorted() can (and in
      practice does) insert it in the beginning since our comparison function
      declares them both equal. Because of this, we end up switching to the
      new service even if its accuracy level is the same as the one we are
      already using.
      
      Let's solve this by also taking time of discovery into account in our
      comparison function.
      5a9632a1
    • Zeeshan Ali's avatar
      93d30c06
  7. 04 Sep, 2015 18 commits