1. 05 Jan, 2021 1 commit
  2. 04 Jan, 2021 2 commits
    • Benjamin Berg's avatar
      synaptics: Delay verify operation completion until finger remoal · 35d2d78e
      Benjamin Berg authored
      We used to return early in the case where the print matched in order to
      report the result more quickly. However, with the early reporting
      mechanism and the fprintd side implementation of it, this is not
      necessary anymore.
      As such, only stop the "verify" and "identify" operations when the
      finger is removed (or the operation is cancelled, which is actually what
      will happen currently).
    • Benjamin Berg's avatar
      synaptics: Improve identify handler and return a new print · 3d5db6a3
      Benjamin Berg authored
      It is easier (and more correct) to create a new print from the reported
      data and match that against the prints in the gallery.
      We continue to return NULL during verify as we cannot provide any
      additional information in that case.
  3. 17 Dec, 2020 1 commit
  4. 02 Dec, 2020 1 commit
  5. 30 Nov, 2020 1 commit
  6. 07 Nov, 2020 1 commit
  7. 19 Oct, 2020 3 commits
  8. 15 Oct, 2020 1 commit
  9. 14 Oct, 2020 1 commit
  10. 21 Aug, 2020 1 commit
  11. 31 Jul, 2020 1 commit
  12. 20 Apr, 2020 1 commit
  13. 15 Apr, 2020 1 commit
  14. 14 Apr, 2020 1 commit
  15. 10 Feb, 2020 1 commit
  16. 20 Jan, 2020 5 commits
    • Marco Trevisan's avatar
      synaptics: Immediately complete verification if finger removed · 3b471131
      Marco Trevisan authored
      When quickly scanning a finger with the synaptic driver, it may wait forever
      for finger removal even if this has already happened.
      In fact we don't take care of the finger status when reporting the
      To avoid this, add a function that delays the completion of the verification
      until the finger removal if the finger is on sensor, otherwise it just
      performs it.
      Fixes #228
    • Marco Trevisan's avatar
      synaptics: Report a verify complete error on unexpected result · 7a7bec5a
      Marco Trevisan authored
      Also remove the unneeded verify report with match failure
    • Marco Trevisan's avatar
      synaptics: Remove unneeded complete error/data parameters · 8be861b8
      Marco Trevisan authored
      Remove the never-used cmd_complete_data value and the repetition of
      In fact now as per the fpi_device_verify_report() usage, we already pass
      the match information to the device, such as the error and it will be
      they will be used on completion if needed.
      This allows to simplify cmd_ssm_done() as well.
    • Marco Trevisan's avatar
      synaptics: Always report verify state early on non-match · 8893840f
      Marco Trevisan authored
      In some cases we want to complete the verification after that the finger has
      been removed, but we still need to promptly report the match state otherwise
      fpi-device will complain about, and will eventually cause a match error
      instead that reporting a non-match:
        synaptics: Finger is now on the sensor
        synaptics: Received message with 0 sequence number 0x91, ignoring!
        synaptics: interrupt transfer done
        synaptics: delaying match failure until after finger removal!
        synaptics: interrupt transfer done
        device: Driver reported successful verify complete but did not report the
                result earlier. Reporting error instead
        libfprint: Failed to verify print: An unspecified error occured!
      Fixes #227
    • Marco Trevisan's avatar
      synaptics: Really check if a print is device database · 4d6a7ec0
      Marco Trevisan authored
      Fix a typo causing the not-in-database print error to be fired, actually
      checking the response result.
  17. 13 Jan, 2020 1 commit
    • Benjamin Berg's avatar
      Introduce an early reporting mechanism for verify and match · 4d5c34e1
      Benjamin Berg authored
      It is a good idea to report match results early, to e.g. log in a user
      immediately even if more device interaction is needed. Add new _full
      variants for the verify/identify functions, with a corresponding
      callback. Also move driver result reporting into new
      fpi_device_{identify,verify}_report functions and remove the reporting
      from the fpi_device_{identify,verify}_complete calls.
      Basic updates to code is done in places. Only the upekts driver is
      actually modified from a behaviour point of view. The image driver code
      should be restructured quite a bit to split the reporting and only
      report completion after device deactivation. This should simplifiy the
      code quite a bit again.
  18. 18 Dec, 2019 1 commit
    • Benjamin Berg's avatar
      Prefix internal properties/signals with fpi- and annotate them · 5b17eda0
      Benjamin Berg authored
      We prefixed them with fp- which is not as obvious as fpi-. Also,
      explicitly mark them as private and to be skipped in the GObject
      Introspection annotatinos.
      Warning: FPrint: (Signal)fp-image-device-state-changed: argument object: Unresolved type: 'FpiImageDeviceState'
  19. 17 Dec, 2019 1 commit
  20. 16 Dec, 2019 1 commit
  21. 10 Dec, 2019 1 commit
    • Vincent Huang's avatar
      synaptics: Fix problem after match is failed · 107fdfde
      Vincent Huang authored
      This fixes the the problem that the sensor becomes unresponsive after
      pressing the wrong fingerprint. We fix the problem by making sure that
      the non-match report is delayed until the finger is removed. With this
      we cannot run into the situation that the next match request fails
      immediately as the finger is still present.
      Fixes: #208
  22. 04 Dec, 2019 1 commit
  23. 03 Dec, 2019 2 commits
  24. 27 Nov, 2019 4 commits
  25. 26 Nov, 2019 1 commit
  26. 25 Nov, 2019 2 commits
  27. 20 Nov, 2019 2 commits