Agree we can close it, --project
is not available anymore
This should go into https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/.mr-label-maker.yml
Closing
Just quick mashup how it could look to catch all the .*.{trace,gfxr,rdc}
files mentioned in the issues or MR.
Benjamin Tissoires (4697b34d) at 22 Mar 14:29
Fix GitlabError typo
Benjamin Tissoires (23bbbed7) at 22 Mar 14:25
Use ruff format and ruff for linting
Hook this up via pre-commit because that's the most convenient way to get this all sorted. Same in the CI where we force a pre-commit run.
On top of !33
Rebased on top of main, and merging
Benjamin Tissoires (6124c82e) at 22 Mar 14:05
project: also fetch the name from the config file
... and 1 more commit
Supports TOML files in the form of:
["https://gitlab.example.com"]
token = "blah blah"
If --token
is missing and GITLAB_TOKEN
is unset, look up the token value
in that file. This way a user can set this up once and doesn't have to
manually supply the token value for each project.
LGTM, couple of nitpick that I'll fix myself to not waste another review round
obsolete
Supports TOML files in the form of:
["https://gitlab.example.com"]
token = "blah blah"
If --token
is missing and GITLAB_TOKEN
is unset, look up the token value
in that file. This way a user can set this up once and doesn't have to
manually supply the token value for each project.
This change seems OK but should probably be on its own commit as it's now unrelated to the intend of this commit
In dry-run mode, we shouldn't have to require to have a gitlab token on public projects.
However, a couple of endpoints we are using require it:
For the first one, we can rely on the graphQL API to publicly fetch the data (not sure why one is public when the other is not).
For the second one, we can just paper over it because we are in dry-mode, so no changes will be done anyway.
Benjamin Tissoires (a4109af1) at 22 Mar 13:13
Allow --dry-run to run without token
... and 2 more commits
Alright, let's merge it so we can fix the mesa deployment
good catch. I relied on pytest
but apparently this fell through he cracks
I don't know this code much (and don't have the brain to try to learn it now) so I can't review much, but other than one comment above, everything else looks reasonable :)
I think requests
's headers
is supposed to be a dict, right?
headers = {}
if self.token:
headers['Authorization'] = f'Bearer {self.token}'