Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
F
fontconfig
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 130
    • Issues 130
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • fontconfig
  • fontconfig
  • Merge Requests
  • !72

Closed
Opened Oct 28, 2019 by Matthieu Herrb@mherrb1
  • Report abuse
Report abuse

Avoid chmod() calls on directories

There are several reasons for that:

  • the reason that triggered this patch is that the pledge() sandboxing system on OpenBSD forbids chmod() by default in many pledged applications. When one of these needs to rebuild the font cache it will fail because of these unneeded chmod() calls.
  • trying to change existing directories access rights isn't a good idea
  • and lastly doing mkdir() && chmod() is racy. Use umask() to make shure the directory is created with the proper access rights from start.

Signed-off-by: Matthieu Herrb matthieu@herrb.eu

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://gitlab.freedesktop.org/mherrb/fontconfig.git" "no-chmod"
git checkout -b "mherrb/fontconfig-no-chmod" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "mherrb/fontconfig-no-chmod"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 1
  • Commits 3
  • Pipelines 4
  • Changes 2
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: fontconfig/fontconfig!72