Skip to content
  • Alan Coopersmith's avatar
    Leave room for null terminators in arrays · cb72901d
    Alan Coopersmith authored and Akira TAGOH's avatar Akira TAGOH committed
    
    
    Code currently returns a fatal error if it tries to add more entries
    than the array has room for, but it wasn't checking to make sure
    the final null terminator entry would fit.
    
    Reported by parfait 1.3:
    Error: Buffer overrun
       Buffer overflow (CWE 120): In array dereference of files[i] with index i
          Array size is 256 elements (of 4 bytes each), index >= 0 and index <= 256
            at line 250 of fc-glyphname/fc-glyphname.c in function 'main'.
    Error: Buffer overrun
       Buffer overflow (CWE 120): In array dereference of entries[i] with index i
          Array size is 1024 elements (of 8 bytes each), index >= 0 and index <= 1024
            at line 298 of fc-lang/fc-lang.c in function 'main'.
    
    Signed-off-by: default avatarAlan Coopersmith <alan.coopersmith@oracle.com>
    cb72901d