Skip to content

Free local FcCache lock on contention

Ben Wagner requested to merge bungeman/fontconfig:fccache_free_contended_lock_creation into main

If two threads attempt to create the FcCache lock in lock_cache at the same time, both threads may create and initialize a local FcMutex. One thread will atomically make cache_lock point to its FcMutex. The other thread currently calls FcMutexFinish on the local lock, but does not free it. Change this behavior to free the unused lock.

Found with test/test-pthread on an LeakSanitizer enabled build.

Merge request reports