1. 20 Jun, 2022 3 commits
  2. 12 Apr, 2022 2 commits
  3. 11 Apr, 2022 2 commits
    • Taylor R Campbell's avatar
      Avoid misuse of ctype(3) · 7dfde9b7
      Taylor R Campbell authored and Akira TAGOH's avatar Akira TAGOH committed
      The ctype(3) functions take arguments of type int that are either
      
      (a) EOF, or
      (b) unsigned char values, {0, 1, 2, ..., 255} if char is 8-bit.
      
      Passing values of type char, on platforms where it is signed, can go
      wrong -- negative values may be confused with EOF (typically -1) or
      may lead to undefined behaviour ranging in practice from returning
      garbage data (possibly out of an adjacent buffer in memory that may
      contain secrets) to crashing with SIGSEGV (if the page preceding the
      ctype table is unmapped).
      
      The ctype(3) functions can't themselves convert to unsigned char
      because then they would give the wrong answers for EOF, for use with
      functions like getchar and fgetc; the user has to cast char to
      unsigned char.
      7dfde9b7
    • Akira TAGOH's avatar
      Use the latest stable release image for CI for mingw · cf38c54a
      Akira TAGOH authored
      CI sometimes fails. we want to avoid environment specific issues on our
      CI.
      cf38c54a
  4. 31 Mar, 2022 1 commit
  5. 19 Feb, 2022 1 commit
  6. 04 Feb, 2022 3 commits
  7. 01 Feb, 2022 1 commit
  8. 31 Jan, 2022 2 commits
  9. 28 Jan, 2022 1 commit
  10. 17 Jan, 2022 1 commit
  11. 13 Jan, 2022 5 commits
  12. 09 Jan, 2022 1 commit
    • Nirbheek Chauhan's avatar
      meson: Remove summary() from version_compare() block · 7b09c81d
      Nirbheek Chauhan authored
      The version_compare() block is redundant because we require meson 0.56
      now, and it fixes a spurious warning:
      
      ```
      fontconfig| WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.54.0': list_sep arg in summary.
      ```
      7b09c81d
  13. 21 Dec, 2021 2 commits
  14. 09 Dec, 2021 3 commits
  15. 06 Dec, 2021 1 commit
    • Ben Wagner's avatar
      Actually skip leading spaces in style name · ce00010b
      Ben Wagner authored
      Because the loop body is just 'break' the loop never loops and at most
      one leading space is skipped. Remove the body to allow the loop to
      continue. Found with ClangTidy.
      ce00010b
  16. 16 Nov, 2021 1 commit
  17. 11 Nov, 2021 1 commit
  18. 09 Nov, 2021 2 commits
  19. 08 Nov, 2021 1 commit
  20. 28 Oct, 2021 1 commit
  21. 14 Oct, 2021 1 commit
  22. 11 Oct, 2021 1 commit
    • Akira TAGOH's avatar
      Resolves symlinks against <dir prefix="relative"> · 1d766999
      Akira TAGOH authored
      When a config file is symlinked and obtaining an relative path from it for <dir>,
      it behaved like:
      
      $ realpath /path/to/foo.conf
      /path/to/realpath/foo.conf
      $ FONTCONFIG_FILE=/path/to/foo.conf fc-cache -v
      Font directories:
              /path/to/fonts
      /path/to/fonts: skipping, existing cache is valid: 1 fonts, 0 dirs
      /path/to/cachedir: cleaning cache directory
      fc-cache: succeeded
      
      And after this change:
      
      $ FONTCONFIG_FILE=/path/to/foo.conf fc-cache -v
      Font directories:
              /path/to/relpath/fonts
      /path/to/realpath/fonts: skipping, existing cache is valid: 1 fonts, 0 dirs
      /path/to/cachedir: cleaning cache directory
      fc-cache: succeeded
      
      Fixes #290
      1d766999
  23. 08 Oct, 2021 1 commit
  24. 05 Oct, 2021 1 commit
  25. 06 Sep, 2021 1 commit
    • Ben Wagner's avatar
      Extend test thread args lifetime · 6e414d61
      Ben Wagner authored and Akira TAGOH's avatar Akira TAGOH committed
      The argument passed to each thread in test-pthread.c indicates a thread
      number to report when finished. This value is read out by the thread
      into a local variable early in the thread's execution. Currently, the
      address passed as this argument is the address of a loop local. However,
      it is possible that the created thread will not be scheduled to run or
      will not read the argument before the thread creation loop finishes and
      the local is destroyed. This can lead to odd behavior, usually observed
      as multiple threads reporting the same thread_num.
      
      Fix this issue by storing the thread arguments in a parallel array to
      the array of threads. This ensures that the thread arguments are in
      scope as long as the threads themselves.
      
      Discovered with tests/test-pthread with AddressSanitizer enabled.
      6e414d61