Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • F farstream
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • farstream
  • farstream
  • Merge requests
  • !4

build: Adapt to backwards incompatible change in GNU Make 4.3

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Debarshi Ray requested to merge debarshir/farstream:wip/rishi/make-4.3 into master Mar 12, 2020
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

GNU Make 4.3 has a backwards incompatible change affecting the use of number signs or hashes (ie., #) inside function invocations. See: https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00004.html

In this case, it would expand the '#' in the '\n#include "$(h)"' argument to the foreach call to '#', not '#'. This would lead to spurious backslashes in front of the '#include' directives in the generated fs-enumtypes.c file.

Spotted by Ernestas Kulik.

Edited Mar 12, 2020 by Debarshi Ray
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/rishi/make-4.3