You should not close... It has been fixed downstream in Arch package, but upstream does not have a commit in still crashes! Please re-open!
The patch from #10613 (closed) is in Arch's mesa 1:24.0.2-1.
The patch is in Arch's mesa 1:24.0.2-1.
Hmm, still nothing new here?
@pepp, mind to open a merge request with your change? Perhaps that catches attraction from developers...
(Just noticed... You are developer. Any reason not to commit this?)
It will be backported, as soon as it is committed to git.
Fix confirmed, and it also resolves #10648 (closed).
Christian Hesse (36193ec9) at 26 Oct 21:16
Merge branch 'kCTFontTraitColorGlyphs' into 'master'
... and 7 more commits
Christian Hesse (459d19ef) at 28 Sep 10:32
Merge branch 'remove-malloc-stats' into 'master'
... and 1 more commit
Christian Hesse (5151edd3) at 23 Sep 19:37
Release Cairo 1.18.0
Christian Hesse (b2f3957b) at 23 Sep 19:37
Merge branch 'master-next' into 'master'
... and 31 more commits
Now that a lot of memory leak fixes landed... Any chance to see a release any time soon?
With this applied I do no longer see any cairo related memory leaking in WebKitWebProcess
.
Hmm, no idea... Possibly I never touch that code path.
Builds and application runs without crash for now.
Merged in !514 (merged).
Christian Hesse (e3649469) at 20 Sep 14:28
Font options are allocated in _cairo_gstate_ensure_scaled_font() for local processing, but never freed. Run _cairo_font_options_fini() on these and fix the leak.
Signed-off-by: Christian Hesse mail@eworm.de
Christian Hesse (e3649469) at 18 Sep 21:31
Fix font options leak in _cairo_gstate_ensure_scaled_font()
Does this make sense?
diff --git a/src/cairo-gstate.c b/src/cairo-gstate.c
index e9019e8e6..323f80488 100644
--- a/src/cairo-gstate.c
+++ b/src/cairo-gstate.c
@@ -1920,6 +1920,8 @@ _cairo_gstate_ensure_scaled_font (cairo_gstate_t *gstate)
&font_ctm,
&options);
+ _cairo_font_options_fini (&options);
+
status = cairo_scaled_font_status (scaled_font);
if (unlikely (status))
return status;