1. 18 May, 2020 1 commit
  2. 13 May, 2020 1 commit
    • Carlos Garnacho's avatar
      xwayland: Improve checks for confined_to on InputOnly windows · 0777cf46
      Carlos Garnacho authored and Olivier Fourdan's avatar Olivier Fourdan committed
      In this pretty Wine/Proton specific kludge, we try to handle confining grabs
      on InputOnly windows by trying to find the InputOutput window that the pointer
      would get visually confined to.
      The grabbing window and the visible window come from different clients, so
      we used to simply resort to the pointer focus. This is troublesome though, as
      the call may happen very soon at a time that the toplevel wasn't yet mapped by
      the Wayland compositor, so the pointer focus may well be out of date soon.
      In these situations, it does seem that even though the confining grab happens
      too early to have the wayland surface mapped, the xserver view of the WindowPtr
      does already reflect the size. Use this to find out the better window to
      assign the confining grab to, one whose geometry fully contains the InputOnly
      Signed-off-by: Carlos Garnacho's avatarCarlos Garnacho <carlosg@gnome.org>
      Reviewed-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
  3. 12 May, 2020 4 commits
  4. 11 May, 2020 1 commit
  5. 08 May, 2020 1 commit
  6. 07 May, 2020 1 commit
  7. 01 May, 2020 2 commits
  8. 30 Apr, 2020 1 commit
    • Tobias Stoeckmann's avatar
      hw/xfree86: Support ACPI without APM. · 9890e912
      Tobias Stoeckmann authored and Adam Jackson's avatar Adam Jackson committed
      On systems with ACPI but disabled APM (e.g. --disable-linux-apm)
      the code does not compile due to preprocessor directives.
      If APM is disabled, the final return statement is considered to
      be part of ACPI's last if-statement, leading to a function which
      has no final return statement at all.
      I have refactored the code so ACPI and APM are independent of each
      Signed-off-by: Tobias Stoeckmann's avatarTobias Stoeckmann <tobias@stoeckmann.org>
  9. 27 Apr, 2020 1 commit
    • Olivier Fourdan's avatar
      xwayland: Fix infinite loop at startup · 785e5906
      Olivier Fourdan authored
      Mutter recently added headless tests, and when running those tests the
      Wayland compositor runs for a very short time.
      Xwayland is spawned by the Wayland compositor and upon startup will
      query the various Wayland protocol supported by the compositor.
      To do so, it will do a roundtrip to the Wayland server waiting for
      events it expects.
      If the Wayland compositor terminates before Xwayland has got the replies
      it expects, it will loop indefinitely calling `wl_display_roundtrip()`
      To avoid that issue, add a new `xwl_screen_roundtrip()` that checks for
      the returned value from `wl_display_roundtrip()` and fails if it is
      Signed-off-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      Reviewed-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      Reviewed-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
  10. 15 Apr, 2020 9 commits
    • Jon Turney's avatar
      hw/xwin: Drop call to setlocale() · 2fe13a1f
      Jon Turney authored
      Since we now only work with UTF-8 (or ISO8859-1) text in the clipboard,
      we don't need to setlocale().
    • Jon Turney's avatar
      hw/xwin: Consistently use BOOL type from Xmd.h · f269e01e
      Jon Turney authored
      This avoids including Xdefs.h, which means we avoid all the issues with
      _XSERVER64 effecting how types are defined by that.
    • Jon Turney's avatar
      hw/xwin: Remove XSetAuthorization() for helper clients · 4055fed1
      Jon Turney authored
      All helper client code now uses xcb, so calling XSetAuthorization() is
      no longer needed.
      This is the last reference to libX11 from helper clients, so linking
      with x11-xcb and libX11 is no longer required.
      Also drop (unneeded?) linking with libXau.
      Also drop installing these prerequistes on AppvVeyor.
      Also move prototypes for functions in winauth.c from win.h into a new
      header, winauth.h, and include that where needed.
    • Jon Turney's avatar
      hw/xwin: xcbify clipboard integration · 9e02e023
      Jon Turney authored
      Convert clipboard integration code from libX11 to xcb
      This drops support for COMPOUND_TEXT.  Presumably some ancient
      (pre-2000) clients exist which support that, but not UTF8_STRING, but we
      don't have an example to test with. (Given the nature of the thing, the
      users of those clients probably work in CJK languages)
      Supporting COMPOUND_TEXT would also involve writing (or extracting from
      Xlib) support for the ISO 2022 encoding.
      Fix the length of text property set by a SelectionRequest
      The length of the text property is not neccessarily the same as the
      length of the clipboard text before it is d2u converted (specifically,
      if that contains any '\r\n' sequences, it will be shorter as they are
      now just '\n')
    • Jon Turney's avatar
      hw/xwin: Remove nounicodeclipboard option · f4936de7
      Jon Turney authored
      Always use CF_UNICODETEXT clipboard format.  Windows will automatically
      down-convert to CF_TEXT for clients which request that.
      This is subtly different in one way: if CF_TEXT is requested, we now
      post CF_UNICODETEXT and it is converted to CF_TEXT *in the locale of the
      requesting process*.  Previously, we would convert to CF_TEXT *in our
      locale* and post that.
      It looks like the code in the !X_HAVE_UTF8_STRING case didn't actually
      work correctly, but fortunately that has never been true...
    • Jon Turney's avatar
      hw/xwin: Remove support for pre-Vista Win32 clipboard API · 9f51dfde
      Jon Turney authored
      The original Win32 clipboard API is widely regarded as terrible, since
      it relies on clients co-operatively managing the clipboard viewer chain,
      and a single buggy client can break it for all other clients.
      The last Windows version only supporting that API was Windows XP (5.1),
      EOLed in 2014.
      (This requires MinGW-w64 w32api 6.0.0 or later for
      Add/RemoveClipboardListener correctly exported by the x86_64 user32
    • Jon Turney's avatar
    • Jon Turney's avatar
      hw/xwin: Warn about too large Windows -> X clipboard pastes · d7010cd9
      Jon Turney authored
      XChangeProperty() requests larger than the ~16MB permitted even with
      BigReq will fail BadLength
    • Jon Turney's avatar
      hw/xwin: Implement INCR protocol for X clipboard -> Windows clipboard · 56a91f20
      Jon Turney authored
      Also, relax the timeout mechanism so it allows 1 second between events,
      rather than 1 second for the entire transfer, as transfers of large
      pastes can take more than 1 second.
      Also, prefer UTF8_STRING encoding to COMPOUND_TEXT encoding
  11. 10 Apr, 2020 1 commit
    • Michael Stapelberg's avatar
      Xorg: honor AutoRepeat option · 4f95d87d
      Michael Stapelberg authored
      This option was implemented before the drivers were split in ≈2006,
      and e.g. XWin still supports it.
      With this commit, Xorg regains support, so that the following configuration can
      be used to set the repeat rate for all keyboard devices without having to modify
      Xorg command-line flags or having to automate xset(1):
      Section "InputClass"
              Identifier "system-keyboard"
              MatchIsKeyboard "on"
              Option "XkbLayout" "de"
              Option "XkbVariant" "neo"
      	Option "AutoRepeat" "250 30"
      Signed-off-by: default avatarMichael Stapelberg <stapelberg@google.com>
  12. 30 Mar, 2020 3 commits
  13. 23 Mar, 2020 1 commit
    • Vasily Khoruzhick's avatar
      glx: fixup symbol name for get_extensions function · b56e5010
      Vasily Khoruzhick authored and Adam Jackson's avatar Adam Jackson committed
      glxProbeDriver() concatenates __DRI_DRIVER_GET_EXTENSIONS with driver name
      to get symbol name for get_extension function. Unfortunately that doesn't
      work for drivers that have hyphen in their name, e.g. sun4i-drm --
      get_extensions() for these uses underscore instead.
      As result dlsym() doesn't find get_extension() function and AIGLX
      initialization fails resulting in following message in Xorg.0.log:
      (EE) AIGLX error: sun4i-drm does not export required DRI extension
      Replace all non-alpha-numeric characters with underscore to fix the issue.
      Signed-off-by: Vasily Khoruzhick's avatarVasily Khoruzhick <anarsoul@gmail.com>
  14. 17 Mar, 2020 1 commit
  15. 13 Mar, 2020 2 commits
  16. 28 Feb, 2020 1 commit
  17. 25 Feb, 2020 2 commits
    • Peter Harris's avatar
      xkb: fix key type index check in _XkbSetMapChecks · de940e06
      Peter Harris authored
      This code block was moved from a function that returns 0 for failure to a
      function that returns 0 for Success in commit
      . Change the return value to
      BadValue to match the other checks in _XkbSetMapChecks.
      Set nTypes to xkb->map->num_types when XkbKeyTypesMask is not set, to
      allow requests with the XkbKeyTypesMask flag unset in stuff->present to
      Fixes a potential heap smash when client->swapped is true, because the
      remainder of the request will not be swapped after "return 0", but
      _XkbSetMap will be called anyway (because 0 is Success).
      Signed-off-by: Peter Harris's avatarPeter Harris <pharris@opentext.com>
    • Peter Harris's avatar
      xkb: only swap once in XkbSetMap · 270e4397
      Peter Harris authored
      The server swaps part of the request in _XkbSetMapChecks instead of
      SProcXkbSetMap (presumably because walking the XkbSetMap request is hard,
      and we don't want to maintain another copy of that code).
      Swap the first time _XkbSetMapChecks is called, not the second time.
      Signed-off-by: Peter Harris's avatarPeter Harris <pharris@opentext.com>
  18. 23 Feb, 2020 7 commits
    • Hans de Goede's avatar
      xwayland: Remove unnecessary xwl_window_is_toplevel() check from... · d4faab87
      Hans de Goede authored
      xwayland: Remove unnecessary xwl_window_is_toplevel() check from xwl_output_set_window_randr_emu_props()
      Since the recent fix to call xwl_output_set_window_randr_emu_props() from
      ensure_surface_for_window(), it is now only called on a toplevel window,
      so the is-toplevel check is not necessary for the
      xwl_output_set_window_randr_emu_props() case.
      This commit moves the check to xwl_output_set_randr_emu_prop_callback()
      so that we only do it when we are walking over all Windows of a client
      to update the property on a change of the emulated resolution.
      Acked-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    • Hans de Goede's avatar
      xwayland: Fix setting of _XWAYLAND_RANDR_EMU_MONITOR_RECTS prop on new windows · 148f428d
      Hans de Goede authored
      For window-manager managed windows, xwl_realize_window is only called for
      the window-manager's decoration window and not for the actual client window
      on which we should set the _XWAYLAND_RANDR_EMU_MONITOR_RECTS prop.
      Usualy this is not a problem since we walk all client windows to update
      the property when the resolution is changed through a randr call.
      But for apps which first do the randr change and only then create their
      window this does not work, and our xwl_output_set_window_randr_emu_props
      call in xwl_realize_window is a no-op as that is only called for the wm
      decoration window and not for the actual client's window.
      This commit fixes this by making ensure_surface_for_window() call
      xwl_output_set_window_randr_emu_props on the first and only child of
      window-manager managed windows.
      Note this also removes the non-functional xwl_output_set_window_randr_emu_props
      call from xwl_realize_window, which was intended to do this, but does not
      This fixes apps using the ogre3d library always running at the
      monitors native resolution.
      Acked-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    • Hans de Goede's avatar
      xwayland: Call xwl_window_check_resolution_change_emulation() on newly created O-R windows · 4cfc2677
      Hans de Goede authored
      Some clients, which use vidmode to change the resolution when going fullscreen,
      create an override-redirect window and never trigger the screen->ResizeWindow
      callback we rely on to do the xwl_window_check_resolution_change_emulation().
      This causes us to not apply a viewport to them, causing the fullscreen window
      to not fill the entire monitor.
      This commit adds a call to xwl_window_check_resolution_change_emulation()
      at the end of ensure_surface_for_window() to fix this. Note that
      ensure_surface_for_window() exits early without creating an xwl_window
      for new windows which will not be backed by a wayland surface and which
      thus will not have an xwl_window.
      This fixes ClanLib-0.6.x and alleggl-4.4.x using apps not properly
      Acked-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    • Hans de Goede's avatar
      xwayland: Fix emulated modes not being removed when screen rotation is used · 88342353
      Hans de Goede authored
      The code building the mode-list does the following to deal with screen
          if (need_rotate || xwl_output->rotation & (RR_Rotate_0 | RR_Rotate_180)) {
              mode_width = xwl_output->width;
              mode_height = xwl_output->height;
          } else {
              mode_width = xwl_output->height;
              mode_height = xwl_output->width;
      This means we need to do something similar in xwl_output_set_emulated_mode()
      to determine if the mode being set is the actual (not-emulated) output mode
      and we this should remove any emulated modes set by the client.
      All callers of xwl_output_set_emulated_mode always pass a mode pointer
      to a member of xwl_output->randr_output->modes, so we do not need to
      duplicate this code, instead we can simply check that the passed in mode
      is modes[0] which always is the actual output mode.
      Acked-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    • Hans de Goede's avatar
      xwayland: Also hook screen's MoveWindow method · 10df0437
      Hans de Goede authored
      Not only hook the ResizeWindow method of the screen (which really is
      MoveAndResize) but also hook the MoveWindow method for checking if we
      need to setup a viewport for resolution change emulation.
      Our resolution change emulation check if the windows origin matches
      the monitors origin and the windows origin can also be changed by just
      a move without being resized.
      Also checking on a move becomes esp. important when we move to checking
      on changes to the top-level non-window-manager client (X11)Window instead
      of on changes to the xwl_window later on in this patch series.
      Acked-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    • Hans de Goede's avatar
      xwayland: Also check resolution-change-emulation when the xwl_window itself moves · 4fc10746
      Hans de Goede authored
      The recent change to use the top-level non-window-manager Window drawable
      coordinates from xwl_window_check_resolution_change_emulation() in
      combination with only calling it on a resize when the top-level window
      is moved breaks things with mutter/gnome-shell.
      When fullscreening a X11 window, mutter moves its window-decoration Window
      wrapping the top-level Window to the monitor's origin coordinates (e.g. 0x0)
      last. This updates the top-level's drawable coordinates, but as the
      actual MoveWindow is called on the wrapper Window and not on the toplevel
      we do not call xwl_window_check_resolution_change_emulation() and we never
      enable the viewport.
      This commit fixes this by also calling
      xwl_window_check_resolution_change_emulation() if the Window being moved
      is an xwl_window itself.
      Acked-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    • Roman Gilg's avatar
      xwayland: Check emulation on client toplevel resize · 6d98f840
      Roman Gilg authored
      When a reparented window is resized directly check the emulation instead of
      doing this only when the window manager parent window is resized, what might
      never happen.
      For that to work we need to make sure that we compare the current size of the
      client toplevel when looking for an emulated mode.
      Changes by Hans de Goede:
      - Remove xwl_window x, y, width and height members as those are no longer used.
      - Add check for xwl_window_from_window() returning NULL.
      Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      Acked-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>