1. 07 Mar, 2014 1 commit
  2. 18 Feb, 2014 5 commits
  3. 10 Feb, 2014 1 commit
  4. 08 Feb, 2014 2 commits
    • Kristian Høgsberg's avatar
      client: Queue display events on private queue and always dispatch · b9eebce0
      Kristian Høgsberg authored
      The wl_display events (error and delete_id) need to be handled even
      if the default queue doesn't get dispatched for a while.  For example,
      a busy EGL rendering loop hits wl_display.sync every eglSwapBuffers()
      and we need to process the delete_id events to maintain the object ID
      data structure.
      
      As it is, that doesn't happen, but with this change we special case
      wl_display events.  We put them on a custom, private queue and when
      dispatching events, we always dispatch display_queue events first.
      The wl_display proxy should still be the default_queue, so that objects
      created from wl_display requests get assigned to that.
      b9eebce0
    • Kristian Høgsberg's avatar
      client: Rename display->queue to default_queue · a9eb563f
      Kristian Høgsberg authored
      We'll add a new queue next, so rename the default queue first.
      a9eb563f
  5. 07 Feb, 2014 1 commit
  6. 06 Feb, 2014 2 commits
    • Jason Ekstrand's avatar
      8fd2520d
    • Neil Roberts's avatar
      Don't deref the sample pointer in the wl_container_of macro · a18e3441
      Neil Roberts authored
      The previous implementation of the wl_container_of macro was
      dereferencing the sample pointer in order to get an address of the
      member to calculate the offset. Ideally this shouldn't cause any
      problems because the dereference doesn't actually cause the address to
      be read from so it shouldn't matter if the pointer is uninitialised.
      However this is probably technically invalid and could cause undefined
      behavior. Clang appears to take advantage of this undefined behavior
      and doesn't bother doing the subtraction. It also gives a warning when
      it does this.
      
      The documentation for wl_container_of implies that it should only be
      given an initialised pointer and if that is done then there is no
      problem with clang. However this is quite easy to forget and doesn't
      cause any problems or warnings with gcc so it's quite easy to
      accidentally break clang.
      
      To fix the problem this changes the macro to use pointer -
      offsetof(__typeof__(sample), member) so that it doesn't need to deref
      the sample pointer. This does however require that the __typeof__
      operator is supported by the compiler. In practice we probably only
      care about gcc and clang and both of these happily support the
      operator.
      
      The previous implementation was also using __typeof__ but it had a
      fallback path avoiding it when the operator isn't available. The
      fallback effectively has undefined behaviour and it is targetting
      unknown compilers so it is probably not a good idea to leave it in.
      Instead, this patch just removes it. If someone finds a compiler that
      doesn't have __typeof__ but does work with the old implementation then
      maybe they could add it back in as a special case.
      
      This patch removes the initialisation anywhere where the sample
      pointer was being unitialised before using wl_container_of. The
      documentation for the macro has also been updated to specify that this
      is OK.
      a18e3441
  7. 31 Jan, 2014 3 commits
  8. 24 Jan, 2014 1 commit
  9. 20 Jan, 2014 4 commits
  10. 19 Jan, 2014 1 commit
  11. 17 Jan, 2014 1 commit
  12. 15 Jan, 2014 11 commits
  13. 10 Jan, 2014 1 commit
  14. 09 Jan, 2014 1 commit
  15. 17 Dec, 2013 2 commits
  16. 10 Dec, 2013 1 commit
  17. 09 Dec, 2013 2 commits