1. 20 Nov, 2019 1 commit
  2. 06 Sep, 2019 1 commit
  3. 25 Jul, 2019 2 commits
  4. 17 Jul, 2019 3 commits
    • Jan-Marek Glogowski's avatar
      xdg-shell: use case to change the app ID at runtime · e0d6ad1d
      Jan-Marek Glogowski authored and Jonas Ådahl's avatar Jonas Ådahl committed
      LibreOffice is one big binary with explicit brandings for different
      application modules. This is represented in X11 by a different
      WM_CLASS setting for a window. The WM_CLASS is changed based on the
      loaded document at runtime. As a result LibreOffice already offers
      multiple desktop files with different icons, StartupWMClass
      entries and application names.
      This amendment of the set_app_id request just explicitly specifies
      the use case to change a surfaces' app ID at runtime, so a compositor
      implementor is made aware of it. Just as the WM_CLASS, a change of
      the app ID should result in an update of the propertes of a surface
      depending on the app ID, like the window icon specified in the
      desktop file or a re-grouping of the surfaces in a task manager.
      Signed-off-by: Jan-Marek Glogowski's avatarJan-Marek Glogowski <glogow@fbihome.de>
      Reviewed-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
      Reviewed-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
    • Simon Ser's avatar
      pointer-gestures: add a release request · b9d427db
      Simon Ser authored and Jonas Ådahl's avatar Jonas Ådahl committed
      This allows clients to destroy a gesture object before they disconnect.
      The request isn't named "destroy", as this would conflict with
      wayland-scanner's auto-generated destructor (which just destroys the
      client-side object without sending any request).
      Signed-off-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
      Reviewed-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
    • Simon Ser's avatar
      xdg-output: deprecate the xdg_output.done event · 962dd535
      Simon Ser authored and Jonas Ådahl's avatar Jonas Ådahl committed
      This commit makes it so a wl_output.done event is guaranteed to be sent with a
      xdg_output.done event.
      This protocol change has been discussed in a recent xorg-devel discussions [1].
      First let's recap why a change is needed: Xwayland listens to both wl_output and
      xdg_output changes. When an output's properties change, Xwayland expects to
      receive both a wl_output.done event and an xdg_output.done event. If that's not
      the case, Xwayland doesn't update its state (so old state is still exposed to
      X11 clients).
      Most of the time, both objects will be updated at the same time (e.g. the
      current mode is changed, so both wl_output.mode and xdg_output.logical_size are
      sent) so this won't be an issue. However in some situations only one of
      wl_output or xdg_output changes. For instance:
      - The mode is changed at the same time as the scale, resulting in the same
      - The compositor doesn't expose the outputs' position via wl_output, so whenever
        the position changes only xdg_output is updated.
      Both KDE [2] and wlroots [3] have experienced this issue.
      For this reason, I'd like to update the xdg-output protocol to make it mandatory
      to always send a wl_output.done event after xdg_output changes. This effectively
      makes wl_output.done atomically apply all output state (including the state of
      add-on objects like xdg_output). This approach is pretty similar to
      wl_surface.commit: this request will atomically apply surface state including
      the state of e.g. the xdg_surface object tied to the wl_surface.
      To update the protocol to reflect this new requirement we can either:
      - **Bump xdg_output version**. The current protocol doesn't specify that
        wl_output.done must be sent, adding this new requirement would be a breaking
        change. We need to fix Xwayland for the current xdg_output version (maybe make
        it non-atomic for the current version, atomic for the new one?). Should we
        deprecate xdg_output.done in the new version?
      - **Don't bump xdg_output version**. This clarifies what is expected in practice
        by Xwayland, a major xdg_output consumer, and what is currently implemented by
        all compositors.
      There's one issue with the "don't bump" approach: indeed in practice compositors
      always send wl_output.done and xdg_output.done in pairs, however the ordering
      between those two events is not guaranteed. This means some compositors might
      send this sequence:
      In this case the wl_output.done event fails to atomically apply the xdg_output
      For this reason, I think bumping the version is a better approach.
      This commit also deprecates xdg_output.done, which doesn't have any purpose
      [1]: https://lists.x.org/archives/xorg-devel/2019-April/058148.html
      [2]: https://phabricator.kde.org/D19253
      [3]: https://github.com/swaywm/sway/issues/4064
      Signed-off-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
      Reviewed-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      Reviewed-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
  5. 22 May, 2019 1 commit
  6. 02 May, 2019 1 commit
  7. 17 Jan, 2019 1 commit
  8. 14 Dec, 2018 3 commits
  9. 12 Nov, 2018 3 commits
  10. 31 Jul, 2018 1 commit
  11. 30 Jul, 2018 6 commits
  12. 16 Jul, 2018 1 commit
  13. 04 Jul, 2018 3 commits
  14. 18 Jun, 2018 1 commit
  15. 03 May, 2018 3 commits
  16. 14 Feb, 2018 1 commit
  17. 19 Jan, 2018 2 commits
  18. 02 Dec, 2017 2 commits
  19. 22 Nov, 2017 1 commit
    • Jonas Ådahl's avatar
      xdg-shell: Soften fullscreen geometry requirements · f68bafc9
      Jonas Ådahl authored
      Having a strict requirement on clients obeying the configured window
      geometry for fullscreen toplevel surfaces might have the side effect of
      making it harder or impossible to implement various hardware
      optimizations on certain system configurations. By softening
      requirements on the geometry while loosely defining the border fill, we
      remove that restriction.
      Clients that still want total control of the surrounding area can
      still for example prepare the attached buffers to match the configured
      surface size, or use subsurfaces in combination with wp_viewporter to
      make up a surface matching the fullscreen window geometry dimensions.
      Signed-off-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
      Reviewed-by: Arnaud Vrac's avatarArnaud Vrac <rawoul@gmail.com>
      Reviewed-by: default avatarMike Blumenkrantz <zmike@samsung.com>
  20. 21 Nov, 2017 3 commits