Commit 9b9f9d0a authored by Committed by Sebastian DrögeBrowse files
v4l2src: in negotiate, check for error return from set_caps
Fixes #621723 (partially) set_caps can fail if the video device is running, in that case setting its format leads to EBUSY. If set_caps fails then we will not have set up the buffer pool (it will be NULL) which leads to a crash when we try to pull buffers. If we fail the negotiate on set_caps failure, then we won't go to playing state and won't crash. This is a small improvement. Of course, a nicer fix would be to make set_caps work in the case where the format is unchanged. If the format has changed, failing is probably correct because we need to close the device (go to NULL state) in order to set caps.
Showing with 2 additions and 2 deletions