Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Reproduces: #294


Reproduces: CVE-2020-12049
Reproduces: GHSL-2020-057
Signed-off-by: Simon McVittie <smcv@collabora.com>

MSG_CTRUNC indicates that we have received fewer fds that we should
have done because the buffer was too small, but we were treating it
as though it indicated that we received *no* fds. If we received any,
we still have to make sure we close them, otherwise they will be leaked.

On the system bus, if an attacker can induce us to leak fds in this
way, that's a local denial of service via resource exhaustion.

Reported-by: Kevin Backhouse, GitHub Security Lab
Fixes: #294
Fixes: CVE-2020-12049
Fixes: GHSL-2020-057

Signed-off-by: Simon McVittie <smcv@collabora.com>

CI: run cross compiled tests

Closes #296

See merge request dbus/dbus!158

This helps to detect incorrect settings.

Before building a wine prefix is created and search pathes
for binaries are configured in the wine prefix.

This commit adds a new shell variable 'ci_runtime' for specifing
the type of compiler support library which defaults to static for now.

Let Wine display the correct file name and line numbers for backtraces

See merge request dbus/dbus!104

Wine currently only supports the symbol formats STABS and DWARF 2,
but not the other versions, with STABS providing the most information
and being the first choice.

Since we already use the cmake variable DBUS_USE_WINE for running tests
under Wine, we also use it to activate the special symbol format.

Closes dbus/dbus/#133

This error was discovered when working with the merge request
!158.

This prevented setting cross compile support required for !158.

Build missing tools with cmake

See merge request dbus/dbus!154

Add support to generate the api documentation in Qt help format

See merge request dbus/dbus!150

Qt help files are used by Qt Creator and KDevelop, for example, to support
the development of Qt-based applications and libraries.

Generating api documentation in Qt help format is controlled by two
user specific options named --enable-qt-help and --with-qchdir (autotools)
and -DENABLE_QT_HELP and -DINSTALL_QCH_DIR (cmake).

Marking targets with a component would only be useful if we
marked every target with a component in a consistent way,
but because we don't do that, it's pointless to have it
in just a few places.

_dbus_poll(): Prevent buffer overflow in Windows verbose logging

See merge request dbus/dbus!125

Ralf Habacker authored Dec 03, 2019 and Simon McVittie committed Apr 29, 2020

The former int type leads to warnings.

Ralf Habacker authored Apr 28, 2020 and Simon McVittie committed Apr 29, 2020

For cleaning purpose the event list members are initialized with
WSA_INVALID_EVENT. The cleanup code detects and handles the
case that the event list has been created from calloc ().

Ralf Habacker authored Apr 28, 2020 and Simon McVittie committed Apr 29, 2020

The function _dbus_poll() has been split into two functions,
_dbus_poll_events() and _dbus_poll_select(), each containing the
corresponding implementation.

_dbus_poll() now calls the corresponding function.

shell-test: Print diagnostics to stderr

See merge request dbus/dbus!157

Salamandar authored Apr 27, 2020 and Simon McVittie committed Apr 28, 2020

Some of the command-lines that we print as diagnostics contain newlines,
which will cause warnings or errors under a strict TAP parser (and one of
them wasn't correctly prefixed with '#' anyway). TAP parsers only parse
stdout, not stderr, so we can use stderr for these diagnostic messages.

[smcv: Expand commit message]
Signed-off-by: Simon McVittie <smcv@collabora.com>

Free allocated buffer in test_content() to avoid a resource leak

See merge request dbus/dbus!146

Otherwise, Coverity will diagnose this as a resource leak,
because it doesn't understand that our assertions end up guaranteeing
that the result is freed if and only if it's non-`NULL`.

Coverity CID: 354884

In dbus_get_autolaunch_address() return all errors as dbus error

Closes #191

See merge request dbus/dbus!131

This provides a consistent error reporting.

Fixes #191

Fix possible truncation of protocol output in dbus_logv()

See merge request dbus/dbus!134

_dbus_verbose_real: Use the Python convention for quoting potentially multi-line strings when memory is unavailable on Windows

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Make more tests modular

See merge request dbus/dbus!153

Assertions can be disabled, but in test code the assertions are the
whole point, so use checks that can't be disabled instead.

Because there's a lot of test code, I haven't done this globally, only
in the tests that I recently converted from "embedded" to "modular".
Signed-off-by: Simon McVittie <smcv@collabora.com>

Assertions can be disabled; but in test code the assertions are the
entire point, so we don't want to disable them. Use _dbus_test_fatal()
instead.

test-service is actually a test helper rather than a test, so use its
pre-existing die() function instead.
Signed-off-by: Simon McVittie <smcv@collabora.com>

These previously relied on embedding test-specific code in libdbus,
but they actually only need public APIs, private interfaces that get
exported anyway for the benefit of dbus-daemon, and the TAP helpers;
so we can run them even in production builds.
Signed-off-by: Simon McVittie <smcv@collabora.com>