Skip to content

GitLab

mesa
mesa

ir3/compiler: Use the NIR computed offset for image store/atomics 

Remove the offset computation from the a4xx/a5xx backend and use the
one pre-computed in NIR by lower_io_offsets pass.

No regressions observed on affected tests from Khronos CTS and piglit
suites, compared to master.

Unfortunately shader-db is not helpful for stats in this case. Few
shaders there exercise image store or image atomic, and of those that
do, most require higher versions of GLSL than 3.10, so they get skipped.
47 jobs for !1579 with fd/lower-io-offsets-image-store-atomics in 46 minutes and 13 seconds (queued for 4 seconds)
latest detached
5ce0604a
1 related merge request: !1579 Freedreno: Extend lower_io_offsets pass to lower image store/atomics on a4xx/a5xx
Status Job ID Name Coverage
  Container
passed #884699
debian-10:amd64

00:28:39

passed #884701
aarch64
debian-10:arm64

00:01:02

passed #884700
debian-9:amd64

00:00:20

failed #884698
lava-container:arm64

00:17:28

passed #884697
lava-container:armhf

00:01:58

 
  Build
skipped #884703
mesa-autoscale
lava-build:arm64
passed #884702
mesa-autoscale
lava-build:armhf

00:01:59

passed #884706
aarch64
meson-arm64

00:08:27

passed #884705
aarch64
meson-armhf

00:05:06

passed #884708
mesa-autoscale
meson-clang

00:11:05

passed #884711
mesa-autoscale
meson-clover

00:11:27

passed #884712
mesa-autoscale
meson-clover-old-llvm

00:03:11

passed #884714
mesa-autoscale
meson-i386

00:08:12

failed #884704
mesa-autoscale
meson-main

00:14:40

passed #884715
mesa-autoscale
meson-mingw32-x86_64

00:03:50

passed #884707
mesa-autoscale
meson-swr-glvnd

00:08:40

passed #884713
mesa-autoscale
meson-vulkan

00:08:47

passed #884716
mesa-autoscale
scons

00:17:31

passed #884717
mesa-autoscale
scons-old-llvm

00:08:02

passed #884709
mesa-autoscale
scons-swr

00:10:28

passed #884710
mesa-autoscale
scons-win64

00:11:39

 
  Test
passed #884740
db410c
arm64_a306_gles2 1/4

00:03:35

passed #884741
db410c
arm64_a306_gles2 2/4

00:04:47

passed #884742
db410c
arm64_a306_gles2 3/4

00:03:47

passed #884743
db410c
arm64_a306_gles2 4/4

00:03:46

passed #884729
mesa-cheza
arm64_a630_gles2

00:04:23

passed #884730
mesa-cheza
arm64_a630_gles31 1/4

00:04:19

passed #884731
mesa-cheza
arm64_a630_gles31 2/4

00:04:44

passed #884732
mesa-cheza
arm64_a630_gles31 3/4

00:04:59

passed #884733
mesa-cheza
arm64_a630_gles31 4/4

00:05:01

passed #884734
mesa-cheza
arm64_a630_gles3 1/6

00:03:22

passed #884735
mesa-cheza
arm64_a630_gles3 2/6

00:03:49

passed #884736
mesa-cheza
arm64_a630_gles3 3/6

00:03:42

passed #884737
mesa-cheza
arm64_a630_gles3 4/6

00:03:49

passed #884738
mesa-cheza
arm64_a630_gles3 5/6

00:03:40

passed #884739
mesa-cheza
arm64_a630_gles3 6/6

00:03:44

failed #884718
lava-rk3288-veyron-jaq
panfrost-t760-test:armhf

00:15:43

skipped #884719
lava-rk3399-gru-kevin
panfrost-t860-test:arm64
skipped #884720
test-llvmpipe-gles2 1/4
skipped #884721
test-llvmpipe-gles2 2/4
skipped #884722
test-llvmpipe-gles2 3/4
skipped #884723
test-llvmpipe-gles2 4/4
skipped #884724
test-softpipe-gles2 1/4
skipped #884725
test-softpipe-gles2 2/4
skipped #884726
test-softpipe-gles2 3/4
skipped #884727
test-softpipe-gles2 4/4
skipped #884728
test-softpipe-gles3-limited
 
Name Stage Failure
failed
lava-container:arm64 Container 
chroot: failed to run command '/bin/true': Exec format error
+ set -e
+ chroot /artifacts/rootfs sh /create-rootfs.sh
chroot: failed to run command 'sh': Exec format error
subprocess exited with status 126
subprocess exited with status 126
Running after script...
$ if [[ ! -e .success ]] ; then exit 0; fi
ERROR: Job failed: exit code 1
failed
meson-main Build 
Creating cache meson-main...
WARNING: ccache: no matching files                 
No URL provided, cache will be not uploaded to shared cache server. Cache will be stored only locally. 
Created cache
Uploading artifacts...
artifacts: found 15 matching files                 
ERROR: Uploading artifacts to coordinator... too large archive  id=884704 responseStatus=413 Request Entity Too Large status=413 Request Entity Too Large token=XwZtM9zF
FATAL: too large                                   
ERROR: Job failed: command terminated with exit code 1
failed
panfrost-t760-test:armhf Test 
visibility  : Publicly visible
submit time : 20191105T08:54:05
start time  : 20191105T09:03:14
end time    : 20191105T09:09:12
$ result=`lavacli results $lava_job_id 0_deqp deqp | head -1`
Uploading artifacts...
results/: found 8 matching files                   
Uploading artifacts to coordinator... ok            id=884718 responseStatus=201 Created token=QwryusZi
ERROR: Job failed: exit code 1