- This is required, since the avfilter pipeline is constantly
  constructed / destructed. Properties that have been set in the
meantime have to be re-applied when the pipeline is re-constructed /
re-configured

This makes it easier to do development with MSVC by making it warn
on common issues that GCC/Clang error out for in our CI configuration.

Continuation from gstreamer/gst-build!223

Part-of: <gstreamer/gst-libav!109>

The check seems to be to present to verify that the decoded frame
matches the format we expect. The actual check for the layout of the
frame was being performed against the context instead.

The check fails at least for avdec_aptx_hd, where the AVCodecContext has
the sample format set to AV_SAMPLE_FMT_NONE.

Part-of: <gstreamer/gst-libav!107>

Add simple encoder drain test case

Part-of: <!100>

Edward Hervey authored Oct 01, 2020 and Seungha Yang committed Oct 07, 2020

Looks like they weren't ported when we switched to meson

Part-of: <!100>

Since the commit https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/22b25b3ea5c,
ffmpeg will not clear draning flag for encoder by avcodec_flush_buffers() API
by default. Allowed case is only if encoder has AV_CODEC_CAP_ENCODER_FLUSH
capability flag. If it's not supported, we should re-open encoding
session, otherwise ffmpeg encoder will keep returning AVERROR_EOF

Part-of: <gstreamer/gst-libav!99>

This is already done in all other codec elements.

Part-of: <gstreamer/gst-libav!97>

Same behaviour as for avviddec now. FFmpeg will return AVERROR_EOF when it's
completely drained but we should not return that here or otherwise
upstream will receive EOS and not forward us more data.

Part-of: <gstreamer/gst-libav!97>

AVERROR_EOF means that it's fully drained, but it doesn't
mean that that end of stream.

Part-of: <gstreamer/gst-libav!90>

audiodecoder baseclass implementation is expecting that
finish_subframe() is followed by finish_frame() in order clear
its internal state related to subframe.

Part-of: <gstreamer/gst-libav!90>

It might be useful for upstream to know that draining/finishing didn't
succeed, and why.

Part-of: <gstreamer/gst-libav!90>

It might be useful for upstream to know that draining/finishing didn't
succeed, and why.

Part-of: <gstreamer/gst-libav!90>

Edward Hervey authored Sep 09, 2020 and Sebastian Dröge committed Sep 14, 2020

When sucessfully finishing out frames (or finishing configuration), we must make
sure we don't override any failing GstFlowReturn that might have been detected
previously.

Failure to do this would result in not propagating not-linked, flushing,
etc...

Part-of: <gstreamer/gst-libav!90>

This now works with not so recent ffmpeg.

Part-of: <gstreamer/gst-libav!88>

Part-of: <gstreamer/gst-libav!89>

Part-of: <gstreamer/gst-libav!86>

This reverts commit d1b20eb6.

See gstreamer/gst-ci!324

Part-of: <gstreamer/gst-libav!85>

Jordan Petridіs authored Jul 03, 2020 and Jordan Petridіs committed Jul 23, 2020

Part-of: <gstreamer/gst-libav!80>

Part-of: <!84>

We examined the output buffer, instead of the input buffer, for
existence of cc meta.

Part-of: <gstreamer/gst-libav!83>

Vivia Nikolaidou authored Jul 02, 2020 and GStreamer Marge Bot committed Jul 03, 2020

Following discussion in
gstreamer/gst-plugins-bad!1396 (comment 556068)

While it is technically possible to store multiple closed caption metas
in the same buffer, we don't currently do that anywhere and for
H264/MPEG2 both parts have to be stored in the same packet, and also the
number of CC bytes you can store per frame is rather limited. This
restriction might be relaxed later once we figured out how to do it
without breaking things.

Part-of: <gstreamer/gst-libav!82>

Part-of: <gstreamer/gst-libav!81>

Part-of: <gstreamer/gst-libav!79>

Mathieu Duponchelle authored Jun 18, 2020 and GStreamer Marge Bot committed Jun 20, 2020

Part-of: <gstreamer/gst-libav!76>