From d69f11e8c57e9459c9e60bffc0f2c6c3aa02f4b1 Mon Sep 17 00:00:00 2001
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
Date: Wed, 11 Sep 2024 17:36:22 +0500
Subject: [PATCH] ASoc: mediatek: mt8365: Remove unneeded assignment
The ret is being assigned, but not being used. Remove the assignment.
One of the reviewer mentioned that dev_warn should be replaced with
dev_info. Make this change as well.
Fixes: 1bf6dbd75f76 ("ASoc: mediatek: mt8365: Add a specific soundcard for EVK")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patch.msgid.link/20240911123629.125686-1-usama.anjum@collabora.com
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/mediatek/mt8365/mt8365-mt6357.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/mediatek/mt8365/mt8365-mt6357.c b/sound/soc/mediatek/mt8365/mt8365-mt6357.c
index 1b8d1656101b9..42cbdfdfadb55 100644
--- a/sound/soc/mediatek/mt8365/mt8365-mt6357.c
+++ b/sound/soc/mediatek/mt8365/mt8365-mt6357.c
@@ -257,8 +257,7 @@ static int mt8365_mt6357_gpio_probe(struct snd_soc_card *card)
priv->pin_states[i] = pinctrl_lookup_state(priv->pinctrl,
mt8365_mt6357_pin_str[i]);
if (IS_ERR(priv->pin_states[i])) {
- ret = PTR_ERR(priv->pin_states[i]);
- dev_warn(card->dev, "No pin state for %s\n",
+ dev_info(card->dev, "No pin state for %s\n",
mt8365_mt6357_pin_str[i]);
} else {
ret = pinctrl_select_state(priv->pinctrl,
--
GitLab