1. 05 Feb, 2019 2 commits
  2. 05 Jul, 2018 1 commit
  3. 21 May, 2018 1 commit
    • Katarzyna Dec's avatar
      lib/media_fill: Create common media_fill library for all gens · 219cc4f2
      Katarzyna Dec authored
      Let's create common media_fill library, similarly as for gpgpu_fill.
      This will allow to make code easier to read and maintain.
      Moreover we can create generic __gen9_media_fillfunc for future gens.
      >From gen9 media fillfunctions differ only with kernel parameter.
      
      v2: fixed indentations in files
      v3: Added missing copyright headers. Made __gen9_media_fillfunc static.
      Removed gen9 kernel (the same as for gen8).
      v4: rebase
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Antonio Argenziano <antonio.argenziano@intel.com>
      Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Cc: Ewelina Musial <ewelina.musial@intel.com>
      Reviewed-by: Lukasz Kalamarz's avatarLukasz Kalamarz <lukasz.kalamarz@intel.com>
      219cc4f2
  4. 15 May, 2018 3 commits
    • Katarzyna Dec's avatar
      lib: Rename library from gpu_fill to gpu_cmds · 94df6765
      Katarzyna Dec authored
      After refactoring media_spin library - gpu_fill contains helper
      functions for render copy, *_fill functions and media_spin.
      Let's rename this library to gpu_cmds. This name will be more
      general.
      
      v2: changed name from gpu_helpers to gpu_cmds
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Antonio Argenziano <antonio.argenziano@intel.com>
      Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Reviewed-by: 's avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      94df6765
    • Katarzyna Dec's avatar
      lib/gpu_fill: Further code unification in gpu_fill · b8fdb262
      Katarzyna Dec authored
      We can unify gen7_emit_vfe_state and gen8_emit_vfe_state
      functions for gpgpu/media_fill and media_spin by adding
      parameters. gen8_emit_media_object was renamed to gen_*
      and extended with additional offset parameters - we can
      have one gen7_emit_media_objects for all tests.
      I have renamed gen8_emit_media_object to gen_emit_*, because
      function belongs to all gens and it would be odd to have
      all named genX_* and only one without this prefix.
      
      v2: Use #defines instead of variables as emit_vfe_state parameters.
      Fixed gen7_emit_media_objects. Unified vfe state parameters
      in media_spin library for gen8 and gen9 (gen9 had different values
      by mistake).
      v3: Fixed bug in emit_vfe_state for gen8 and gen9 in gpgpu_fill.
      Moved #defines for emit_vfe_state to particular libraries.
      v4: Fixed indentations in media_spin
      v5: Few more style changes.
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Antonio Argenziano <antonio.argenziano@intel.com>
      Reviewed-by: 's avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Cc: Ewelina Musial <ewelina.musial@intel.com>
      Reviewed-By: 's avatarEwelina Musial <ewelina.musial@intel.com>
      b8fdb262
    • Katarzyna Dec's avatar
      lib: Adjust media_spin and gpu_fill to our code style · 27d4cc66
      Katarzyna Dec authored
      Let's adjust code to our coding style during refactoring
      media_spin code.
      Few more changes in gpgpu_fill lib was made as well:
      intend align and /s/unsigned/unsigned int.
      
      v2: fixed minor typos
      v3: few more style changes
      v4: few indentation changes
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Antonio Argenziano <antonio.argenziano@intel.com>
      Cc: Ewelina Musial <ewelina.musial@intel.com>
      Reviewed-by: 's avatarEwelina Musial <ewelina.musial@intel.com>
      27d4cc66
  5. 24 Apr, 2018 1 commit
  6. 12 Apr, 2018 4 commits
    • Katarzyna Dec's avatar
      lib: Adjust refactored gpu_fill library to our coding style · 80e49105
      Katarzyna Dec authored
      While I am making changes in gpgpu and media fill area let's
      adjust code to our coding style.
      
      v2: rebased on series new version (patch is now last from
      series so change seems larger)
      v3: rebased
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Reviewed-by: Radosław's avatarRadoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
      80e49105
    • Katarzyna Dec's avatar
      lib/gpgpu_fill: Add missing configuration parameters for gpgpu_fill · 098b05b2
      Katarzyna Dec authored
      There are missing parameters for Gen8 configuration of gpgpu_fill
      that are causing GPU hangs on newer hardware. We need to set the
      number of threads in TG in gen8_fill_interface_descriptor. This
      field was omitted (apparently without any side effects), but
      according to bspec from BDW this field cannot be set to 0. We also
      need to use pipeline selection mask to gen9_gpgpu_fillfunc, which
      is necessary from SKL.
      
      v2: rebased on refactored library
      v3: Removed replacing gen7_emit_interface_descriptor_load with gen8
      version in gen9_gpgpgu_fillfunc, because during refactoring gen8
      function was removed.
      v4: rebase on series new version
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Reviewed-by: Radosław's avatarRadoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
      098b05b2
    • Katarzyna Dec's avatar
      lib: Remove duplications in gpu_fill library · 80996145
      Katarzyna Dec authored
      After moving all functions needed for gpgpu and media fill testing
      there is a lot of duplications which can be removed:
        Library media_fill_gen8 and media_fill_gen8lp for CHT was removed,
      media state flush for !CHT was added to gen7_emit_media_objects.
        Many gen8 functions were replaced with gen7 version with devid
      parameter (gen7_fill_curbe_load, gen7_emit_interface_descriptor,
      gen7_fill_binding_table, gen7_emit_media_objects). Unified fill kernel
      function so it is applicable to all gens and both media and gpgpu
      (merged gen7_fill_media_kernel and gen8_fill_media_kernel).
        Duplicated constants like GEN8_MEDIA_VFE_STATE, GEN8_MEDIA_CURBE_LOAD,
      GEN8_MEDIA_INTERFACE_DESCRIPTOR_LOAD, GEN8_MEDIA_OBJECT were
      replaced by GEN7 version. However this constants were not removed
      from gen8_media.h library, because they are used by other tests
      for Gen8+. More refactoring in this gen*_media.h libraries is needed.
      
      It seems that further unification of *_fillfunc functions will
      introduce more confusion in understanding what the tests are doing
      and what were changes between Gens.
      
      v2: Moved some reduntant changes from Move gpgpu/media fill to gpu_fill...
      to this patch. Applied comments from review.
      
      v3: rebase
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Reviewed-by: Radosław's avatarRadoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
      80996145
    • Katarzyna Dec's avatar
      lib: Move common gpgpu/media fill functions to gpu_fill library · 081f7717
      Katarzyna Dec authored
      Gpgpu_fill and media_fill libraries are very similar and many
      functions can be shared. I have created library gpu_fill with
      all functions needed for implementing gpgpu_fill and media_fill
      tests for all Gens. For reviewing and debugging purposes this patch
      should be only moving functions from few libraries to one removing
      functions identical for both media and gpgpu.
      Places in the code that required more changes:
        Removing gen7_fill_gpgpu_kernel function that is identical to
      gen7_fill_media_kernel and introduces conflict with moving
      genX_fill_interface_descriptor, which are the same for media and gpgpu.
        Function gen8_fill_media_kernel is not removed in this patch
      (although it is identical with gen7 version), because this patch
      should be as much as possible functions movement.
        gen8_fill_interface_descriptor was unified for media and gpgpu
      by adding kernel and its size as a parameter (this parameters
      were missing in media gen8, gen8lp and gen9 functions)
        gen8_emit_state_base_address was unified, the one for gpgpu was
      configured like it would be using indirect state (while we are
      using CURBE). I have checked that media fill version
      (OUT_BATCH(0 | BASE_ADDRESS_MODIFY)) works fine on gpgpu gen8 and newer.
      
      v2: Changed code layout. GenX_fill_media_kernel was identical to
      genX_fill_gpgpu_kernel so this function was unified to
      gen7_fill_kernel. There were 2 very similar functions
      gen8_emit_state_base_address for media and gpgpu, where the one
      for gpgpu was configured like it would be using indirect state
      (while we are using CURBE). I have checked if media fill version
      works fine in gpgpu test on Gen8 and unified them.
      
      v3: Made patch easier for reviewing moving changes unifying code for
      various gens (that were included v1) to other patch, leaving only
      the most critical code changes.
      
      v5: Added copyrights and #ifndef to gpu_fill.h
      v5: Added copyrights to gpu_fill.c
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Reviewed-by: Radosław's avatarRadoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
      081f7717
  7. 25 Aug, 2015 1 commit
  8. 20 Jul, 2015 3 commits
  9. 04 Dec, 2014 1 commit
    • Zhenyu Wang's avatar
      lib: Add GPGPU fill · 10c6ad38
      Zhenyu Wang authored
      This is to add fill operation using GPGPU pipeline which is similar to
      current media fill. This can be used to simply verify GPGPU pipeline
      and help to enable it on newer HW, currently it works on Gen7 only and
      will add support on later platform.
      
      Now this sets very simply thread group dispatch for one thread per
      thread group on SIMD16 dispatch. So the fill shader just uses thread
      group ID for buffer offset.
      
      v2: No new fill func typedef but adapt to igt_fillfunc_t.
      Signed-off-by: 's avatarZhenyu Wang <zhenyuw@linux.intel.com>
      10c6ad38
  10. 26 Aug, 2014 1 commit
  11. 24 Apr, 2014 1 commit
  12. 22 Mar, 2014 3 commits
  13. 06 Dec, 2013 2 commits