1. 05 Feb, 2019 2 commits
  2. 05 Jul, 2018 1 commit
  3. 15 May, 2018 5 commits
  4. 24 Apr, 2018 1 commit
  5. 12 Apr, 2018 2 commits
    • Katarzyna Dec's avatar
      lib: Remove duplications in gpu_fill library · 80996145
      Katarzyna Dec authored
      After moving all functions needed for gpgpu and media fill testing
      there is a lot of duplications which can be removed:
        Library media_fill_gen8 and media_fill_gen8lp for CHT was removed,
      media state flush for !CHT was added to gen7_emit_media_objects.
        Many gen8 functions were replaced with gen7 version with devid
      parameter (gen7_fill_curbe_load, gen7_emit_interface_descriptor,
      gen7_fill_binding_table, gen7_emit_media_objects). Unified fill kernel
      function so it is applicable to all gens and both media and gpgpu
      (merged gen7_fill_media_kernel and gen8_fill_media_kernel).
        Duplicated constants like GEN8_MEDIA_VFE_STATE, GEN8_MEDIA_CURBE_LOAD,
      GEN8_MEDIA_INTERFACE_DESCRIPTOR_LOAD, GEN8_MEDIA_OBJECT were
      replaced by GEN7 version. However this constants were not removed
      from gen8_media.h library, because they are used by other tests
      for Gen8+. More refactoring in this gen*_media.h libraries is needed.
      
      It seems that further unification of *_fillfunc functions will
      introduce more confusion in understanding what the tests are doing
      and what were changes between Gens.
      
      v2: Moved some reduntant changes from Move gpgpu/media fill to gpu_fill...
      to this patch. Applied comments from review.
      
      v3: rebase
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Reviewed-by: Radosław's avatarRadoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
      80996145
    • Katarzyna Dec's avatar
      lib: Move common gpgpu/media fill functions to gpu_fill library · 081f7717
      Katarzyna Dec authored
      Gpgpu_fill and media_fill libraries are very similar and many
      functions can be shared. I have created library gpu_fill with
      all functions needed for implementing gpgpu_fill and media_fill
      tests for all Gens. For reviewing and debugging purposes this patch
      should be only moving functions from few libraries to one removing
      functions identical for both media and gpgpu.
      Places in the code that required more changes:
        Removing gen7_fill_gpgpu_kernel function that is identical to
      gen7_fill_media_kernel and introduces conflict with moving
      genX_fill_interface_descriptor, which are the same for media and gpgpu.
        Function gen8_fill_media_kernel is not removed in this patch
      (although it is identical with gen7 version), because this patch
      should be as much as possible functions movement.
        gen8_fill_interface_descriptor was unified for media and gpgpu
      by adding kernel and its size as a parameter (this parameters
      were missing in media gen8, gen8lp and gen9 functions)
        gen8_emit_state_base_address was unified, the one for gpgpu was
      configured like it would be using indirect state (while we are
      using CURBE). I have checked that media fill version
      (OUT_BATCH(0 | BASE_ADDRESS_MODIFY)) works fine on gpgpu gen8 and newer.
      
      v2: Changed code layout. GenX_fill_media_kernel was identical to
      genX_fill_gpgpu_kernel so this function was unified to
      gen7_fill_kernel. There were 2 very similar functions
      gen8_emit_state_base_address for media and gpgpu, where the one
      for gpgpu was configured like it would be using indirect state
      (while we are using CURBE). I have checked if media fill version
      works fine in gpgpu test on Gen8 and unified them.
      
      v3: Made patch easier for reviewing moving changes unifying code for
      various gens (that were included v1) to other patch, leaving only
      the most critical code changes.
      
      v5: Added copyrights and #ifndef to gpu_fill.h
      v5: Added copyrights to gpu_fill.c
      Signed-off-by: Katarzyna Dec's avatarKatarzyna Dec <katarzyna.dec@intel.com>
      Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
      Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Reviewed-by: Radosław's avatarRadoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
      081f7717