1. 17 Apr, 2019 4 commits
  2. 16 Apr, 2019 8 commits
  3. 15 Apr, 2019 8 commits
    • José Roberto de Souza's avatar
      tests/fbcon_fbt: Do not keep opening debugfs_fd at every setup_drm() call · cf27a37b
      José Roberto de Souza authored
      As debugfs_fd is used even after the teardown_drm(), it is not closed
      in this function or in any other place. And then it gets worse as
      every call to setup_drm() will open another file descriptor to
      debugfs dir.
      
      So lets move the opening of debugfs_fd to setup_environment() and only
      open it once and close it before leave the test.
      Reviewed-by: 's avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Reviewed-by: Dhinakaran Pandiyan's avatarDhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Signed-off-by: José Roberto de Souza's avatarJosé Roberto de Souza <jose.souza@intel.com>
      cf27a37b
    • José Roberto de Souza's avatar
      tests/fbcon_fbt: Do not try to open the same driver twice as master · e03b53c6
      José Roberto de Souza authored
      If a subtest fail before the teardown_drm() call it will keep the
      driver open as master causing the test to fail when trying to open
      the driver again as master, so lets share the drm_info struct and
      check if driver is already open.
      
      Starting subtest: psr
      (kms_fbcon_fbt:5270) CRITICAL: Test assertion failure function subtest, file ../tests/kms_fbcon_fbt.c:259:
      (kms_fbcon_fbt:5270) CRITICAL: Failed assertion: feature->wait_until_update(drm.debugfs_fd)
      Stack trace:
        #0 ../lib/igt_core.c:1474 __igt_fail_assert()
        #1 ../tests/kms_fbcon_fbt.c:261 subtest()
        #2 ../tests/kms_fbcon_fbt.c:316 __real_main309()
        #3 ../tests/kms_fbcon_fbt.c:309 main()
        #4 ../csu/libc-start.c:325 __libc_start_main()
        #5 [_start+0x29]
        #6 [<unknown>+0x0]
      Subtest psr failed.
      **** DEBUG ****
      (kms_fbcon_fbt:5270) drmtest-DEBUG: Test requirement passed: !(fd<0)
      (kms_fbcon_fbt:5270) igt_debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/1'
      (kms_fbcon_fbt:5270) DEBUG: Test requirement passed: drm->res
      (kms_fbcon_fbt:5270) igt_kms-DEBUG: VT: graphics mode set (mode was 0x0)
      (kms_fbcon_fbt:5270) DEBUG: Test requirement passed: feature->supported_on_chipset(drm.debugfs_fd)
      (kms_fbcon_fbt:5270) CRITICAL: Test assertion failure function subtest, file ../tests/kms_fbcon_fbt.c:259:
      (kms_fbcon_fbt:5270) CRITICAL: Failed assertion: feature->wait_until_update(drm.debugfs_fd)
      (kms_fbcon_fbt:5270) igt_core-INFO: Stack trace:
      (kms_fbcon_fbt:5270) igt_core-INFO:   #0 ../lib/igt_core.c:1474 __igt_fail_assert()
      (kms_fbcon_fbt:5270) igt_core-INFO:   #1 ../tests/kms_fbcon_fbt.c:261 subtest()
      (kms_fbcon_fbt:5270) igt_core-INFO:   #2 ../tests/kms_fbcon_fbt.c:316 __real_main309()
      (kms_fbcon_fbt:5270) igt_core-INFO:   #3 ../tests/kms_fbcon_fbt.c:309 main()
      (kms_fbcon_fbt:5270) igt_core-INFO:   #4 ../csu/libc-start.c:325 __libc_start_main()
      (kms_fbcon_fbt:5270) igt_core-INFO:   #5 [_start+0x29]
      (kms_fbcon_fbt:5270) igt_core-INFO:   #6 [<unknown>+0x0]
      ****  END  ****
      Subtest psr: FAIL (0.845s)
      Starting subtest: fbc-suspend
      Test requirement not met in function igt_device_set_master, file ../lib/igt_device.c:55:
      Test requirement: __igt_device_set_master(fd) == 0
      Can't become DRM master, please check if no other DRM client is running.
      Subtest fbc-suspend: SKIP (0.001s)
      Starting subtest: psr-suspend
      Test requirement not met in function igt_device_set_master, file ../lib/igt_device.c:55:
      Test requirement: __igt_device_set_master(fd) == 0
      Can't become DRM master, please check if no other DRM client is running.
      Subtest psr-suspend: SKIP (0.000s)
      Reviewed-by: 's avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Signed-off-by: José Roberto de Souza's avatarJosé Roberto de Souza <jose.souza@intel.com>
      e03b53c6
    • José Roberto de Souza's avatar
      tests/fbcon_fbt: Add and user psr_long_wait_update() · 14f4879b
      José Roberto de Souza authored
      When fbcon is enabled, PSR will be active between cursor blinks so
      what it should really use to test PSR is psr_wait_entry(), so a new
      feature callback was added.
      
      But the fbcon cursor blinks at 5hz what give us 200ms between each
      screen update what make psr_wait_update() prone to fail the test
      because it timed out before a blink could happen, so here adding and
      using psr_long_wait_update() that have a longer timeout.
      
      v3:
      - 3 previous patches squashed in this one (Maarten)
      - Back to !feature->wait_until_enabled() to test feature state when
      all CRTCS are disabled(Dhinakaran)
      
      Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Reviewed-by: Dhinakaran Pandiyan's avatarDhinkaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Signed-off-by: José Roberto de Souza's avatarJosé Roberto de Souza <jose.souza@intel.com>
      14f4879b
    • José Roberto de Souza's avatar
      tests/fbcon_fbt: Enable cursor blinking · d6f3323b
      José Roberto de Souza authored
      If cursor blinking is disabled no screen updates will happen and
      fbcon_fbt subtests will fail, so lets enable cursor blink while
      running this test and restore to the previous value when exiting it.
      
      v4:
      - renaming restore fd (Dhinakaran)
      - saving previous value as char (Dhinakaran)
      - skipping test if not able to open cursor blink file (Dhinakaran)
      
      Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
      Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
      Cc: Chris Wilson <chris@chris-wilson.co.uk>
      Reviewed-by: 's avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Signed-off-by: José Roberto de Souza's avatarJosé Roberto de Souza <jose.souza@intel.com>
      d6f3323b
    • José Roberto de Souza's avatar
      tests/fbcon_fbt: Allow fbcon to bind when running this test · 6c9a70f0
      José Roberto de Souza authored
      9c4114ec (lib: Always unbind the fbcon around igt) broke
      fbcon_fbt test as fbcon is not allowed to bind when executing any IGT
      test, so lets allow it again just for this test.
      
      Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
      Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
      Cc: Chris Wilson <chris@chris-wilson.co.uk>
      Reviewed-by: 's avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Reviewed-by: Dhinakaran Pandiyan's avatarDhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Signed-off-by: José Roberto de Souza's avatarJosé Roberto de Souza <jose.souza@intel.com>
      6c9a70f0
    • José Roberto de Souza's avatar
      tests/fbcon_fbt: Use psr_wait_entry() to wait PSR be enabled · eb04dcf3
      José Roberto de Souza authored
      kms_fbcon_fbt was doing its own handling to wait for PSR to get
      enabled while it is already available in lib.
      
      v2: splitted previous patch into this one and the previous one(Dhinakaran)
      
      Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Reviewed-by: 's avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Signed-off-by: José Roberto de Souza's avatarJosé Roberto de Souza <jose.souza@intel.com>
      eb04dcf3
    • Nicholas Kazlauskas's avatar
      tests: Add kms_plane_cursor tests · ff28c28c
      Nicholas Kazlauskas authored
      Tests various cursor plane interactions with primary and overlay planes.
      
      Correctness is verified by comparing CRC values to reference buffers
      drawn on the primary plane.
      
      There are existing generic multi-plane interaction tests but these
      don't test positional output on overlapping planes or extensively
      cover edge and corner cases for offseting and positioning planes based
      on DRM parameters.
      
      On hardware without dedicated cursor planes (such as AMDGPU) these tests
      are helpful for verifying software calculations done for positioning the
      cursor plane.
      
      Cc: Leo Li <sunpeng.li@amd.com>
      Cc: Harry Wentland <harry.wentland@amd.com>
      Signed-off-by: Nicholas Kazlauskas's avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
      Reviewed-by: Leo Li's avatarLeo Li <sunpeng.li@amd.com>
      ff28c28c
    • Sergii Romantsov's avatar
      meson: missed dependency of liblzma · 56bdc686
      Sergii Romantsov authored
      Failed to configure intel-gpu-tools with error:
      
      	meson.build:151:0: ERROR:  Could not generate cargs for libdw:
      
      libdw depends on liblzma.
      Installation of liblzma-dev fixes issue.
      At least it has to be pointed in Readme.
      
      v2: just readme updated
      
      Cc: Petri Latvala <petri.latvala@intel.com>
      CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Signed-off-by: 's avatarSergii Romantsov <sergii.romantsov@globallogic.com>
      Reviewed-by: Petri Latvala's avatarPetri Latvala <petri.latvala@intel.com>
      56bdc686
  4. 12 Apr, 2019 2 commits
  5. 11 Apr, 2019 4 commits
  6. 10 Apr, 2019 13 commits
  7. 09 Apr, 2019 1 commit