Commit f33fa714 authored by Tim Gore's avatar Tim Gore Committed by Daniel Vetter

lib/igt_core: make single/simple tests use igt_exit

Currently tests that use igt_simple_main will simply call
"exit()" if they pass, making it difficult to ensure that
any required cleanup is done. At present this is not an
issue, but it will be when I submit a patch to turn off the
lowmemorykiller for all tests.
Signed-off-by: 's avatarTim Gore <tim.gore@intel.com>
[danvet: Also update api docs.]
Signed-off-by: Daniel Vetter's avatarDaniel Vetter <daniel.vetter@intel.com>
parent 32a0308e
......@@ -641,7 +641,7 @@ bool igt_only_list_subtests(void)
static bool skipped_one = false;
static bool succeeded_one = false;
static bool failed_one = false;
static int igt_exitcode;
static int igt_exitcode = IGT_EXIT_SUCCESS;
static void exit_subtest(const char *) __attribute__((noreturn));
static void exit_subtest(const char *result)
......@@ -692,7 +692,8 @@ void igt_skip(const char *f, ...)
assert(in_fixture);
__igt_fixture_end();
} else {
exit(IGT_EXIT_SKIP);
igt_exitcode = IGT_EXIT_SKIP;
igt_exit();
}
}
......@@ -786,7 +787,7 @@ void igt_fail(int exitcode)
__igt_fixture_end();
}
exit(exitcode);
igt_exit();
}
}
......@@ -838,10 +839,9 @@ void __igt_fail_assert(int exitcode, const char *file,
* everything has worked out. For subtests it also checks that at least one
* subtest has been run (save when only listing subtests.
*
* It is an error to normally exit a test with subtests without calling
* igt_exit() - without it the result reporting will be wrong. To avoid such
* issues it is highly recommended to use #igt_main instead of a hand-rolled
* main() function.
* It is an error to normally exit a test calling igt_exit() - without it the
* result reporting will be wrong. To avoid such issues it is highly recommended
* to use #igt_main or #igt_simple_main instead of a hand-rolled main() function.
*/
void igt_exit(void)
{
......@@ -857,7 +857,7 @@ void igt_exit(void)
exit(IGT_EXIT_SUCCESS);
if (!test_with_subtests)
exit(IGT_EXIT_SUCCESS);
exit(igt_exitcode);
/* Calling this without calling one of the above is a failure */
assert(skipped_one || succeeded_one || failed_one);
......
......@@ -188,7 +188,7 @@ void igt_simple_init_parse_opts(int argc, char **argv,
int main(int argc, char **argv) { \
igt_simple_init(argc, argv); \
igt_tokencat(__real_main, __LINE__)(); \
exit(0); \
igt_exit(); \
} \
static void igt_tokencat(__real_main, __LINE__)(void) \
......
......@@ -65,7 +65,7 @@ static int do_fork(void)
igt_skip_on_simulation();
exit(0);
igt_exit();
} else {
if (list_subtests)
igt_subtest_init(2, argv_list);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment