Skip to content
  • Rodrigo Siqueira's avatar
    Avoid truncate string in __igt_lsof_fds · 8d8ebe2b
    Rodrigo Siqueira authored
    
    
    Note that 'proc_path' parameter in __igt_lsof_fds receives a string
    which was initialized with the size of PATH_MAX and the local variable
    'path' has the same size, but it also have to append: '/', '\0', and the
    directory name. This situation caused the warning described below.
    
    warning: ‘%s’ directive output may be truncated writing up to 255 bytes
    into a region of size between 0 and 4095 [-Wformat-truncation=]
    snprintf(path, sizeof(path), "%s/%s", proc_path, d->d_name);
    note: ‘snprintf’ output between 2 and 4352 bytes into a destination of
    size 4096 [..]
    
    This commit fixes this problem by changing the string size passed by
    __igt_lsoft to __igt_lsof_fds. The max size for the string is
    strlen("/proc/%d/cwd")+1 where "%d" can be estimated with
    CEILING(LOG_10(INT_MAX)), in this sense, it is safe to define a path
    size of 30 characters.
    
    Signed-off-by: default avatarRodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
    Reviewed-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
    8d8ebe2b