• Tvrtko Ursulin's avatar
    intel-gpu-top: Rewrite the tool to be safe to use · 63f0bf3d
    Tvrtko Ursulin authored
    intel-gpu-top is a dangerous tool which can hang machines due unsafe mmio
    register access. This patch rewrites it to use only PMU.
    Only overall command streamer busyness and GPU global data such as power
    and frequencies are included in this new version.
    For access to more GPU functional unit level data, an OA metric based tool
    like gpu-top should be used instead.
     * Sort engines by class and instance.
     * Do not wait for one sampling period to display something on screen.
     * Move code out of the asserts. (Rinat Ibragimov)
     * Continuously adapt to terminal size. (Rinat Ibragimov)
     * Change layout and precision of some field. (Chris Wilson)
     Eero Tamminen:
     * Use more user friendly engine names.
     * Don't error out if a counter is missing.
     * Add IMC read/write bandwidth.
     * Report minimum required kernel version.
     * Really support 4.16 by skipping of missing engines.
     * Simpler and less hacky float printing.
     * Preserve copyright header. (Antonio Argenziano)
     * Simplify engines_ptr macro. (Rinat Ibragimov)
     * Get RAPL unit from sysfs.
     * Consolidate sysfs paths with a macro.
     * Tidy error handling by carrying over and reporting errno.
     * Check against console height on all prints.
     * More readable minimum kernel version message. (Eero Tamminen)
     * Column banner for per engine stats. (Eero Tamminen)
     * Man page update. (Eero Tamminen)
    Signed-off-by: Tvrtko Ursulin's avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
    Cc: Petri Latvala <petri.latvala@intel.com>
    Cc: Eero Tamminen <eero.t.tamminen@intel.com>
    Cc: Rinat Ibragimov <ibragimovrinat@mail.ru>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> # v1
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v0.5
    Reviewed-by: Matthew Auld's avatarMatthew Auld <matthew.auld@intel.com>
igt_perf.h 1.93 KB