Daniel Vetter authored
There's a bunch of reasons why I think we should formalize and enforce our review rules for igt patches: - We have a lot of new engineers joining and review helps enormously with mentoring and learning. But right now only patches from contributors without commit rights are consistently subjected to review, which makes this imbalanced and removes senior contributors from the review pool. - We have a much bigger team and we need to make sure we're aligned on where igt as a tool and testsuite needs to head towards. Getting that alignment happens through reviewing each other's submission. Pushing a contentious patch and then dealing with a heated irc discussion is much less effective. - Finally igt becomes ever more important for our testing, making sure the code quality is high is important. Review helps with that. v2: Improve wording a bit (Imre). Acked-by: Daniel Stone <firstname.lastname@example.org> Acked-by: Jani Nikula <email@example.com> Acked-by: Joonas Lahtinen <firstname.lastname@example.org> Acked-by: Maarten Lankhorst <email@example.com> Acked-by: Petri Latvala <firstname.lastname@example.org> Acked-by: Imre Deak <email@example.com> Acked-by: Robert Foss <firstname.lastname@example.org> Acked-by: Ben Widawsky <email@example.com> Acked-by: Tvrtko Ursulin <firstname.lastname@example.org> Acked-by: Mika Kuoppala <email@example.com> Acked-by: Arkadiusz Hiler <firstname.lastname@example.org> Acked-by: Eric Anholt <email@example.com> Acked-by: Lionel Landwerlin <firstname.lastname@example.org> Acked-by: Lyude <email@example.com> Signed-off-by: Daniel Vetter <firstname.lastname@example.org>c42ab4d2
After you've reviewed these contribution guidelines, you'll be all set to contribute to this project.