From dcc82e0e6951fc8c738797868de848d70fef6203 Mon Sep 17 00:00:00 2001
From: Lucas De Marchi <lucas.demarchi@intel.com>
Date: Fri, 7 Feb 2025 15:09:40 -0800
Subject: [PATCH] runner/settings: Drop extra strdup
No need to strdup() again since the fscanf() function is already
allocating the variable. Just set the pointer to NULL so we "leak" our
variable to be saved in the settings.
Tested-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
Reviewed-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://lore.kernel.org/r/20250207231039.2883195-8-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
runner/settings.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/runner/settings.c b/runner/settings.c
index 73d8aa13d..693c5484e 100644
--- a/runner/settings.c
+++ b/runner/settings.c
@@ -1169,7 +1169,11 @@ static unsigned long parse_ul(char **val)
static char *parse_str(char **val)
{
- return *val ? strdup(*val) : NULL;
+ char *ret = *val;
+
+ *val = NULL;
+
+ return ret;
}
#define PARSE_LINE(s, name, val, field, _f) \
--
GitLab