Commit d7d3f4e8 authored by Arkadiusz Hiler's avatar Arkadiusz Hiler

lib/igt_aux: Make procps optional

Android does not have procps and it's not easy to compile it as a
dependency.

We can provide alternative, "naive" implementation that just shells out
to external commands (i.e. pkill and lsof) in case we do not have the
library.

v2: have separate functions for naive impls (J. Nikula)

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Arkadiusz Hiler's avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Petri Latvala's avatarPetri Latvala <petri.latvala@intel.com>
parent 86b59f84
......@@ -123,7 +123,11 @@ AC_SUBST(ASSEMBLER_WARN_CFLAGS)
PKG_CHECK_MODULES(DRM, [libdrm])
PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
PKG_CHECK_MODULES(KMOD, [libkmod])
PKG_CHECK_MODULES(PROCPS, [libprocps])
PKG_CHECK_MODULES(PROCPS, [libprocps], [procps=yes], [procps=no])
AM_CONDITIONAL(HAVE_PROCPS, [test "x$procps" = xyes])
if test x"$procps" = xyes; then
AC_DEFINE(HAVE_PROCPS,1,[Enable process managment without shelling out])
fi
PKG_CHECK_MODULES(VALGRIND, [valgrind], [have_valgrind=yes], [have_valgrind=no])
if test x$have_valgrind = xyes; then
......
......@@ -50,9 +50,7 @@
#include <sys/utsname.h>
#include <termios.h>
#include <assert.h>
#include <proc/readproc.h>
#include <linux/limits.h>
#include "drmtest.h"
#include "i915_drm.h"
#include "intel_chipset.h"
......@@ -71,6 +69,10 @@
#include <libgen.h> /* for dirname() */
#endif
#ifdef HAVE_PROCPS
#include <proc/readproc.h>
#endif
/**
* SECTION:igt_aux
* @short_description: Auxiliary libraries and support functions
......@@ -1293,6 +1295,7 @@ void igt_set_module_param_int(const char *name, int val)
* This function sends the signal @sig for a process found in process table
* with name @comm.
*/
#ifdef HAVE_PROCPS
int igt_terminate_process(int sig, const char *comm)
{
PROCTAB *proc;
......@@ -1317,7 +1320,19 @@ int igt_terminate_process(int sig, const char *comm)
closeproc(proc);
return err;
}
#else
#warning "No procps, using naive implementation of igt_terminate_process"
int igt_terminate_process(int sig, const char *comm)
{
char pkill_cmd[NAME_MAX];
snprintf(pkill_cmd, sizeof(pkill_cmd), "pkill -x -%d %s", sig, comm);
return system(pkill_cmd);
}
#endif
#ifdef HAVE_PROCPS
struct pinfo {
pid_t pid;
const char *comm;
......@@ -1499,6 +1514,7 @@ __igt_lsof(const char *dir)
closeproc(proc);
}
#endif
/**
* igt_lsof: Lists information about files opened by processes.
......@@ -1507,6 +1523,7 @@ __igt_lsof(const char *dir)
* This function mimics (a restrictive form of) lsof(8), but also shows
* information about opened fds.
*/
#ifdef HAVE_PROCPS
void
igt_lsof(const char *dpath)
{
......@@ -1531,6 +1548,18 @@ igt_lsof(const char *dpath)
free(sanitized);
}
#else
#warning "No procps, using naive implementation of igt_lsof"
void
igt_lsof(const char *dpath)
{
char lsof_cmd[NAME_MAX];
snprintf(lsof_cmd, sizeof(lsof_cmd), "lsof +d %s", dpath);
system(lsof_cmd);
}
#endif
static struct igt_siglatency {
timer_t timer;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment