Commit 91908d36 authored by slisovsk's avatar slisovsk Committed by Petri Latvala

igt/tests: Fix error checking in kms_atomic_transition

There is no guarantee that error return value will be
always EINVAL, made a check more general as it can be
ERANGE, ENOSPC, EINVAL and probably others, which all
mean the same in context of this test case: i.e this sprite
size is not valid.

v2: Added macro to make check look a bit nicer.
v3: Removed redundant debug line.
v4: Added assertion if error is not EINVAL as expected,
    other errors except EINVAL are considered now a failures.

Bugzilla: Stanislav Lisovskiy's avatarStanislav Lisovskiy <>
Reviewed-by: Stuart Summers's avatarStuart Summers <>
parent a382aeec
Pipeline #22617 passed with stages
in 10 minutes and 47 seconds
......@@ -188,6 +188,12 @@ static void set_sprite_wh(igt_display_t *display, enum pipe pipe,
#define is_atomic_check_failure_errno(errno) \
(errno != -EINVAL && errno != 0)
#define is_atomic_check_plane_size_errno(errno) \
(errno == -EINVAL)
static void setup_parms(igt_display_t *display, enum pipe pipe,
const drmModeModeInfo *mode,
struct igt_fb *primary_fb,
......@@ -281,8 +287,9 @@ retry:
wm_setup_plane(display, pipe, (1 << n_planes) - 1, parms, false);
ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
if (ret == -EINVAL) {
if (is_atomic_check_plane_size_errno(ret)) {
if (cursor_width == sprite_width &&
cursor_height == sprite_height) {
......@@ -472,7 +479,9 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output
ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
if (ret != -EINVAL || pipe_obj->n_planes < 3)
if (!is_atomic_check_plane_size_errno(ret) || pipe_obj->n_planes < 3)
ret = 0;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment