Commit 7ef80c0a authored by Sonika Jindal's avatar Sonika Jindal Committed by Thomas Wood

lib/igt_kms: Let set_property return the result

Return the return value of the set_property ioctl and add check for
the failure.
Signed-off-by: default avatarSonika Jindal <>
Reviewed-by: Tvrtko Ursulin's avatarTvrtko Ursulin <>
Signed-off-by: default avatarThomas Wood <>
parent 7aeecc19
......@@ -930,13 +930,13 @@ get_plane_property(int drm_fd, uint32_t plane_id, const char *name,
name, prop_id, value, prop);
static void
static int
igt_plane_set_property(igt_plane_t *plane, uint32_t prop_id, uint64_t value)
igt_pipe_t *pipe = plane->pipe;
igt_display_t *display = pipe->display;
drmModeObjectSetProperty(display->drm_fd, plane->drm_plane->plane_id,
return drmModeObjectSetProperty(display->drm_fd, plane->drm_plane->plane_id,
DRM_MODE_OBJECT_PLANE, prop_id, value);
......@@ -1390,10 +1390,11 @@ static int igt_drm_plane_commit(igt_plane_t *plane,
plane->size_changed = false;
if (plane->rotation_changed) {
igt_plane_set_property(plane, plane->rotation_property,
ret = igt_plane_set_property(plane, plane->rotation_property,
plane->rotation_changed = false;
CHECK_RETURN(ret, fail_on_error);
return 0;
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment