amdgpu kernel 5.2 blank display after resume from suspend

Submitted by csp..@..on.net

Assigned to Default DRI bug account

Link to original bug (#111244)

Description

Created attachment 144901
kernel log

Model: Lenovo Ideapad S340 15"
CPU: AMD Ryzen 5 3500U

Starting with kernel 5.2, laptop has a blank display after resuming from suspend. Problem doesn't appear with recent kernels up to 5.1.16. Attached is a kernel log and git bisect logs.

Attachment 144901, "kernel log":
kernel.log

See also

• https://bugs.freedesktop.org/show_bug.cgi?id=111122

added AMDgpu bugzilla labels

csp..@..on.net uploaded an attachment:

Attachment 144902, "first bisect log":
git-bisect1.log

csp..@..on.net uploaded an attachment:

Attachment 144903, "second bisect log":
git-bisect2.log

Michel Dänzer @daenzer said:

The fact that you got two different bisection results indicates that the problem might be not 100% reproducible, and you accidentally marked some affected commits as good. Please test a given commit longer / more often before declaring it "good".

csp..@..on.net said:

The first bisect pointed to a merge commit so the second was done to bisect within the merged commits.

Michel Dänzer @daenzer said:

(In reply to cspack from comment 4)

The first bisect pointed to a merge commit so the second was done to bisect
within the merged commits.

That doesn't invalidate my previous comment. :) git bisect identifying a merge commit already indicates the same thing by itself. In particular, the fact that it identified a merge commit means that you declared all of its parent commits good.

(There *are* rare cases where a problem is actually introduced by a merge commit itself, but then the second bisection should have either identified the same merge commit again (if you tested it again), or failed, because all the other commits you tested should have been good again.)

csp..@..on.net said:

I see your point, and you are correct. It seems the issue is not 100% reproducible. I will redo the bisect and test more thoroughly. Thank you.

Samuele Decarli said:

@cspack I am currently repeating your bisection on similar hardware, however I have found 27eaa4927dc3be669ed70670241597ac73595caf to be bad. Could you please retest that commit as well?

Samuele Decarli uploaded an attachment:

Model: HP EliteBook 745 G5
CPU/GPU: AMD Ryzen 7 PRO 2700U

I completed my bisection and this is the log.
The first bad commit seems to be this one. It's actually a fairly innocent commit, so it's probably causing a bug somewhere else.

df8368be1382b442384507a5147c89978cd60702 is the first bad commit
commit df8368be1382b442384507a5147c89978cd60702
Author: Nicholas Kazlauskas nicholas.kazlauskas@amd.com
Date: Wed Feb 27 12:56:36 2019 -0500

drm/amdgpu: Bump amdgpu version for per-flip plane tiling updates

To help xf86-video-amdgpu and mesa know DC supports updating the
tiling attributes for a framebuffer per-flip.

Cc: Michel Dänzer michel@daenzer.net
Signed-off-by: Nicholas Kazlauskas nicholas.kazlauskas@amd.com
Acked-by: Alex Deucher alexander.deucher@amd.com
Reviewed-by: Marek Olšák marek.olsak@amd.com
Signed-off-by: Alex Deucher alexander.deucher@amd.com

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Attachment 144928, "Result of git bisect":
git-bisect.log

Samuele Decarli uploaded an attachment:

Compressed here is my kernel log, which shows repeating stack traces

Attachment 144929, "Kernel log displaying issue":
kernel.tar.gz

Samuele Decarli said:

Interestingly the same commit is blamed for anther issue
https://bugs.freedesktop.org/show_bug.cgi?id=111122

csp..@..on.net said:

@Samuele Yes, after redoing the bisect I got the same result as you did. Thanks.

csp..@..on.net said:

One thing to note, the problem doesn't seem to occur for me if a compositor isn't running. In my case, after disabling compton I could not reproduce the problem.

Samuele Decarli said:

Similar thing for me: disabling composition in Plasma makes suspend/resume work again.

Damian Kaczmarek @Rush said:

Another workaround is to switch to the text terminal (Ctrl+Alt+F2) before suspending.

Occuring on Thinkpad T495, Ryzej 3700U, openSUSE Tumbleweed (kernel 5.2.2-1)

Damian Kaczmarek @Rush said:

Are any other known workarounds? Perhaps some kernel options?

csp..@..on.net said:

This commit in xf86-video-amdgpu seem to be where things break https://github.com/freedesktop/xorg-xf86-video-amdgpu/commit/a2b32e72fdaff3007a79b84929997d8176c2d512

Adding amdgpu.dc=1 to kernel options seems fix the issue for me.

csp..@..on.net uploaded an attachment:

Attachment 144967, "xf86-video-amdgpu git bisect":
git-bisect-xf86-video-amdgpu.log

Michel Dänzer @daenzer said:

(In reply to cspack from comment 16)

Adding amdgpu.dc=1 to kernel options seems fix the issue for me.

Presumably you mean amdgpu.dc=0 ?

Your findings indicate that the kernel driver DC code doesn't handle flipping between buffers with different tiling parameters correctly in some cases.

csp..@..on.net said:

With amdgpu.dc=0, X doesn't start ((EE) AMDGPU(0): No modes.)