"drm/amdgpu: skip ASIC reset for APUs when go to S4" cause suspend to disk failed. the power supply is not turned off

"drm/amdgpu: skip ASIC reset for APUs when go to S4" cause suspend to disk failed, test on apu 3400g B450 Gaming-ITX/ac, the power supply is not turned off

Please attach your dmesg output.

no different dmesg. it cause power supply is not turned off, have to replug power to resume from suspend. look video, https://drive.google.com/drive/folders/1dftu82RW-YOcuYMMLlBybCSH9A4MOoLq?usp=share_link

suspend no problem, i have to replug power when every resume from suspend.

We need to see more details about your hardware though, so please attach the dmesg.

added S4 label

dmesg6.3.txt

I suggest to remove the below patch from your kernel and try again. https://www.spinics.net/lists/amd-gfx/msg89708.html

Hi youling,

Two questions about this issue:

1. What is the probability of this S4 suspend failure?
2. Is it the the dmesg log after apply the patch "drm/amdgpu: skip ASIC reset for APUs when go to S4", I got the line "[ 82.773084] amdgpu 0000:0b:00.0: amdgpu: MODE2 reset" from the dmesg6.3.txt, if apply the patch, we should not got this line.

Thanks

with "drm/amdgpu: skip ASIC reset for APUs when go to S4", look the video power on.mp4 and replug power.mp4.

revert "drm/amdgpu: skip ASIC reset for APUs when go to S4", look the video power off.mp4.

demesg6.3.txt is revert "drm/amdgpu: skip ASIC reset for APUs when go to S4".

Hi @youling257
Dose the commit reverting work for you? Is the S4 normally suspend/resume now?

of course

my hardware power on when go to s4 with "drm/amdgpu: skip ASIC reset for APUs when go to S4".

my hardware power off when go to s4 revert "drm/amdgpu: skip ASIC reset for APUs when go to S4".

As the feedback from @youling257 After he rever the commit "drm/amdgpu: skip ASIC reset for APUs when go to S4"

S4 is working normally.

So we need to revert the patch from upstream in short time, and revise the patch for all the APUs for long term fix. @TimXhHuang

Tim posted a patch that should fix this while still helping existing issue on GFX11 ASIC. https://patchwork.freedesktop.org/patch/529648/

Test this patch fixed my issue.

mentioned in commit agd5f/linux@2fec9dc8

Fix applied.

closed

mentioned in commit nouveau@febacc33

mentioned in commit nouveau@ef3064e4

mentioned in commit agd5f/linux@c44aa9b4

mentioned in commit agd5f/linux@980d5bae

mentioned in issue #2537