Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D drm-hwcomposer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • drm-hwcomposer
  • drm-hwcomposer
  • Merge requests
  • !72

Remove redundant hotplug call

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Roman Kovalivskyi requested to merge roman.kovalivskyi/drm-hwcomposer:double-hotplug-fix into master Nov 21, 2019
  • Overview 5
  • Commits 1
  • Pipelines 3
  • Changes 1

Initial hotplug state is reported back during callback registration, but during VTS tests we've noticed error that is caused by calling hotplug with same display twice.

HandleInitialHotplugState calls hotplug function for each connected display, so it covers HWC_DISPLAY_PRIMARY too, therefore first call should be removed, as it is redundant and causes minor error.

Smoke testing haven't found any new issues and running VtsHalGraphicsComposerV2_1Target shows that issue was fixed. VTS test results before proposed changes:

Module Passed Failed Total Tests
arm64-v8a VtsHalGraphicsComposerV2_1Target 0 53 53
armeabi-v7a VtsHalGraphicsComposerV2_1Target 0 53 53

Vts test results after removing redundant hotplug call:

Module Passed Failed Total Tests
arm64-v8a VtsHalGraphicsComposerV2_1Target 31 22 53
armeabi-v7a VtsHalGraphicsComposerV2_1Target 31 22 53
Edited Dec 12, 2019 by Roman Kovalivskyi
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: double-hotplug-fix