Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D drm-hwcomposer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • drm-hwcomposer
  • drm-hwcomposer
  • Merge requests
  • !44

drm_hwcomposer: Add support for Arm Framebuffer Compression (AFBC) modifiers.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ayan Kumar Halder requested to merge ayan.halder/drm-hwcomposer:gitlab_master1 into master Jan 31, 2019
  • Overview 7
  • Commits 1
  • Pipelines 3
  • Changes 2

One needs to translate the Gralloc buffer flags for AFBC (eg MALI_GRALLOC_INTFMT_AFBC_BASIC) to the corresponding linux kernel drm modifiers. This gets passed to libdrm via drmModeAddFB2WithModifiers.

Changes from v1:-

  • Moved ConvertGrallocFormatToDrmModifiers() and IsDrmFormatRgb() from 'DrmGenericImporter' to 'HisiImporter' as suggested by Sean paul
  • Check if the format is rgb and set AFBC_FORMAT_MOD_YTR only if any of the AFBC related Gralloc flags are set.

Changes from v2:-

  • Changed ConvertGrallocFormatToDrmModifiers() and IsDrmFormatRgb() from 'public' to 'private' (suggested by Sean Paul)

Changes from v3:-

  • Reordered the members of 'class HisiImporter'. Functions should go above member variables. (suggested by Sean Paul)

Signed-off-by: Ayan Kumar Halder ayan.halder@arm.com Reviewed-by: Sean Paul seanpaul@chromium.org

/-- Note for reviewer I was able to get this working for hikey960 with aosp/master for kernel 4.14. The libdrm headers need to be updated as the AFBC modifiers are missing in the aosp/master's external/libdrm. --/

Change-Id: I66abaa08d19ce88169cc40522b167dfe5efc7036

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gitlab_master1