1. 31 Jul, 2017 4 commits
  2. 21 Jul, 2017 1 commit
  3. 20 Jul, 2017 1 commit
  4. 11 Jul, 2017 1 commit
  5. 06 Jul, 2017 1 commit
  6. 05 Jul, 2017 2 commits
  7. 04 Jul, 2017 2 commits
  8. 29 Jun, 2017 2 commits
  9. 27 Jun, 2017 3 commits
  10. 22 Jun, 2017 1 commit
  11. 20 Jun, 2017 18 commits
  12. 19 Jun, 2017 4 commits
    • Aaron Plattner's avatar
      randr: Use RRTransformEqual in RRCrtcPendingTransform · 091af80b
      Aaron Plattner authored
      
      
      Currently, RRCrtcPendingTransform returns false unless the
      transformation matrix itself is changing. This makes RRCrtcSet skip
      doing anything if the only thing that is changing is the transform
      filter.
      
      There's already a function for comparing RRTransformPtrs, so use that
      instead.
      
      Tested by running
      
        xrandr --output DP-1 --mode 1920x1080 --rate 144 --scale 0.5x0.5 --filter nearest
      
      follwed by
      
        xrandr --output DP-1 --mode 1920x1080 --rate 144 --scale 0.5x0.5 --filter bilinear
      Signed-off-by: Aaron Plattner's avatarAaron Plattner <aplattner@nvidia.com>
      Reviewed-and-Tested-by: Michel Dänzer's avatarMichel Dänzer <michel.daenzer@amd.com>
      091af80b
    • Michal Srb's avatar
      Xi: Do not try to swap GenericEvent. · ba336b24
      Michal Srb authored
      
      
      The SProcXSendExtensionEvent must not attempt to swap GenericEvent because
      it is assuming that the event has fixed size and gives the swapping function
      xEvent-sized buffer.
      
      A GenericEvent would be later rejected by ProcXSendExtensionEvent anyway.
      Signed-off-by: default avatarMichal Srb <msrb@suse.com>
      Reviewed-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      ba336b24
    • Michal Srb's avatar
      Xi: Verify all events in ProcXSendExtensionEvent. · 8caed4df
      Michal Srb authored
      
      
      The requirement is that events have type in range
      EXTENSION_EVENT_BASE..lastEvent, but it was tested
      only for first event of all.
      Signed-off-by: default avatarMichal Srb <msrb@suse.com>
      Reviewed-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      8caed4df
    • Michal Srb's avatar
      dix: Disallow GenericEvent in SendEvent request. · 215f8949
      Michal Srb authored
      The SendEvent request holds xEvent which is exactly 32 bytes long, no more,
      no less. Both ProcSendEvent and SProcSendEvent verify that the received data
      exactly match the request size. However nothing stops the client from passing
      in event with xEvent::type = GenericEvent and any value of
      xGenericEvent::length.
      
      In the case of ProcSendEvent, the event will be eventually passed to
      WriteEventsToClient which will see that it is Generic event and copy the
      arbitrary length from the receive buffer (and possibly past it) and send it to
      the other client. This allows clients to copy unitialized heap memory out of X
      server or to crash it.
      
      In case of SProcSendEvent, it will attempt to swap the incoming event by
      calling a swapping function from the EventSwapVector array. The swapped event
      is written to target buffer, which in this case is local xEvent variable. The
      xEvent variable is 32 bytes long, but the swapping functions for GenericEvents
      expect that the target bu...
      215f8949