1. 17 Apr, 2019 1 commit
    • Eric Anholt's avatar
      glamor: Introduce a central place for our pixmap format/type handling. · 8702c938
      Eric Anholt authored
      We had various helper functions trying to come up with the
      internalformat/format/type/render formats for pixmaps, and it's much
      nicer to just detect what those should be once at startup.  This gives
      us a chance to do the right thing for GLES.
      
      It also, notably, fixes our format/type for depth 15 and 16 setup for
      desktop GL, so that we actually allocate 16bpp (GL_RGB/565) on most
      drivers instead of 32bpp (GL_RGB/UBYTE).
      
      GLES still has regressions over desktop (2 regressions in llvmpipe
      XTS, many in rendercheck), but I think this is a good baseline.
      Signed-off-by: Eric Anholt's avatarEric Anholt <eric@anholt.net>
      8702c938
  2. 15 Mar, 2017 1 commit
  3. 30 Sep, 2016 1 commit
  4. 26 May, 2016 1 commit
    • Keith Packard's avatar
      glamor: Preserve GL_RED bits in R channel when destination is GL_RED [v2] · 181a4bd0
      Keith Packard authored
      A1 and A8 pixmaps are usually stored in the Red channel to conform
      with more recent GL versions. When using these pixmaps as mask values,
      that works great. When using these pixmaps as source values, then the
      value we want depends on what the destination looks like.
      
      For RGBA or RGB destinations, then we want to use the Red channel
      for A values and leave RGB all set to zero.
      
      For A destinations, then we want to leave the R values in the Red
      channel so that they end up in the Red channel of the output.
      
      This patch adds a helper function, glamor_bind_texture, which performs
      the glBindTexture call along with setting the swizzle parameter
      correctly for the Red channel. The swizzle parameter for the Alpha
      channel doesn't depend on the destination as it's safe to leave it
      always swizzled from the Red channel.
      
      This fixes incorrect rendering in firefox for this page:
      
      	https://gfycat.com/HoarseCheapAmericankestrel
      
      while not breaking rendering for this page:
      
      	https://feedly.com
      
      v2: Add change accidentally left in patch for missing
          glDisable(GL_COLOR_LOGIC_OP).
          Found by Emil Velikov <emil.l.velikov@gmail.com>
      
      Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63397Signed-off-by: Keith Packard's avatarKeith Packard <keithp@keithp.com>
      Tested-by: Michel Dänzer's avatarMichel Dänzer <michel.daenzer@amd.com>
      181a4bd0
  5. 30 Jan, 2016 1 commit
  6. 14 May, 2015 1 commit
  7. 24 Mar, 2015 4 commits
  8. 18 Jul, 2014 1 commit
  9. 23 Apr, 2014 1 commit
  10. 03 Apr, 2014 1 commit