Commit b8e692d9 authored by Zhigang Gong's avatar Zhigang Gong Committed by Zhigang Gong

glamor: Move the blend set up after the pixmap uploading.

This is a bug, as if we do blend set up before do the pixmap
dynamic uploading. We will have a incorrect blend env when
doing the uploading.
Signed-off-by: Zhigang Gong's avatarZhigang Gong <>
parent bf782283
......@@ -838,10 +838,6 @@ glamor_composite_with_shader(CARD8 op,
if (!good_dest_format(dest)) {
goto fail;
if (!glamor_set_composite_op(screen, op, dest, mask)) {
goto fail;
if (source_status == GLAMOR_UPLOAD_PENDING
&& mask_status == GLAMOR_UPLOAD_PENDING
......@@ -849,17 +845,13 @@ glamor_composite_with_shader(CARD8 op,
if (source->format != mask->format) {
saved_source_format = source->format;
/* XXX
* when need to flip the texture and mask and source share the same pixmap,
* there is a bug, need to be fixed. *
if (!glamor_priv->yInverted)
goto fail;
if (!combine_pict_format(&source->format, source->format, mask->format, {
glamor_fallback("combine source %x mask %x failed.\n",
source->format, mask->format);
goto fail;
if (source->format != saved_source_format) {
glamor_picture_format_fixup(source, source_pixmap_priv);
......@@ -913,7 +905,9 @@ glamor_composite_with_shader(CARD8 op,
if (!glamor_set_composite_op(screen, op, dest, mask)) {
goto fail;
shader = glamor_lookup_composite_shader(screen, &key);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment