Commit 27c4c045 authored by Zhigang Gong's avatar Zhigang Gong Committed by Eric Anholt

Remove the assertion which is not safe sometimes.

The original version assumes that each drawable pixmap should
have a valid private pixmap pointer. But this is not true after
we create this libglamor. As the DDX layer may create a pure
software drawable pixmap which doesn't have a private pixmap
Signed-off-by: default avatarZhigang Gong <>
parent c65dc686
......@@ -16,9 +16,7 @@ glamor_upload_picture_to_texture(PicturePtr picture)
glamor_pixmap_private *pixmap_priv;
pixmap = glamor_get_drawable_pixmap(picture->pDrawable);
pixmap_priv = glamor_get_pixmap_private(pixmap);
assert(GLAMOR_PIXMAP_PRIV_IS_PICTURE(pixmap_priv) == 1);
return glamor_upload_pixmap_to_texture(pixmap);
......@@ -65,8 +63,7 @@ glamor_create_picture(PicturePtr picture)
pixmap_priv->is_picture = 1;
pixmap_priv->pict_format = picture->format;
/* XXX Some formats are compatible between glamor and ddx driver*/
if (pixmap_priv->type == GLAMOR_TEXTURE_DRM
/*&& pixmap_priv->pict_format != PICT_b8g8r8a8*/)
if (pixmap_priv->type == GLAMOR_TEXTURE_DRM)
glamor_set_pixmap_type(pixmap, GLAMOR_SEPARATE_TEXTURE);
return glamor_priv->saved_create_picture(picture);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment